[PATCH v2 0/3] selftests: lib.mk improvements

public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH v2 0/3] selftests: lib.mk improvements
@ 2020-05-15 12:00 Yauheni Kaliuta
  2020-05-15 12:00 ` [PATCH v2 1/3] selftests: do not use .ONESHELL Yauheni Kaliuta
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: Yauheni Kaliuta @ 2020-05-15 12:00 UTC (permalink / raw)
  To: bpf; +Cc: Jiri Benc, Jiri Olsa, Shuah Khan


Yauheni Kaliuta (3):
  selftests: do not use .ONESHELL
  selftests: fix condition in run_tests
  selftests: simplify run_tests

 tools/testing/selftests/lib.mk | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

-- 
2.26.2


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v2 1/3] selftests: do not use .ONESHELL
  2020-05-15 12:00 [PATCH v2 0/3] selftests: lib.mk improvements Yauheni Kaliuta
@ 2020-05-15 12:00 ` Yauheni Kaliuta
  2020-05-15 12:40   ` Jiri Benc
  2020-05-19  7:44   ` Yauheni Kaliuta
  2020-05-15 12:00 ` [PATCH v2 2/3] selftests: fix condition in run_tests Yauheni Kaliuta
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 12+ messages in thread
From: Yauheni Kaliuta @ 2020-05-15 12:00 UTC (permalink / raw)
  To: bpf; +Cc: Jiri Benc, Jiri Olsa, Shuah Khan

Using one shell for the whole recipe with long lists can cause

make[1]: execvp: /bin/sh: Argument list too long

with some shells. Triggered by commit 309b81f0fdc4 ("selftests/bpf:
Install generated test progs")

It requires to change the rule which rely on the one shell
behaviour (run_tests).

Simplify also INSTALL_SINGLE_RULE, remove extra echo, required to
workaround .ONESHELL.

Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Cc: Jiri Benc <jbenc@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>
---
 tools/testing/selftests/lib.mk | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index b0556c752443..5b82433d88e3 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -59,9 +59,8 @@ else
 all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
 endif
 
-.ONESHELL:
 define RUN_TESTS
-	@BASE_DIR="$(selfdir)";			\
+	BASE_DIR="$(selfdir)";			\
 	. $(selfdir)/kselftest/runner.sh;	\
 	if [ "X$(summary)" != "X" ]; then       \
 		per_test_logging=1;		\
@@ -71,22 +70,21 @@ endef
 
 run_tests: all
 ifdef building_out_of_srctree
-	@if [ "X$(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)" != "X" ]; then
-		@rsync -aq $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(OUTPUT)
+	@if [ "X$(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)" != "X" ]; then \
+		rsync -aq $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(OUTPUT); \
 	fi
-	@if [ "X$(TEST_PROGS)" != "X" ]; then
-		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(OUTPUT)/$(TEST_PROGS))
-	else
-		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS))
+	@if [ "X$(TEST_PROGS)" != "X" ]; then \
+		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(OUTPUT)/$(TEST_PROGS)) ; \
+	else \
+		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS)); \
 	fi
 else
-	$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(TEST_PROGS))
+	@$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(TEST_PROGS))
 endif
 
 define INSTALL_SINGLE_RULE
 	$(if $(INSTALL_LIST),@mkdir -p $(INSTALL_PATH))
-	$(if $(INSTALL_LIST),@echo rsync -a $(INSTALL_LIST) $(INSTALL_PATH)/)
-	$(if $(INSTALL_LIST),@rsync -a $(INSTALL_LIST) $(INSTALL_PATH)/)
+	$(if $(INSTALL_LIST),rsync -a $(INSTALL_LIST) $(INSTALL_PATH)/)
 endef
 
 define INSTALL_RULE
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 1/3] selftests: do not use .ONESHELL
  2020-05-15 12:00 ` [PATCH v2 1/3] selftests: do not use .ONESHELL Yauheni Kaliuta
@ 2020-05-15 12:40   ` Jiri Benc
  2020-05-19  7:44   ` Yauheni Kaliuta
  1 sibling, 0 replies; 12+ messages in thread
From: Jiri Benc @ 2020-05-15 12:40 UTC (permalink / raw)
  To: Yauheni Kaliuta; +Cc: bpf, Jiri Olsa, Shuah Khan

On Fri, 15 May 2020 15:00:24 +0300, Yauheni Kaliuta wrote:
> Using one shell for the whole recipe with long lists can cause
> 
> make[1]: execvp: /bin/sh: Argument list too long
> 
> with some shells. Triggered by commit 309b81f0fdc4 ("selftests/bpf:
> Install generated test progs")
> 
> It requires to change the rule which rely on the one shell
> behaviour (run_tests).
> 
> Simplify also INSTALL_SINGLE_RULE, remove extra echo, required to
> workaround .ONESHELL.
> 
> Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
> Cc: Jiri Benc <jbenc@redhat.com>
> Cc: Shuah Khan <shuah@kernel.org>

Acked-by: Jiri Benc <jbenc@redhat.com>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 1/3] selftests: do not use .ONESHELL
  2020-05-15 12:00 ` [PATCH v2 1/3] selftests: do not use .ONESHELL Yauheni Kaliuta
  2020-05-15 12:40   ` Jiri Benc
@ 2020-05-19  7:44   ` Yauheni Kaliuta
  1 sibling, 0 replies; 12+ messages in thread
From: Yauheni Kaliuta @ 2020-05-19  7:44 UTC (permalink / raw)
  To: Shuah Khan; +Cc: Jiri Benc, Jiri Olsa, Shuah Khan, bpf, Daniel Borkmann

Hi, Shuah!

Any comment on that? The patch is ACKes by Jiri already.

>>>>> On Fri, 15 May 2020 15:00:24 +0300, Yauheni Kaliuta  wrote:

 > Using one shell for the whole recipe with long lists can cause
 > make[1]: execvp: /bin/sh: Argument list too long

 > with some shells. Triggered by commit 309b81f0fdc4 ("selftests/bpf:
 > Install generated test progs")

 > It requires to change the rule which rely on the one shell
 > behaviour (run_tests).

 > Simplify also INSTALL_SINGLE_RULE, remove extra echo, required to
 > workaround .ONESHELL.

 > Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
 > Cc: Jiri Benc <jbenc@redhat.com>
 > Cc: Shuah Khan <shuah@kernel.org>
 > ---
 >  tools/testing/selftests/lib.mk | 20 +++++++++-----------
 >  1 file changed, 9 insertions(+), 11 deletions(-)

 > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
 > index b0556c752443..5b82433d88e3 100644
 > --- a/tools/testing/selftests/lib.mk
 > +++ b/tools/testing/selftests/lib.mk
 > @@ -59,9 +59,8 @@ else
 >  all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
 >  endif
 
 > -.ONESHELL:
 >  define RUN_TESTS
 > -	@BASE_DIR="$(selfdir)";			\
 > +	BASE_DIR="$(selfdir)";			\
 >  	. $(selfdir)/kselftest/runner.sh;	\
 >  	if [ "X$(summary)" != "X" ]; then       \
 >  		per_test_logging=1;		\
 > @@ -71,22 +70,21 @@ endef
 
 >  run_tests: all
 >  ifdef building_out_of_srctree
 > -	@if [ "X$(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)" != "X" ]; then
 > -		@rsync -aq $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(OUTPUT)
 > +	@if [ "X$(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)" != "X" ]; then \
 > +		rsync -aq $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(OUTPUT); \
 >  	fi
 > -	@if [ "X$(TEST_PROGS)" != "X" ]; then
 > -		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(OUTPUT)/$(TEST_PROGS))
 > -	else
 > -		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS))
 > +	@if [ "X$(TEST_PROGS)" != "X" ]; then \
 > +		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(OUTPUT)/$(TEST_PROGS)) ; \
 > +	else \
 > +		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS)); \
 >  	fi
 >  else
 > -	$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(TEST_PROGS))
 > +	@$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(TEST_PROGS))
 >  endif
 
 >  define INSTALL_SINGLE_RULE
 >  	$(if $(INSTALL_LIST),@mkdir -p $(INSTALL_PATH))
 > -	$(if $(INSTALL_LIST),@echo rsync -a $(INSTALL_LIST) $(INSTALL_PATH)/)
 > -	$(if $(INSTALL_LIST),@rsync -a $(INSTALL_LIST) $(INSTALL_PATH)/)
 > +	$(if $(INSTALL_LIST),rsync -a $(INSTALL_LIST) $(INSTALL_PATH)/)
 >  endef
 
 >  define INSTALL_RULE
 > -- 
 > 2.26.2


-- 
WBR,
Yauheni Kaliuta


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v2 2/3] selftests: fix condition in run_tests
  2020-05-15 12:00 [PATCH v2 0/3] selftests: lib.mk improvements Yauheni Kaliuta
  2020-05-15 12:00 ` [PATCH v2 1/3] selftests: do not use .ONESHELL Yauheni Kaliuta
@ 2020-05-15 12:00 ` Yauheni Kaliuta
  2020-05-15 12:40   ` Jiri Benc
  2020-05-15 12:00 ` [PATCH v2 3/3] selftests: simplify run_tests Yauheni Kaliuta
  2020-05-19 13:59 ` [PATCH v2 0/3] selftests: lib.mk improvements shuah
  3 siblings, 1 reply; 12+ messages in thread
From: Yauheni Kaliuta @ 2020-05-15 12:00 UTC (permalink / raw)
  To: bpf; +Cc: Jiri Benc, Jiri Olsa, Shuah Khan

The check if there are any files to install in case of no files
compares "X  " with "X" so never false.

Remove extra spaces. It may make sense to use make's $(if) function
here.

Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
---
 tools/testing/selftests/lib.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 5b82433d88e3..7a17ea815736 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -70,7 +70,7 @@ endef
 
 run_tests: all
 ifdef building_out_of_srctree
-	@if [ "X$(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)" != "X" ]; then \
+	@if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ]; then \
 		rsync -aq $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(OUTPUT); \
 	fi
 	@if [ "X$(TEST_PROGS)" != "X" ]; then \
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 2/3] selftests: fix condition in run_tests
  2020-05-15 12:00 ` [PATCH v2 2/3] selftests: fix condition in run_tests Yauheni Kaliuta
@ 2020-05-15 12:40   ` Jiri Benc
  0 siblings, 0 replies; 12+ messages in thread
From: Jiri Benc @ 2020-05-15 12:40 UTC (permalink / raw)
  To: Yauheni Kaliuta; +Cc: bpf, Jiri Olsa, Shuah Khan

On Fri, 15 May 2020 15:00:25 +0300, Yauheni Kaliuta wrote:
> The check if there are any files to install in case of no files
> compares "X  " with "X" so never false.
> 
> Remove extra spaces. It may make sense to use make's $(if) function
> here.
> 
> Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>

Acked-by: Jiri Benc <jbenc@redhat.com>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v2 3/3] selftests: simplify run_tests
  2020-05-15 12:00 [PATCH v2 0/3] selftests: lib.mk improvements Yauheni Kaliuta
  2020-05-15 12:00 ` [PATCH v2 1/3] selftests: do not use .ONESHELL Yauheni Kaliuta
  2020-05-15 12:00 ` [PATCH v2 2/3] selftests: fix condition in run_tests Yauheni Kaliuta
@ 2020-05-15 12:00 ` Yauheni Kaliuta
  2020-05-19 13:59 ` [PATCH v2 0/3] selftests: lib.mk improvements shuah
  3 siblings, 0 replies; 12+ messages in thread
From: Yauheni Kaliuta @ 2020-05-15 12:00 UTC (permalink / raw)
  To: bpf; +Cc: Jiri Benc, Jiri Olsa, Shuah Khan

Remove redundant check for TEST_PROGS and use the same command for
in- and out-of-source builds, and

fix bug with adding $(OUTPUT)/ to first $(TEST_PROGS) element only:

1) use $(addprefix ...) function to add $(OUTPUT). In case of blank
$(TEST_PROGS) it will be expanded to blank, so no need for extra
check;

2) $(OUTPUT) is always initialized to current dir or supplied value,
so it does not make any harm to add it unconditionally.

Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
---
 tools/testing/selftests/lib.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 7a17ea815736..fac4f7de37fb 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -73,14 +73,9 @@ ifdef building_out_of_srctree
 	@if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ]; then \
 		rsync -aq $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(OUTPUT); \
 	fi
-	@if [ "X$(TEST_PROGS)" != "X" ]; then \
-		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(OUTPUT)/$(TEST_PROGS)) ; \
-	else \
-		$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS)); \
-	fi
-else
-	@$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(TEST_PROGS))
 endif
+	@$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) \
+			   $(addprefix $(OUTPUT)/,$(TEST_PROGS)))
 
 define INSTALL_SINGLE_RULE
 	$(if $(INSTALL_LIST),@mkdir -p $(INSTALL_PATH))
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] selftests: lib.mk improvements
  2020-05-15 12:00 [PATCH v2 0/3] selftests: lib.mk improvements Yauheni Kaliuta
                   ` (2 preceding siblings ...)
  2020-05-15 12:00 ` [PATCH v2 3/3] selftests: simplify run_tests Yauheni Kaliuta
@ 2020-05-19 13:59 ` shuah
  2020-05-19 14:49   ` Yauheni Kaliuta
  3 siblings, 1 reply; 12+ messages in thread
From: shuah @ 2020-05-19 13:59 UTC (permalink / raw)
  To: Yauheni Kaliuta, bpf; +Cc: Jiri Benc, Jiri Olsa, shuah

On 5/15/20 6:00 AM, Yauheni Kaliuta wrote:
> 
> Yauheni Kaliuta (3):
>    selftests: do not use .ONESHELL
>    selftests: fix condition in run_tests
>    selftests: simplify run_tests
> 
>   tools/testing/selftests/lib.mk | 19 ++++++-------------
>   1 file changed, 6 insertions(+), 13 deletions(-)
> 

Quick note that, I will pull these in for 5.8-rc1.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] selftests: lib.mk improvements
  2020-05-19 13:59 ` [PATCH v2 0/3] selftests: lib.mk improvements shuah
@ 2020-05-19 14:49   ` Yauheni Kaliuta
  2020-05-22 15:09     ` shuah
  0 siblings, 1 reply; 12+ messages in thread
From: Yauheni Kaliuta @ 2020-05-19 14:49 UTC (permalink / raw)
  To: shuah; +Cc: bpf, Jiri Benc, Jiri Olsa

Hi, shuah!

>>>>> On Tue, 19 May 2020 07:59:16 -0600, shuah   wrote:

 > On 5/15/20 6:00 AM, Yauheni Kaliuta wrote:
 >> 
 >> Yauheni Kaliuta (3):
 >> selftests: do not use .ONESHELL
 >> selftests: fix condition in run_tests
 >> selftests: simplify run_tests
 >> 
 >> tools/testing/selftests/lib.mk | 19 ++++++-------------
 >> 1 file changed, 6 insertions(+), 13 deletions(-)
 >> 

 > Quick note that, I will pull these in for 5.8-rc1.

Thanks!

-- 
WBR,
Yauheni Kaliuta


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] selftests: lib.mk improvements
  2020-05-19 14:49   ` Yauheni Kaliuta
@ 2020-05-22 15:09     ` shuah
  2020-05-22 15:38       ` Yauheni Kaliuta
  0 siblings, 1 reply; 12+ messages in thread
From: shuah @ 2020-05-22 15:09 UTC (permalink / raw)
  To: Yauheni Kaliuta; +Cc: bpf, Jiri Benc, Jiri Olsa, shuah, linux-kselftest

On 5/19/20 8:49 AM, Yauheni Kaliuta wrote:
> Hi, shuah!
> 
>>>>>> On Tue, 19 May 2020 07:59:16 -0600, shuah   wrote:
> 
>   > On 5/15/20 6:00 AM, Yauheni Kaliuta wrote:
>   >>
>   >> Yauheni Kaliuta (3):
>   >> selftests: do not use .ONESHELL
>   >> selftests: fix condition in run_tests
>   >> selftests: simplify run_tests
>   >>
>   >> tools/testing/selftests/lib.mk | 19 ++++++-------------
>   >> 1 file changed, 6 insertions(+), 13 deletions(-)
>   >>
> 
>   > Quick note that, I will pull these in for 5.8-rc1.

Patches look okay to me, however, just noticed, this series hasn't
been cc'ed to linux-kselftest. Hence it didn't go through the
necessary reviews.

Please run get_maintainers and resend the series to everybody the
script suggests.

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] selftests: lib.mk improvements
  2020-05-22 15:09     ` shuah
@ 2020-05-22 15:38       ` Yauheni Kaliuta
  2020-05-26 17:18         ` shuah
  0 siblings, 1 reply; 12+ messages in thread
From: Yauheni Kaliuta @ 2020-05-22 15:38 UTC (permalink / raw)
  To: shuah; +Cc: bpf, Jiri Benc, Jiri Olsa, linux-kselftest

Hi, Shuah!

On Fri, May 22, 2020 at 6:09 PM shuah <shuah@kernel.org> wrote:
>
> On 5/19/20 8:49 AM, Yauheni Kaliuta wrote:
> > Hi, shuah!
> >
> >>>>>> On Tue, 19 May 2020 07:59:16 -0600, shuah   wrote:
> >
> >   > On 5/15/20 6:00 AM, Yauheni Kaliuta wrote:
> >   >>
> >   >> Yauheni Kaliuta (3):
> >   >> selftests: do not use .ONESHELL
> >   >> selftests: fix condition in run_tests
> >   >> selftests: simplify run_tests
> >   >>
> >   >> tools/testing/selftests/lib.mk | 19 ++++++-------------
> >   >> 1 file changed, 6 insertions(+), 13 deletions(-)
> >   >>
> >
> >   > Quick note that, I will pull these in for 5.8-rc1.
>
> Patches look okay to me, however, just noticed, this series hasn't
> been cc'ed to linux-kselftest. Hence it didn't go through the
> necessary reviews.
>
> Please run get_maintainers and resend the series to everybody the
> script suggests.
>

Sorry for that. Should I resend to the ML?


-- 
WBR, Yauheni


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] selftests: lib.mk improvements
  2020-05-22 15:38       ` Yauheni Kaliuta
@ 2020-05-26 17:18         ` shuah
  0 siblings, 0 replies; 12+ messages in thread
From: shuah @ 2020-05-26 17:18 UTC (permalink / raw)
  To: Yauheni Kaliuta; +Cc: bpf, Jiri Benc, Jiri Olsa, linux-kselftest, shuah

On 5/22/20 9:38 AM, Yauheni Kaliuta wrote:
> Hi, Shuah!
> 
> On Fri, May 22, 2020 at 6:09 PM shuah <shuah@kernel.org> wrote:
>>
>> On 5/19/20 8:49 AM, Yauheni Kaliuta wrote:
>>> Hi, shuah!
>>>
>>>>>>>> On Tue, 19 May 2020 07:59:16 -0600, shuah   wrote:
>>>
>>>    > On 5/15/20 6:00 AM, Yauheni Kaliuta wrote:
>>>    >>
>>>    >> Yauheni Kaliuta (3):
>>>    >> selftests: do not use .ONESHELL
>>>    >> selftests: fix condition in run_tests
>>>    >> selftests: simplify run_tests
>>>    >>
>>>    >> tools/testing/selftests/lib.mk | 19 ++++++-------------
>>>    >> 1 file changed, 6 insertions(+), 13 deletions(-)
>>>    >>
>>>
>>>    > Quick note that, I will pull these in for 5.8-rc1.
>>
>> Patches look okay to me, however, just noticed, this series hasn't
>> been cc'ed to linux-kselftest. Hence it didn't go through the
>> necessary reviews.
>>
>> Please run get_maintainers and resend the series to everybody the
>> script suggests.
>>
> 
> Sorry for that. Should I resend to the ML?
> 


Yes please.

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2020-05-26 17:18 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-15 12:00 [PATCH v2 0/3] selftests: lib.mk improvements Yauheni Kaliuta
2020-05-15 12:00 ` [PATCH v2 1/3] selftests: do not use .ONESHELL Yauheni Kaliuta
2020-05-15 12:40   ` Jiri Benc
2020-05-19  7:44   ` Yauheni Kaliuta
2020-05-15 12:00 ` [PATCH v2 2/3] selftests: fix condition in run_tests Yauheni Kaliuta
2020-05-15 12:40   ` Jiri Benc
2020-05-15 12:00 ` [PATCH v2 3/3] selftests: simplify run_tests Yauheni Kaliuta
2020-05-19 13:59 ` [PATCH v2 0/3] selftests: lib.mk improvements shuah
2020-05-19 14:49   ` Yauheni Kaliuta
2020-05-22 15:09     ` shuah
2020-05-22 15:38       ` Yauheni Kaliuta
2020-05-26 17:18         ` shuah

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox