From: Eduard Zingerman <eddyz87@gmail.com>
To: Kui-Feng Lee <sinquersw@gmail.com>,
thinker.li@gmail.com, bpf@vger.kernel.org, ast@kernel.org,
martin.lau@linux.dev, song@kernel.org, kernel-team@meta.com,
andrii@kernel.org, drosen@google.com
Cc: kuifeng@meta.com
Subject: Re: [PATCH bpf-next v6 10/10] selftests/bpf: test case for register_bpf_struct_ops().
Date: Fri, 27 Oct 2023 17:13:16 +0300 [thread overview]
Message-ID: <66a48029129dbbfdba57dcd01daa9b4a1f91b915.camel@gmail.com> (raw)
In-Reply-To: <5b3609f3-bc40-4fc3-b591-d124432dc4d9@gmail.com>
On Thu, 2023-10-26 at 21:55 -0700, Kui-Feng Lee wrote:
[...]
>
> The test will pass even without this change.
> But, the test harness may complain by showing warnings.
> You may see an additional warning message without this change.
Understood, thank you for explanation.
> > Regarding assertion:
> >
> > > + ASSERT_EQ(skel->bss->test_2_result, 7, "test_2_result");
> >
> > Could you please leave a comment explaining why the value is 7?
> > I don't understand what invokes 'test_2' but changing it to 8
> > forces test to fail, so something does call 'test_2' :)
>
> It is called by bpf_dummy_reg() in bpf_testmod.c.
> I will add a comment here.
Oh, sorry, I did not notice, thank you.
[...]
next prev parent reply other threads:[~2023-10-27 14:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 5:03 [PATCH bpf-next v6 00/10] Registrating struct_ops types from modules thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 01/10] bpf: refactory struct_ops type initialization to a function thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 02/10] bpf, net: introduce bpf_struct_ops_desc thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 03/10] bpf: add struct_ops_tab to btf thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 04/10] bpf: hold module for bpf_struct_ops_map thinker.li
2023-10-26 21:11 ` Eduard Zingerman
2023-10-27 4:35 ` Kui-Feng Lee
2023-10-22 5:03 ` [PATCH bpf-next v6 05/10] bpf: validate value_type thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 06/10] bpf: pass attached BTF to the bpf_struct_ops subsystem thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 07/10] bpf, net: switch to dynamic registration thinker.li
2023-10-22 6:46 ` kernel test robot
2023-10-26 21:02 ` Eduard Zingerman
2023-10-27 4:39 ` Kui-Feng Lee
2023-10-27 21:32 ` Kui-Feng Lee
2023-10-27 22:02 ` Eduard Zingerman
2023-10-22 5:03 ` [PATCH bpf-next v6 08/10] libbpf: Find correct module BTFs for struct_ops maps and progs thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 09/10] bpf: export btf_ctx_access to modules thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 10/10] selftests/bpf: test case for register_bpf_struct_ops() thinker.li
2023-10-22 7:08 ` kernel test robot
2023-10-26 20:31 ` Eduard Zingerman
2023-10-27 4:55 ` Kui-Feng Lee
2023-10-27 7:09 ` Kui-Feng Lee
2023-10-27 14:13 ` Eduard Zingerman [this message]
2023-10-29 2:34 ` Kui-Feng Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66a48029129dbbfdba57dcd01daa9b4a1f91b915.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=drosen@google.com \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=sinquersw@gmail.com \
--cc=song@kernel.org \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox