From: Kui-Feng Lee <sinquersw@gmail.com>
To: Eduard Zingerman <eddyz87@gmail.com>,
thinker.li@gmail.com, bpf@vger.kernel.org, ast@kernel.org,
martin.lau@linux.dev, song@kernel.org, kernel-team@meta.com,
andrii@kernel.org, drosen@google.com
Cc: kuifeng@meta.com
Subject: Re: [PATCH bpf-next v6 10/10] selftests/bpf: test case for register_bpf_struct_ops().
Date: Sat, 28 Oct 2023 19:34:21 -0700 [thread overview]
Message-ID: <8fc15ddb-c096-4188-8f70-4d93293dd4cf@gmail.com> (raw)
In-Reply-To: <abd76cd234ab2a1185bb9557fa54013264df6a50.camel@gmail.com>
On 10/26/23 13:31, Eduard Zingerman wrote:
> On Sat, 2023-10-21 at 22:03 -0700, thinker.li@gmail.com wrote:
>> From: Kui-Feng Lee <thinker.li@gmail.com>
>>
>> Create a new struct_ops type called bpf_testmod_ops within the bpf_testmod
>> module. When a struct_ops object is registered, the bpf_testmod module will
>> invoke test_2 from the module.
>>
>> Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
>
> Hello,
>
> Sorry for the late response, was moving through the patch-set very slowly.
> Please note that CI currently fails for this series [0], reported error is:
>
> testing_helpers.c:13:10: fatal error: 'rcu_tasks_trace_gp.skel.h' file not found
> 13 | #include "rcu_tasks_trace_gp.skel.h"
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> I get the same error when try to run tests locally (after full clean).
> On the other hand it looks like `kern_sync_rcu_tasks_trace` changes
> are not really necessary, when I undo these changes but keep changes in:
>
> - .../selftests/bpf/bpf_testmod/bpf_testmod.c
> - .../selftests/bpf/bpf_testmod/bpf_testmod.h
> - .../bpf/prog_tests/test_struct_ops_module.c
> - .../selftests/bpf/progs/struct_ops_module.c
>
> struct_ops_module/regular_load test still passes.
>
> Regarding assertion:
>
>> + ASSERT_EQ(skel->bss->test_2_result, 7, "test_2_result");
>
> Could you please leave a comment explaining why the value is 7?
> I don't understand what invokes 'test_2' but changing it to 8
> forces test to fail, so something does call 'test_2' :)
>
> Also, when running test_maps I get the following error:
>
> libbpf: bpf_map_create_opts has non-zero extra bytes
> map_create_opts(317):FAIL:bpf_map_create() error:Invalid argument (name=hash_of_maps)
According to what Andrii Nakryiko said,
once [1] is landed, this error should be fixed.
[1] https://lore.kernel.org/all/20231029011509.2479232-1-andrii@kernel.org/
>
> [0] https://patchwork.kernel.org/project/netdevbpf/patch/20231022050335.2579051-11-thinker.li@gmail.com/
> (look for 'Logs for x86_64-gcc / build / build for x86_64 with gcc ')
>
[...]
prev parent reply other threads:[~2023-10-29 2:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 5:03 [PATCH bpf-next v6 00/10] Registrating struct_ops types from modules thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 01/10] bpf: refactory struct_ops type initialization to a function thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 02/10] bpf, net: introduce bpf_struct_ops_desc thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 03/10] bpf: add struct_ops_tab to btf thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 04/10] bpf: hold module for bpf_struct_ops_map thinker.li
2023-10-26 21:11 ` Eduard Zingerman
2023-10-27 4:35 ` Kui-Feng Lee
2023-10-22 5:03 ` [PATCH bpf-next v6 05/10] bpf: validate value_type thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 06/10] bpf: pass attached BTF to the bpf_struct_ops subsystem thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 07/10] bpf, net: switch to dynamic registration thinker.li
2023-10-22 6:46 ` kernel test robot
2023-10-26 21:02 ` Eduard Zingerman
2023-10-27 4:39 ` Kui-Feng Lee
2023-10-27 21:32 ` Kui-Feng Lee
2023-10-27 22:02 ` Eduard Zingerman
2023-10-22 5:03 ` [PATCH bpf-next v6 08/10] libbpf: Find correct module BTFs for struct_ops maps and progs thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 09/10] bpf: export btf_ctx_access to modules thinker.li
2023-10-22 5:03 ` [PATCH bpf-next v6 10/10] selftests/bpf: test case for register_bpf_struct_ops() thinker.li
2023-10-22 7:08 ` kernel test robot
2023-10-26 20:31 ` Eduard Zingerman
2023-10-27 4:55 ` Kui-Feng Lee
2023-10-27 7:09 ` Kui-Feng Lee
2023-10-27 14:13 ` Eduard Zingerman
2023-10-29 2:34 ` Kui-Feng Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fc15ddb-c096-4188-8f70-4d93293dd4cf@gmail.com \
--to=sinquersw@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=drosen@google.com \
--cc=eddyz87@gmail.com \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox