From: Quentin Monnet <quentin@isovalent.com>
To: Yonghong Song <yonghong.song@linux.dev>,
Kui-Feng Lee <thinker.li@gmail.com>,
bpf@vger.kernel.org, ast@kernel.org, martin.lau@linux.dev,
song@kernel.org, kernel-team@meta.com, andrii@kernel.org
Cc: sinquersw@gmail.com, kuifeng@meta.com, yhs@meta.com
Subject: Re: [PATCH bpf-next] bpftool: cast pointers for shadow types explicitly.
Date: Tue, 12 Mar 2024 09:53:50 +0000 [thread overview]
Message-ID: <6e44c9da-ea3b-45bb-a62e-3094889408fe@isovalent.com> (raw)
In-Reply-To: <2c0512f4-6bbc-459c-b6e6-7319d59595a7@linux.dev>
2024-03-12 05:22 UTC+0000 ~ Yonghong Song <yonghong.song@linux.dev>
>
> On 3/11/24 6:37 PM, Kui-Feng Lee wrote:
>> According to a report, skeletons fail to assign shadow pointers when
>> being
>> compiled with C++ programs. Unlike C doing implicit casting for void
>> pointers, C++ requires an explicit casting.
>>
>> To support C++, we do explicit casting for each shadow pointer.
>>
>> Cc: yhs@meta.com
>> Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
>
> LGTM.
>
> Acked-by: Yonghong Song <yonghong.song@linux.dev>
>
Acked-by: Quentin Monnet <quentin@isovalent.com>
Thanks!
next prev parent reply other threads:[~2024-03-12 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 1:37 [PATCH bpf-next] bpftool: cast pointers for shadow types explicitly Kui-Feng Lee
2024-03-12 5:22 ` Yonghong Song
2024-03-12 9:53 ` Quentin Monnet [this message]
2024-03-12 22:47 ` Andrii Nakryiko
2024-03-13 0:07 ` Kui-Feng Lee
2024-03-13 0:27 ` Andrii Nakryiko
2024-03-13 0:37 ` Kui-Feng Lee
2024-03-13 15:51 ` Andrii Nakryiko
2024-03-14 20:36 ` Andrii Nakryiko
2024-03-14 20:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e44c9da-ea3b-45bb-a62e-3094889408fe@isovalent.com \
--to=quentin@isovalent.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=sinquersw@gmail.com \
--cc=song@kernel.org \
--cc=thinker.li@gmail.com \
--cc=yhs@meta.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox