Re: [PATCH bpf-next v3 5/5] selftests/bpf: Add private stack tests

[Yonghong Song <yonghong.song@linux.dev>]

On 9/30/24 8:05 AM, Alexei Starovoitov wrote:
> On Mon, Sep 30, 2024 at 6:40 AM Jiri Olsa <olsajiri@gmail.com> wrote:
>> On Thu, Sep 26, 2024 at 04:45:31PM -0700, Yonghong Song wrote:
>>> Some private stack tests are added including:
>>>    - prog with stack size greater than BPF_PSTACK_MIN_SUBTREE_SIZE.
>>>    - prog with stack size less than BPF_PSTACK_MIN_SUBTREE_SIZE.
>>>    - prog with one subprog having MAX_BPF_STACK stack size and another
>>>      subprog having non-zero stack size.
>>>    - prog with callback function.
>>>    - prog with exception in main prog or subprog.
>>>
>>> Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
>> hi,
>> might be some fail on my side, but I had to include bpf_experimental.h to
>> compile this.. ci seems ok
>>
>>    CLNG-BPF [test_progs-cpuv4] verifier_private_stack.bpf.o
>> progs/verifier_private_stack.c:174:2: error: call to undeclared function 'bpf_throw'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>>    174 |         bpf_throw(0);
> Yeah. Let's add bpf_experimental.h for folks like Jiri
> who didn't upgrade their pahole for a long time :)
>
> bpf_throw will be in vmlinux.h ;)

Okay, will do.