From: Eduard Zingerman <eddyz87@gmail.com>
To: bpf@vger.kernel.org, ast@kernel.org
Cc: andrii@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
kernel-team@fb.com, yonghong.song@linux.dev, void@manifault.com,
sinquersw@gmail.com
Subject: Re: [PATCH bpf-next v2 08/15] libbpf: sync progs autoload with maps autocreate for struct_ops maps
Date: Mon, 04 Mar 2024 21:13:56 +0200 [thread overview]
Message-ID: <f94bcbe0578569cd645cb018e210cfa8299d2e1e.camel@gmail.com> (raw)
In-Reply-To: <20240302011920.15302-9-eddyz87@gmail.com>
On Sat, 2024-03-02 at 03:19 +0200, Eduard Zingerman wrote:
> Automatically select which struct_ops programs to load depending on
> which struct_ops maps are selected for automatic creation.
> E.g. for the BPF code below:
>
> SEC("struct_ops/test_1") int BPF_PROG(foo) { ... }
> SEC("struct_ops/test_2") int BPF_PROG(bar) { ... }
>
> SEC(".struct_ops.link")
> struct test_ops___v1 A = {
> .foo = (void *)foo
> };
>
> SEC(".struct_ops.link")
> struct test_ops___v2 B = {
> .foo = (void *)foo,
> .bar = (void *)bar,
> };
>
> And the following libbpf API calls:
>
> bpf_map__set_autocreate(skel->maps.A, true);
> bpf_map__set_autocreate(skel->maps.B, false);
>
> The autoload would be enabled for program 'foo' and disabled for
> program 'bar'.
>
> To achieve this:
> - for struct_ops programs referenced from struct_ops maps set autoload
> property at open() to false;
> - when creating struct_ops maps set autoload property of referenced
> programs to true.
>
> (Note: struct_ops programs not referenced from any map would have
> their autoload property set to true by default.
> If attach_btf_id and expected_attach_type properties would not be
> specified for such programs manually, the load phase would fail).
>
> Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
> ---
I talked to Andrii today and he asked to move all logic related to
these things to "load" phase. Will post v3 shortly.
[...]
next prev parent reply other threads:[~2024-03-04 19:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 1:19 [PATCH bpf-next v2 00/15] libbpf: type suffixes and autocreate flag for struct_ops maps Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 01/15] libbpf: allow version suffixes (___smth) for struct_ops types Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 02/15] libbpf: tie struct_ops programs to kernel BTF ids, not to local ids Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 03/15] libbpf: honor autocreate flag for struct_ops maps Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 04/15] selftests/bpf: test struct_ops map definition with type suffix Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 05/15] selftests/bpf: utility functions to capture libbpf log in test_progs Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 06/15] selftests/bpf: bad_struct_ops test Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 07/15] selftests/bpf: test autocreate behavior for struct_ops maps Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 08/15] libbpf: sync progs autoload with maps autocreate " Eduard Zingerman
2024-03-04 19:13 ` Eduard Zingerman [this message]
2024-03-02 1:19 ` [PATCH bpf-next v2 09/15] selftests/bpf: verify struct_ops autoload/autocreate sync Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 10/15] libbpf: replace elf_state->st_ops_* fields with SEC_ST_OPS sec_type Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 11/15] libbpf: struct_ops in SEC("?.struct_ops") and SEC("?.struct_ops.link") Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 12/15] libbpf: rewrite btf datasec names starting from '?' Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 13/15] selftests/bpf: test case for SEC("?.struct_ops") Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 14/15] bpf: allow '?' at the beginning of DATASEC names Eduard Zingerman
2024-03-02 1:19 ` [PATCH bpf-next v2 15/15] selftests/bpf: test cases for '?' in BTF names Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f94bcbe0578569cd645cb018e210cfa8299d2e1e.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=sinquersw@gmail.com \
--cc=void@manifault.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox