Re: [PATCH bpf-next v2 1/8] libbpf: Look up BTF strings without making BTF modifiable

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] libbpf: non-standard multi-line comment style in struct btf
--

commit 0c3dbaeec612c1bd0bf2896a8ba4e0a1a8431c92
Author: Ihor Solodrai <ihor.solodrai@linux.dev>

libbpf: Look up BTF strings without making BTF modifiable

This patch updates btf__find_str() to build the string lookup index via a
new btf_ensure_strs_set() helper without making the BTF instance
modifiable, and updates btf__free() to unconditionally free strs_set.

> diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
> index d2ff6f5d6d5b6..d8907281c0efd 100644
> --- a/tools/lib/bpf/btf.c
> +++ b/tools/lib/bpf/btf.c
> @@ -153,9 +153,9 @@ struct btf {
>  	 */
>  	int start_str_off;
>  
> -	/* only one of strs_data or strs_set can be non-NULL, depending on
> -	 * whether BTF is in a modifiable state (strs_set is used) or not
> -	 * (strs_data points inside raw_data)
> +	/* strs_data points inside raw_data until BTF becomes modifiable,
> +	 * then strings live in strs_set. Before that, strs_set may exist
> +	 * as a lookup index for btf__find_str().
>  	 */

[Severity: Low]
In struct btf in tools/lib/bpf/btf.c, should the opening /* of this
multi-line comment be placed on its own line to follow the BPF comment
style?

	/*
	 * strs_data points inside raw_data until BTF becomes modifiable,
	 * then strings live in strs_set. Before that, strs_set may exist
	 * as a lookup index for btf__find_str().
	 */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023222652.3927736-1-ihor.solodrai@linux.dev?part=1