From: Ben Pfaff <blp@ovn.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: "open list:OPENVSWITCH" <dev@openvswitch.org>,
netdev@vger.kernel.org,
"moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>
Subject: Re: [Bridge] [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit
Date: Sat, 3 Dec 2016 15:27:30 -0800 [thread overview]
Message-ID: <20161203232730.GT3129@ovn.org> (raw)
In-Reply-To: <cfa1f2efae2217b50cbefccbf9ba7f0d24a23c63.1480755768.git.mirq-linux@rere.qmqm.pl>
On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote:
> This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed
> intact through linux networking stack.
>
> Signed-off-by: Michał Mirosław <michal.miroslaw@atendesoftware.pl>
> ---
>
> Dear NetDevs
>
> I guess this needs to be split to the prep..convert[]..finish sequence,
> but if you like it as is, then it's ready.
>
> The biggest question is if the modified interface and vlan_present
> is the way to go. This can be changed to use vlan_proto != 0 instead
> of an extra flag bit.
>
> As I can't test most of the driver changes, please look at them carefully.
> OVS and bridge eyes are especially welcome.
This appears to change the established Open vSwitch userspace API. You
can see that simply from the way that it changes the documentation for
the userspace API. If I'm right about that, then this change will break
all userspace programs that use the Open vSwitch kernel module,
including Open vSwitch itself.
next prev parent reply other threads:[~2016-12-03 23:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 9:22 [Bridge] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit Michał Mirosław
2016-12-03 23:27 ` Ben Pfaff [this message]
2016-12-05 17:24 ` [Bridge] [ovs-dev] " Michał Mirosław
2016-12-05 18:55 ` Ben Pfaff
2016-12-05 22:52 ` Michał Mirosław
2016-12-06 0:59 ` Ben Pfaff
2016-12-14 1:21 ` [Bridge] " Stephen Hemminger
2016-12-14 2:03 ` Michał Mirosław
2016-12-14 2:21 ` Alexei Starovoitov
2016-12-14 14:28 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161203232730.GT3129@ovn.org \
--to=blp@ovn.org \
--cc=bridge@lists.linux-foundation.org \
--cc=dev@openvswitch.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox