[Buildroot] [PATCH 1/2] protobuf: needs thread support

[Buildroot] [PATCH 1/2] protobuf: needs thread support

[Axel Lin]

Fix:
http://autobuild.buildroot.net/results/086/08661b6bd6796c9126bcbad3245323160b182ac8/

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 package/protobuf/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
index b044ef0..92e85ba 100644
--- a/package/protobuf/Config.in
+++ b/package/protobuf/Config.in
@@ -1,11 +1,12 @@
 config BR2_PACKAGE_PROTOBUF
 	bool "protobuf"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Protocol buffers are Google's language-neutral, platform-neutral,
 	  extensible mechanism for serializing structured data.
 
 	  http://code.google.com/p/protobuf/
 
-comment "protobuf requires a toolchain with C++ support enabled"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "protobuf requires a toolchain with C++ and thread support"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
-- 
1.8.1.2

[Buildroot] [PATCH 2/2] protobuf-c: needs thread support

[Axel Lin]

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 package/protobuf-c/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/protobuf-c/Config.in b/package/protobuf-c/Config.in
index 9aff6e2..17cc8f1 100644
--- a/package/protobuf-c/Config.in
+++ b/package/protobuf-c/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PROTOBUF_C
 	bool "protobuf-c"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
 	select BR2_PACKAGE_PROTOBUF
 	help
 	  Code generator and runtime libraries to use Protocol Buffers
@@ -8,5 +9,5 @@ config BR2_PACKAGE_PROTOBUF_C
 
 	  http://code.google.com/p/protobuf-c/
 
-comment "protobuf-c requires a toolchain with C++ support enabled"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "protobuf-c requires a toolchain with C++ and thread support"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
-- 
1.8.1.2

[Buildroot] [PATCH 2/2] protobuf-c: needs thread support

[Baruch Siach]

Hi Axel,

On Thu, Oct 10, 2013 at 03:25:16PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  package/protobuf-c/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/protobuf-c/Config.in b/package/protobuf-c/Config.in
> index 9aff6e2..17cc8f1 100644
> --- a/package/protobuf-c/Config.in
> +++ b/package/protobuf-c/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_PROTOBUF_C
>  	bool "protobuf-c"
>  	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf

This should be squashed into the previous patch. Although strictly speaking 
bisectability is not broken by the previous patch (build without threads is 
broken already), it is nicer IMO.

baruch

>  	select BR2_PACKAGE_PROTOBUF
>  	help
>  	  Code generator and runtime libraries to use Protocol Buffers
> @@ -8,5 +9,5 @@ config BR2_PACKAGE_PROTOBUF_C
>  
>  	  http://code.google.com/p/protobuf-c/
>  
> -comment "protobuf-c requires a toolchain with C++ support enabled"
> -	depends on !BR2_INSTALL_LIBSTDCPP
> +comment "protobuf-c requires a toolchain with C++ and thread support"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 2/2] protobuf-c: needs thread support

[Peter Korsgaard]

>>>>> "Axel" == Axel Lin <axel.lin@ingics.com> writes:

 Axel> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Committed both squashed together as suggested by Baruch, thanks.

-- 
Bye, Peter Korsgaard