Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] sqlcipher: fix passing CFLAGS/LDFLAGS to configure
Date: Mon, 12 May 2014 07:27:03 +0400	[thread overview]
Message-ID: <1399865226-7054-2-git-send-email-jcmvbkbc@gmail.com> (raw)
In-Reply-To: <1399865226-7054-1-git-send-email-jcmvbkbc@gmail.com>

SQLCIPHER_CONF_ENV is a string used to pass environment variables to the
confgiure script, '+=' operator doesn't have any special meaning inside
it, so CFLAGS+=... is passed to shell, overwriting previous CFLAGS
value. Replace CFLAGS+="..." with CFLAGS="$(TARGET_CFLAGS) ...".

Fixes:
  http://autobuild.buildroot.net/results/dbf/dbf947ad6442fa8e57201ffcc96871361bf39ad7/

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 package/sqlcipher/sqlcipher.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/sqlcipher/sqlcipher.mk b/package/sqlcipher/sqlcipher.mk
index 6130870..bae59bb 100644
--- a/package/sqlcipher/sqlcipher.mk
+++ b/package/sqlcipher/sqlcipher.mk
@@ -10,8 +10,8 @@ SQLCIPHER_DEPENDENCIES = openssl host-tcl
 SQLCIPHER_INSTALL_STAGING = YES
 
 SQLCIPHER_CONF_ENV = \
-	CFLAGS+=" $(SQLCIPHER_CFLAGS)" \
-	LDFLAGS+=" $(SQLCIPHER_LDFLAGS)" \
+	CFLAGS="$(TARGET_CFLAGS) $(SQLCIPHER_CFLAGS)" \
+	LDFLAGS="$(TARGET_LDFLAGS) $(SQLCIPHER_LDFLAGS)" \
 	TCLSH_CMD=$(HOST_DIR)/usr/bin/tclsh$(TCL_VERSION_MAJOR)
 
 SQLCIPHER_CONF_OPT = \
-- 
1.7.7.6

  reply	other threads:[~2014-05-12  3:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12  3:27 [Buildroot] [PATCH 0/4] fix environment variables passing to configure/make Max Filippov
2014-05-12  3:27 ` Max Filippov [this message]
2014-05-12 17:50   ` [Buildroot] [PATCH 1/4] sqlcipher: fix passing CFLAGS/LDFLAGS to configure Thomas Petazzoni
2014-05-12  3:27 ` [Buildroot] [PATCH 2/4] libcgroup: " Max Filippov
2014-05-12 17:50   ` Thomas Petazzoni
2014-05-12  3:27 ` [Buildroot] [PATCH 3/4] ebtables: fix passing CFLAGS " Max Filippov
2014-05-12 17:50   ` Thomas Petazzoni
2014-05-12  3:27 ` [Buildroot] [PATCH 4/4] sysstat: fix passing CFLAGS to make Max Filippov
2014-05-12 17:51   ` Thomas Petazzoni
2014-05-12 20:52 ` [Buildroot] [PATCH 0/4] fix environment variables passing to configure/make Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399865226-7054-2-git-send-email-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox