Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] sqlcipher: fix passing CFLAGS/LDFLAGS to configure
Date: Mon, 12 May 2014 19:50:22 +0200	[thread overview]
Message-ID: <20140512195022.7443ed89@free-electrons.com> (raw)
In-Reply-To: <1399865226-7054-2-git-send-email-jcmvbkbc@gmail.com>

Dear Max Filippov,

On Mon, 12 May 2014 07:27:03 +0400, Max Filippov wrote:
> SQLCIPHER_CONF_ENV is a string used to pass environment variables to the
> confgiure script, '+=' operator doesn't have any special meaning inside
> it, so CFLAGS+=... is passed to shell, overwriting previous CFLAGS
> value. Replace CFLAGS+="..." with CFLAGS="$(TARGET_CFLAGS) ...".
> 
> Fixes:
>   http://autobuild.buildroot.net/results/dbf/dbf947ad6442fa8e57201ffcc96871361bf39ad7/
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  package/sqlcipher/sqlcipher.mk |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-05-12 17:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12  3:27 [Buildroot] [PATCH 0/4] fix environment variables passing to configure/make Max Filippov
2014-05-12  3:27 ` [Buildroot] [PATCH 1/4] sqlcipher: fix passing CFLAGS/LDFLAGS to configure Max Filippov
2014-05-12 17:50   ` Thomas Petazzoni [this message]
2014-05-12  3:27 ` [Buildroot] [PATCH 2/4] libcgroup: " Max Filippov
2014-05-12 17:50   ` Thomas Petazzoni
2014-05-12  3:27 ` [Buildroot] [PATCH 3/4] ebtables: fix passing CFLAGS " Max Filippov
2014-05-12 17:50   ` Thomas Petazzoni
2014-05-12  3:27 ` [Buildroot] [PATCH 4/4] sysstat: fix passing CFLAGS to make Max Filippov
2014-05-12 17:51   ` Thomas Petazzoni
2014-05-12 20:52 ` [Buildroot] [PATCH 0/4] fix environment variables passing to configure/make Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512195022.7443ed89@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox