Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] ebtables: fix passing CFLAGS to configure
Date: Mon, 12 May 2014 07:27:05 +0400	[thread overview]
Message-ID: <1399865226-7054-4-git-send-email-jcmvbkbc@gmail.com> (raw)
In-Reply-To: <1399865226-7054-1-git-send-email-jcmvbkbc@gmail.com>

EBTABLES_K64U32 is a string passed directly to the configure script,
'+=' operator doesn't have any special meaningi inside it, so
CFLAGS+=-DKERNEL_64_USERSPACE_32 is passed to shell, overwriting previous
CFLAGS value.

Replace CFLAGS+="-DKERNEL_64_USERSPACE_32" with -DKERNEL_64_USERSPACE_32
and pass CFLAGS="$(TARGET_CFLAGS) $(EBTABLES_K64U32)".

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 package/ebtables/ebtables.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/ebtables/ebtables.mk b/package/ebtables/ebtables.mk
index 66a47a2..578c3ae 100644
--- a/package/ebtables/ebtables.mk
+++ b/package/ebtables/ebtables.mk
@@ -10,11 +10,11 @@ EBTABLES_SITE = http://downloads.sourceforge.net/project/ebtables/ebtables/ebtab
 EBTABLES_LICENSE = GPLv2+
 EBTABLES_LICENSE_FILES = COPYING
 EBTABLES_STATIC = $(if $(BR2_PREFER_STATIC_LIB),static)
-EBTABLES_K64U32 = $(if $(BR2_KERNEL_64_USERLAND_32),CFLAGS+="-DKERNEL_64_USERSPACE_32")
+EBTABLES_K64U32 = $(if $(BR2_KERNEL_64_USERLAND_32),-DKERNEL_64_USERSPACE_32)
 
 define EBTABLES_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) LIBDIR=/lib/ebtables $(EBTABLES_STATIC) \
-		$(EBTABLES_K64U32) -C $(@D)
+		CFLAGS="$(TARGET_CFLAGS) $(EBTABLES_K64U32)" -C $(@D)
 endef
 
 ifeq ($(BR2_PREFER_STATIC_LIB),y)
-- 
1.7.7.6

  parent reply	other threads:[~2014-05-12  3:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12  3:27 [Buildroot] [PATCH 0/4] fix environment variables passing to configure/make Max Filippov
2014-05-12  3:27 ` [Buildroot] [PATCH 1/4] sqlcipher: fix passing CFLAGS/LDFLAGS to configure Max Filippov
2014-05-12 17:50   ` Thomas Petazzoni
2014-05-12  3:27 ` [Buildroot] [PATCH 2/4] libcgroup: " Max Filippov
2014-05-12 17:50   ` Thomas Petazzoni
2014-05-12  3:27 ` Max Filippov [this message]
2014-05-12 17:50   ` [Buildroot] [PATCH 3/4] ebtables: fix passing CFLAGS " Thomas Petazzoni
2014-05-12  3:27 ` [Buildroot] [PATCH 4/4] sysstat: fix passing CFLAGS to make Max Filippov
2014-05-12 17:51   ` Thomas Petazzoni
2014-05-12 20:52 ` [Buildroot] [PATCH 0/4] fix environment variables passing to configure/make Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399865226-7054-4-git-send-email-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox