From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH buildroot-test 1/8] autobuild-run: check-requirements does not need to know the login details
Date: Thu, 16 Oct 2014 21:15:57 +0200 [thread overview]
Message-ID: <1413486964-5183-1-git-send-email-patrickdepinguin@gmail.com> (raw)
From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
check-requirements simply has to know if the results have to be sent, so
it can check on some extra requirements. The username and password are
irrelevant here.
This commit introduces a boolean variable do_send_results to hide these
details.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
scripts/autobuild-run | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 7497001..2ead1f2 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -85,12 +85,12 @@ def check_version():
print "ERROR: script version too old, please upgrade."
sys.exit(1)
-def check_requirements(http_login, http_password):
+def check_requirements(do_send_results=False):
devnull = open(os.devnull, "w")
needed_progs = ["make", "git", "gcc", "timeout"]
missing_requirements = False
- if http_login and http_password:
+ if do_send_results:
needed_progs.append("curl")
for prog in needed_progs:
@@ -553,8 +553,9 @@ if __name__ == '__main__':
check_version()
sysinfo = SystemInfo()
(ninstances, njobs, http_login, http_password, submitter) = config_get()
- check_requirements(http_login, http_password)
- if http_login is None or http_password is None:
+ do_send_results = http_login and http_password
+ check_requirements(do_send_results)
+ if not do_send_results:
print "WARN: due to the lack of http login/password details, results will not be submitted"
print "WARN: tarballs of results will be kept locally only"
def sigterm_handler(signum, frame):
--
1.8.5.1
next reply other threads:[~2014-10-16 19:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 19:15 Thomas De Schampheleire [this message]
2014-10-16 19:15 ` [Buildroot] [PATCH buildroot-test 2/8] scripts: add python module docopt Thomas De Schampheleire
2014-10-16 19:15 ` [Buildroot] [PATCH buildroot-test 3/8] autobuild-run: use docopt for argument parsing Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 4/8] autobuild-run: convert regular function comments into docstrings Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 5/8] autobuild-run: add option --make-opts for custom Buildroot options Thomas De Schampheleire
2014-10-17 10:46 ` Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 6/8] autobuild-run: create main method to locally-scope all variables Thomas De Schampheleire
2014-10-17 22:24 ` Yann E. MORIN
2014-10-18 11:02 ` Maxime Hadjinlian
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 7/8] autobuild-run: use **kwargs to avoid explicit parameter passthroughs Thomas De Schampheleire
2014-10-17 11:27 ` Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 8/8] autobuild-run: add support for custom git wrapper Thomas De Schampheleire
2014-10-17 22:30 ` Yann E. MORIN
2014-10-18 13:00 ` Thomas Petazzoni
2014-10-18 19:08 ` Thomas De Schampheleire
2014-10-17 22:20 ` [Buildroot] [PATCH buildroot-test 1/8] autobuild-run: check-requirements does not need to know the login details Yann E. MORIN
2014-10-18 10:15 ` Maxime Hadjinlian
2014-10-18 10:25 ` Yann E. MORIN
2014-10-18 10:38 ` Maxime Hadjinlian
2014-10-18 13:38 ` Arnout Vandecappelle
2014-10-18 13:52 ` Maxime Hadjinlian
2014-10-18 17:34 ` Yann E. MORIN
2014-10-18 19:06 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413486964-5183-1-git-send-email-patrickdepinguin@gmail.com \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox