From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH buildroot-test 6/8] autobuild-run: create main method to locally-scope all variables
Date: Thu, 16 Oct 2014 21:16:02 +0200 [thread overview]
Message-ID: <1413486964-5183-6-git-send-email-patrickdepinguin@gmail.com> (raw)
In-Reply-To: <1413486964-5183-1-git-send-email-patrickdepinguin@gmail.com>
From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
In the current autobuild-run script, all variables created in the 'main'
part are in fact global, even though the script does not intend them to
be. For example, sysinfo is global, even though it is passed as function
argument to run_instance.
To avoid this accidental globalization, create a main method instead.
All variables created therein are now local to that method.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
scripts/autobuild-run | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 57654de..95f2390 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -575,7 +575,7 @@ def merge(dict_1, dict_2):
return dict((str(key), dict_1.get(key) or dict_2.get(key))
for key in set(dict_2) | set(dict_1))
-if __name__ == '__main__':
+def main():
check_version()
sysinfo = SystemInfo()
@@ -604,3 +604,6 @@ if __name__ == '__main__':
signal.signal(signal.SIGTERM, sigterm_handler)
for p in processes:
p.join()
+
+if __name__ == '__main__':
+ main()
--
1.8.5.1
next prev parent reply other threads:[~2014-10-16 19:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 19:15 [Buildroot] [PATCH buildroot-test 1/8] autobuild-run: check-requirements does not need to know the login details Thomas De Schampheleire
2014-10-16 19:15 ` [Buildroot] [PATCH buildroot-test 2/8] scripts: add python module docopt Thomas De Schampheleire
2014-10-16 19:15 ` [Buildroot] [PATCH buildroot-test 3/8] autobuild-run: use docopt for argument parsing Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 4/8] autobuild-run: convert regular function comments into docstrings Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 5/8] autobuild-run: add option --make-opts for custom Buildroot options Thomas De Schampheleire
2014-10-17 10:46 ` Thomas De Schampheleire
2014-10-16 19:16 ` Thomas De Schampheleire [this message]
2014-10-17 22:24 ` [Buildroot] [PATCH buildroot-test 6/8] autobuild-run: create main method to locally-scope all variables Yann E. MORIN
2014-10-18 11:02 ` Maxime Hadjinlian
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 7/8] autobuild-run: use **kwargs to avoid explicit parameter passthroughs Thomas De Schampheleire
2014-10-17 11:27 ` Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 8/8] autobuild-run: add support for custom git wrapper Thomas De Schampheleire
2014-10-17 22:30 ` Yann E. MORIN
2014-10-18 13:00 ` Thomas Petazzoni
2014-10-18 19:08 ` Thomas De Schampheleire
2014-10-17 22:20 ` [Buildroot] [PATCH buildroot-test 1/8] autobuild-run: check-requirements does not need to know the login details Yann E. MORIN
2014-10-18 10:15 ` Maxime Hadjinlian
2014-10-18 10:25 ` Yann E. MORIN
2014-10-18 10:38 ` Maxime Hadjinlian
2014-10-18 13:38 ` Arnout Vandecappelle
2014-10-18 13:52 ` Maxime Hadjinlian
2014-10-18 17:34 ` Yann E. MORIN
2014-10-18 19:06 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413486964-5183-6-git-send-email-patrickdepinguin@gmail.com \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox