From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH buildroot-test 1/8] autobuild-run: check-requirements does not need to know the login details
Date: Sat, 18 Oct 2014 19:34:30 +0200 [thread overview]
Message-ID: <20141018173430.GD31723@free.fr> (raw)
In-Reply-To: <CAGduivxXvJcnD-x9MBfVApkL3V0yFwiM-Ei3oHqnPsGAoFq=mg@mail.gmail.com>
All,
On 2014-10-18 15:52 +0200, Maxime Hadjinlian spake thusly:
> On Sat, Oct 18, 2014 at 3:38 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> > On 18/10/14 00:20, Yann E. MORIN wrote:
> >> Thomas, All,
> >>
> >> On 2014-10-16 21:15 +0200, Thomas De Schampheleire spake thusly:
> > [snip]
> >>> @@ -553,8 +553,9 @@ if __name__ == '__main__':
> >>> check_version()
> >>> sysinfo = SystemInfo()
> >>> (ninstances, njobs, http_login, http_password, submitter) = config_get()
> >>> - check_requirements(http_login, http_password)
> >>> - if http_login is None or http_password is None:
> >>> + do_send_results = http_login and http_password
> >>
> >> I was told that we should no treat 'None' as 'False', or a non-empty
> >> string as 'True'. This should be something like:
> >>
> >> do_send_results = (not http_login is None) and (not http_password is None)
> Just for the sake of it:
> do_send_results = (http_login is not None) and (http_password is not None)
Yup, I forgot that '... is not ...' is preferred over 'not ... is ...'
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-18 17:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 19:15 [Buildroot] [PATCH buildroot-test 1/8] autobuild-run: check-requirements does not need to know the login details Thomas De Schampheleire
2014-10-16 19:15 ` [Buildroot] [PATCH buildroot-test 2/8] scripts: add python module docopt Thomas De Schampheleire
2014-10-16 19:15 ` [Buildroot] [PATCH buildroot-test 3/8] autobuild-run: use docopt for argument parsing Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 4/8] autobuild-run: convert regular function comments into docstrings Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 5/8] autobuild-run: add option --make-opts for custom Buildroot options Thomas De Schampheleire
2014-10-17 10:46 ` Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 6/8] autobuild-run: create main method to locally-scope all variables Thomas De Schampheleire
2014-10-17 22:24 ` Yann E. MORIN
2014-10-18 11:02 ` Maxime Hadjinlian
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 7/8] autobuild-run: use **kwargs to avoid explicit parameter passthroughs Thomas De Schampheleire
2014-10-17 11:27 ` Thomas De Schampheleire
2014-10-16 19:16 ` [Buildroot] [PATCH buildroot-test 8/8] autobuild-run: add support for custom git wrapper Thomas De Schampheleire
2014-10-17 22:30 ` Yann E. MORIN
2014-10-18 13:00 ` Thomas Petazzoni
2014-10-18 19:08 ` Thomas De Schampheleire
2014-10-17 22:20 ` [Buildroot] [PATCH buildroot-test 1/8] autobuild-run: check-requirements does not need to know the login details Yann E. MORIN
2014-10-18 10:15 ` Maxime Hadjinlian
2014-10-18 10:25 ` Yann E. MORIN
2014-10-18 10:38 ` Maxime Hadjinlian
2014-10-18 13:38 ` Arnout Vandecappelle
2014-10-18 13:52 ` Maxime Hadjinlian
2014-10-18 17:34 ` Yann E. MORIN [this message]
2014-10-18 19:06 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141018173430.GD31723@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox