From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 0/9] autobuild-run improvements
Date: Wed, 12 Nov 2014 20:58:28 +0100 [thread overview]
Message-ID: <1415822317-22500-1-git-send-email-patrickdepinguin@gmail.com> (raw)
From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
This series against the buildroot-test repo makes some improvements to the
autobuild-run script.
v4:
- rename do_send_results into upload (Peter)
v3:
- introduce missing usage of do_send_results (and move patch backwards)
- update TODO list
v2:
- reorder patches
- take into account comments on boolean logic in first patch
- place docopt directly in scripts/ instead of in a subdirectory
- remove patch adding --git (Yann, Thomas)
- some bug fixes in the first version of the patches
As you can see, this iteration still has the docopt patches. Thomas Petazzoni
has expressed his reservations against the introduction of docopt, because the
benefits wouldn't weigh out against the addition of an external Python module.
Thomas told me on IRC he would have a deeper look onto this before making a
final decision.
In case the final decision is not to introduce docopt, following improvements
could be done to the current code:
- save the arguments from the command-line into a dictionary instead of plain
variables
- keep the added ini_config() method to also save the options in a dictionary,
and use the added merge() method to merge both arguments and config options
into one final configuration, without needing to handle it manually.
Thomas De Schampheleire (9):
scripts: add python module docopt
autobuild-run: use docopt for argument parsing
autobuild-run: add option --make-opts for custom Buildroot options
autobuild-run: use **kwargs to avoid explicit parameter passthroughs
autobuild-run: check-requirements does not need to know the login
details
autobuild-run: set LC_ALL=C to not use locale settings of host machine
autobuild-run: improve the logic to generate build-end.log
autobuild-run: save config.log files for failed package
autobuild-run: extend TODO list
scripts/autobuild-run | 309 ++++++++++++++++--------
scripts/docopt.LICENSE-MIT | 23 ++
scripts/docopt.py | 581 +++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 811 insertions(+), 102 deletions(-)
create mode 100644 scripts/docopt.LICENSE-MIT
create mode 100644 scripts/docopt.py
--
1.8.5.1
next reply other threads:[~2014-11-12 19:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 19:58 Thomas De Schampheleire [this message]
2014-11-12 19:58 ` [Buildroot] [PATCH v4 1/9] scripts: add python module docopt Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 2/9] autobuild-run: use docopt for argument parsing Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 3/9] autobuild-run: add option --make-opts for custom Buildroot options Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 4/9] autobuild-run: use **kwargs to avoid explicit parameter passthroughs Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 5/9] autobuild-run: check-requirements does not need to know the login details Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 6/9] autobuild-run: set LC_ALL=C to not use locale settings of host machine Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 7/9] autobuild-run: improve the logic to generate build-end.log Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 8/9] autobuild-run: save config.log files for failed package Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 9/9] autobuild-run: extend TODO list Thomas De Schampheleire
2014-11-25 21:09 ` Thomas De Schampheleire
2014-11-25 21:20 ` Thomas Petazzoni
2014-12-04 20:41 ` Thomas De Schampheleire
2014-12-05 8:15 ` Thomas Petazzoni
2014-12-05 12:42 ` Thomas De Schampheleire
2014-11-25 20:36 ` [Buildroot] [PATCH v4 0/9] autobuild-run improvements Thomas De Schampheleire
2014-11-25 20:42 ` Thomas Petazzoni
2014-11-25 21:10 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415822317-22500-1-git-send-email-patrickdepinguin@gmail.com \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox