Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 6/9] autobuild-run: set LC_ALL=C to not use locale settings of host machine
Date: Wed, 12 Nov 2014 20:58:34 +0100	[thread overview]
Message-ID: <1415822317-22500-7-git-send-email-patrickdepinguin@gmail.com> (raw)
In-Reply-To: <1415822317-22500-1-git-send-email-patrickdepinguin@gmail.com>

From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

If the host machine running autobuild-run happens to have set a
non-English locale, the error messages will be displayed in that
language too. For public results like those generated in the Buildroot
autobuilders, this is a problem.

Therefore, set LC_ALL to a fixed locale (C) at the beginning of the script.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
 scripts/autobuild-run | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 3f5b4cf..1ef3f8d 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -48,8 +48,6 @@
 #   of just using the last 500 lines of the build log, search the
 #   start of the build of the failing package.
 #
-# - Add LC_ALL=C where appropriate.
-#
 # - Include the config.log file (when it exists) in the tarball for
 #   failed builds when the failure occurs on an autotools package.
 #
@@ -602,6 +600,11 @@ def merge(dict_1, dict_2):
                 for key in set(dict_2) | set(dict_1))
 
 def main():
+
+    # Avoid locale settings of autobuilder machine leaking in, for example
+    # showing error messages in another language.
+    os.environ['LC_ALL'] = 'C'
+
     check_version()
     sysinfo = SystemInfo()
 
-- 
1.8.5.1

  parent reply	other threads:[~2014-11-12 19:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 19:58 [Buildroot] [PATCH v4 0/9] autobuild-run improvements Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 1/9] scripts: add python module docopt Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 2/9] autobuild-run: use docopt for argument parsing Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 3/9] autobuild-run: add option --make-opts for custom Buildroot options Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 4/9] autobuild-run: use **kwargs to avoid explicit parameter passthroughs Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 5/9] autobuild-run: check-requirements does not need to know the login details Thomas De Schampheleire
2014-11-12 19:58 ` Thomas De Schampheleire [this message]
2014-11-12 19:58 ` [Buildroot] [PATCH v4 7/9] autobuild-run: improve the logic to generate build-end.log Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 8/9] autobuild-run: save config.log files for failed package Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 9/9] autobuild-run: extend TODO list Thomas De Schampheleire
2014-11-25 21:09   ` Thomas De Schampheleire
2014-11-25 21:20     ` Thomas Petazzoni
2014-12-04 20:41       ` Thomas De Schampheleire
2014-12-05  8:15         ` Thomas Petazzoni
2014-12-05 12:42           ` Thomas De Schampheleire
2014-11-25 20:36 ` [Buildroot] [PATCH v4 0/9] autobuild-run improvements Thomas De Schampheleire
2014-11-25 20:42   ` Thomas Petazzoni
2014-11-25 21:10     ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415822317-22500-7-git-send-email-patrickdepinguin@gmail.com \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox