Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 9/9] autobuild-run: extend TODO list
Date: Fri, 5 Dec 2014 09:15:30 +0100	[thread overview]
Message-ID: <20141205091530.0ca014e5@free-electrons.com> (raw)
In-Reply-To: <CAAXf6LU07xn6QoE9Np72W_hwy_W3Rh9uozSA1+QX7=TL-_f04g@mail.gmail.com>

Dear Thomas De Schampheleire,

On Thu, 4 Dec 2014 21:41:24 +0100, Thomas De Schampheleire wrote:

> > Thanks for this investigation. It would indeed be really nice to be
> > able to kill just autobuild-run, and be sure that it stops all
> > underlying builds. We could also catch the signal in autobuild-run, and
> > kill the build jobs, if we are able to record the necessary information
> > about them.
> 
> Brief update: the piece of the puzzle that is causing a new process
> group to be spawned is the 'timeout' command. Everything started under
> the timeout command runs in its own process group, different than the
> one of the python process. Therefore, killing the python process group
> does not kill the timeout+make command.
> 
> The solution is to use subprocess.Popen instead of subprocess.call so
> we can obtain the pid of the timeout call, and change the signal
> handler to explicitly kill this second process group too.
> 
> I still have to make the changes in autobuild-run (currently worked on
> a simple test program), and will submit patches when ready...

Ok, great. Another approach maybe would be to not use timeout, and
instead make the Python script itself monitor the duration of the build
it starts, and kill them if they took too long.

Thanks again for the investigation!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-12-05  8:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 19:58 [Buildroot] [PATCH v4 0/9] autobuild-run improvements Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 1/9] scripts: add python module docopt Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 2/9] autobuild-run: use docopt for argument parsing Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 3/9] autobuild-run: add option --make-opts for custom Buildroot options Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 4/9] autobuild-run: use **kwargs to avoid explicit parameter passthroughs Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 5/9] autobuild-run: check-requirements does not need to know the login details Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 6/9] autobuild-run: set LC_ALL=C to not use locale settings of host machine Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 7/9] autobuild-run: improve the logic to generate build-end.log Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 8/9] autobuild-run: save config.log files for failed package Thomas De Schampheleire
2014-11-12 19:58 ` [Buildroot] [PATCH v4 9/9] autobuild-run: extend TODO list Thomas De Schampheleire
2014-11-25 21:09   ` Thomas De Schampheleire
2014-11-25 21:20     ` Thomas Petazzoni
2014-12-04 20:41       ` Thomas De Schampheleire
2014-12-05  8:15         ` Thomas Petazzoni [this message]
2014-12-05 12:42           ` Thomas De Schampheleire
2014-11-25 20:36 ` [Buildroot] [PATCH v4 0/9] autobuild-run improvements Thomas De Schampheleire
2014-11-25 20:42   ` Thomas Petazzoni
2014-11-25 21:10     ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141205091530.0ca014e5@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox