* [Buildroot] [PATCH 1/1] add python simple template module
@ 2015-09-13 16:41 Steve Calfee
2015-09-13 17:05 ` Yegor Yefremov
2015-09-13 18:04 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Steve Calfee @ 2015-09-13 16:41 UTC (permalink / raw)
To: buildroot
Signed-off-by: Steve Calfee <stevecalfee@gmail.com>
---
package/Config.in | 1 +
package/python-pyratemp/Config.in | 9 +++++++++
package/python-pyratemp/python-pyratemp.hash | 4 ++++
package/python-pyratemp/python-pyratemp.mk | 14 ++++++++++++++
4 files changed, 28 insertions(+)
create mode 100644 package/python-pyratemp/Config.in
create mode 100644 package/python-pyratemp/python-pyratemp.hash
create mode 100644 package/python-pyratemp/python-pyratemp.mk
diff --git a/package/Config.in b/package/Config.in
index 030477a..2784339 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -643,6 +643,7 @@ menu "external python modules"
source "package/python-pyparsing/Config.in"
source "package/python-pypcap/Config.in"
source "package/python-pyqt/Config.in"
+ source "package/python-pyratemp/Config.in"
source "package/python-pyro/Config.in"
source "package/python-pyroute2/Config.in"
source "package/python-pysendfile/Config.in"
diff --git a/package/python-pyratemp/Config.in b/package/python-pyratemp/Config.in
new file mode 100644
index 0000000..1e7309e
--- /dev/null
+++ b/package/python-pyratemp/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_PYTHON_PYRATEMP
+ bool "python-pyratemp"
+ depends on BR2_PACKAGE_PYTHON
+ help
+ python-pyratemp is a Python library for doing html templates.
+ written entirely in Python, that is designed to be very easy to use
+ and very like writing Python.
+
+ https://pypi.python.org/pypi/pyratemp/
diff --git a/package/python-pyratemp/python-pyratemp.hash b/package/python-pyratemp/python-pyratemp.hash
new file mode 100644
index 0000000..0abb9e0
--- /dev/null
+++ b/package/python-pyratemp/python-pyratemp.hash
@@ -0,0 +1,4 @@
+# From http://www.simple-is-better.org/template
+# Locally calculated:
+sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
+
diff --git a/package/python-pyratemp/python-pyratemp.mk b/package/python-pyratemp/python-pyratemp.mk
new file mode 100644
index 0000000..4c78154
--- /dev/null
+++ b/package/python-pyratemp/python-pyratemp.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-pyratemp
+#
+################################################################################
+
+PYTHON_PYRATEMP_VERSION = 0.3.2
+PYTHON_PYRATEMP_SOURCE = pyratemp-$(PYTHON_PYRATEMP_VERSION).tgz
+PYTHON_PYRATEMP_SITE = http://www.simple-is-better.org/template
+PYTHON_PYRATEMP_LICENSE = MIT
+PYTHON_PYRATEMP_LICENSE_FILES = LICENSE
+PYTHON_PYRATEMP_SETUP_TYPE = distutils
+
+$(eval $(python-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] add python simple template module
2015-09-13 16:41 [Buildroot] [PATCH 1/1] add python simple template module Steve Calfee
@ 2015-09-13 17:05 ` Yegor Yefremov
2015-09-13 18:04 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Yegor Yefremov @ 2015-09-13 17:05 UTC (permalink / raw)
To: buildroot
Hi Steve,
On Sun, Sep 13, 2015 at 6:41 PM, Steve Calfee <stevecalfee@gmail.com> wrote:
> Signed-off-by: Steve Calfee <stevecalfee@gmail.com>
> ---
> package/Config.in | 1 +
> package/python-pyratemp/Config.in | 9 +++++++++
> package/python-pyratemp/python-pyratemp.hash | 4 ++++
> package/python-pyratemp/python-pyratemp.mk | 14 ++++++++++++++
> 4 files changed, 28 insertions(+)
> create mode 100644 package/python-pyratemp/Config.in
> create mode 100644 package/python-pyratemp/python-pyratemp.hash
> create mode 100644 package/python-pyratemp/python-pyratemp.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 030477a..2784339 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -643,6 +643,7 @@ menu "external python modules"
> source "package/python-pyparsing/Config.in"
> source "package/python-pypcap/Config.in"
> source "package/python-pyqt/Config.in"
> + source "package/python-pyratemp/Config.in"
> source "package/python-pyro/Config.in"
> source "package/python-pyroute2/Config.in"
> source "package/python-pysendfile/Config.in"
> diff --git a/package/python-pyratemp/Config.in b/package/python-pyratemp/Config.in
> new file mode 100644
> index 0000000..1e7309e
> --- /dev/null
> +++ b/package/python-pyratemp/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_PYTHON_PYRATEMP
> + bool "python-pyratemp"
> + depends on BR2_PACKAGE_PYTHON
Project's website says, that this package is compatible with both
Python 2 and 3, so no need to depend on BR2_PACKAGE_PYTHON. Just
remove this line.
Yegor
> + help
> + python-pyratemp is a Python library for doing html templates.
> + written entirely in Python, that is designed to be very easy to use
> + and very like writing Python.
> +
> + https://pypi.python.org/pypi/pyratemp/
> diff --git a/package/python-pyratemp/python-pyratemp.hash b/package/python-pyratemp/python-pyratemp.hash
> new file mode 100644
> index 0000000..0abb9e0
> --- /dev/null
> +++ b/package/python-pyratemp/python-pyratemp.hash
> @@ -0,0 +1,4 @@
> +# From http://www.simple-is-better.org/template
> +# Locally calculated:
> +sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
> +
> diff --git a/package/python-pyratemp/python-pyratemp.mk b/package/python-pyratemp/python-pyratemp.mk
> new file mode 100644
> index 0000000..4c78154
> --- /dev/null
> +++ b/package/python-pyratemp/python-pyratemp.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-pyratemp
> +#
> +################################################################################
> +
> +PYTHON_PYRATEMP_VERSION = 0.3.2
> +PYTHON_PYRATEMP_SOURCE = pyratemp-$(PYTHON_PYRATEMP_VERSION).tgz
> +PYTHON_PYRATEMP_SITE = http://www.simple-is-better.org/template
> +PYTHON_PYRATEMP_LICENSE = MIT
> +PYTHON_PYRATEMP_LICENSE_FILES = LICENSE
> +PYTHON_PYRATEMP_SETUP_TYPE = distutils
> +
> +$(eval $(python-package))
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] add python simple template module
2015-09-13 16:41 [Buildroot] [PATCH 1/1] add python simple template module Steve Calfee
2015-09-13 17:05 ` Yegor Yefremov
@ 2015-09-13 18:04 ` Thomas Petazzoni
2015-09-15 0:41 ` Steve Calfee
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2015-09-13 18:04 UTC (permalink / raw)
To: buildroot
Dear Steve Calfee,
The title of the commit should be:
python-pyratemp: new package
On Sun, 13 Sep 2015 09:41:43 -0700, Steve Calfee wrote:
> diff --git a/package/python-pyratemp/python-pyratemp.hash b/package/python-pyratemp/python-pyratemp.hash
> new file mode 100644
> index 0000000..0abb9e0
> --- /dev/null
> +++ b/package/python-pyratemp/python-pyratemp.hash
> @@ -0,0 +1,4 @@
> +# From http://www.simple-is-better.org/template
> +# Locally calculated:
Having those two comments together do not make sense. Either the hash
is provided by the official upstream website and you should write the
first line, or the hash is not available from the upstream website, in
which case you use a locally calculated hash.
> +sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
> +
Unneeded empty line.
Could you fix those minor issues, as well as Yegor's comment, and send
a v2 version of this patch?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] add python simple template module
2015-09-13 18:04 ` Thomas Petazzoni
@ 2015-09-15 0:41 ` Steve Calfee
2015-09-15 6:23 ` Yegor Yefremov
0 siblings, 1 reply; 6+ messages in thread
From: Steve Calfee @ 2015-09-15 0:41 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Sun, Sep 13, 2015 at 11:04 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Steve Calfee,
>
> The title of the commit should be:
>
> python-pyratemp: new package
>
> On Sun, 13 Sep 2015 09:41:43 -0700, Steve Calfee wrote:
>
>
>> diff --git a/package/python-pyratemp/python-pyratemp.hash b/package/python-pyratemp/python-pyratemp.hash
>> new file mode 100644
>> index 0000000..0abb9e0
>> --- /dev/null
>> +++ b/package/python-pyratemp/python-pyratemp.hash
>> @@ -0,0 +1,4 @@
>> +# From http://www.simple-is-better.org/template
>> +# Locally calculated:
>
> Having those two comments together do not make sense. Either the hash
> is provided by the official upstream website and you should write the
> first line, or the hash is not available from the upstream website, in
> which case you use a locally calculated hash.
>
>> +sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
>> +
>
> Unneeded empty line.
>
Thanks for the review.
I just rebuilt and found that the .hash file has to have an eol after
that last line. So please reject the V2 version and I will send in
another one tomorrow which will survive through a make clean.
Regards, Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] add python simple template module
2015-09-15 0:41 ` Steve Calfee
@ 2015-09-15 6:23 ` Yegor Yefremov
2015-09-15 15:56 ` Steve Calfee
0 siblings, 1 reply; 6+ messages in thread
From: Yegor Yefremov @ 2015-09-15 6:23 UTC (permalink / raw)
To: buildroot
Hi Steve,
On Tue, Sep 15, 2015 at 2:41 AM, Steve Calfee <stevecalfee@gmail.com> wrote:
> Hi Thomas,
>
> On Sun, Sep 13, 2015 at 11:04 AM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Dear Steve Calfee,
>>
>> The title of the commit should be:
>>
>> python-pyratemp: new package
>>
>> On Sun, 13 Sep 2015 09:41:43 -0700, Steve Calfee wrote:
>>
>>
>>> diff --git a/package/python-pyratemp/python-pyratemp.hash b/package/python-pyratemp/python-pyratemp.hash
>>> new file mode 100644
>>> index 0000000..0abb9e0
>>> --- /dev/null
>>> +++ b/package/python-pyratemp/python-pyratemp.hash
>>> @@ -0,0 +1,4 @@
>>> +# From http://www.simple-is-better.org/template
>>> +# Locally calculated:
>>
>> Having those two comments together do not make sense. Either the hash
>> is provided by the official upstream website and you should write the
>> first line, or the hash is not available from the upstream website, in
>> which case you use a locally calculated hash.
>>
>>> +sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
>>> +
>>
>> Unneeded empty line.
>>
>
> Thanks for the review.
>
> I just rebuilt and found that the .hash file has to have an eol after
> that last line. So please reject the V2 version and I will send in
> another one tomorrow which will survive through a make clean.
while you are at it, please add both md5 and sha256 to the *.hash
file. Your package is ony PyPi, that already provides MD5. In addition
we add stronger sha256 checksum. Just take a look at tornado package:
http://git.buildroot.net/buildroot/tree/package/python-tornado/python-tornado.hash
Yegor
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] add python simple template module
2015-09-15 6:23 ` Yegor Yefremov
@ 2015-09-15 15:56 ` Steve Calfee
0 siblings, 0 replies; 6+ messages in thread
From: Steve Calfee @ 2015-09-15 15:56 UTC (permalink / raw)
To: buildroot
Hi Yegor,
On Mon, Sep 14, 2015 at 11:23 PM, Yegor Yefremov
<yegorslists@googlemail.com> wrote:
> Hi Steve,
>
> On Tue, Sep 15, 2015 at 2:41 AM, Steve Calfee <stevecalfee@gmail.com> wrote:
>> Hi Thomas,
>>
>> I just rebuilt and found that the .hash file has to have an eol after
>> that last line. So please reject the V2 version and I will send in
>> another one tomorrow which will survive through a make clean.
>
> while you are at it, please add both md5 and sha256 to the *.hash
> file. Your package is ony PyPi, that already provides MD5. In addition
> we add stronger sha256 checksum. Just take a look at tornado package:
>
> http://git.buildroot.net/buildroot/tree/package/python-tornado/python-tornado.hash
>
> Yegor
This last comment about an example helped a lot. I did not realize
that there was a generic download source at pypi. Much better. So I
changed to that source and included the original md5 as you suggested
as well as my sha256.
The other thing I did not know was how to determine
PYTHON_PYRATEMP_SETUP_TYPE. I guess I stopped at the tutorial in the
manual. The next section "python-package reference" helpfully told me
how to determine the type.
Regards, Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-15 15:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-13 16:41 [Buildroot] [PATCH 1/1] add python simple template module Steve Calfee
2015-09-13 17:05 ` Yegor Yefremov
2015-09-13 18:04 ` Thomas Petazzoni
2015-09-15 0:41 ` Steve Calfee
2015-09-15 6:23 ` Yegor Yefremov
2015-09-15 15:56 ` Steve Calfee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox