[Buildroot] [PATCH v2] package/oprofile: disable for m68k

[Buildroot] [PATCH v2] package/oprofile: disable for m68k

[Romain Naour]

As for Xtensa [1] and Microblaze [2], disable m68k due to the lack of
memory barrier operations.

Fixes:
http://autobuild.buildroot.net/results/1cc/1cc761d8a5715d0a2c6eaacfde7e44b225da1b36

[1] c45979c732cb610ad5d54e23dd7d4d49e519d45b
[2] b71bdd68562f82db9d5515de1ca4a33789c05cb9

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
v2: fix the comment dependency.
---
 package/oprofile/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/oprofile/Config.in b/package/oprofile/Config.in
index 9014d9f..4f491cb 100644
--- a/package/oprofile/Config.in
+++ b/package/oprofile/Config.in
@@ -8,7 +8,7 @@ config BR2_PACKAGE_OPROFILE
 	depends on !BR2_nios2 # binutils
 	depends on BR2_USE_WCHAR # binutils
 	# no memory barrier functions
-	depends on !BR2_xtensa && !BR2_microblaze
+	depends on !BR2_xtensa && !BR2_microblaze && !BR2_m68k
 	# libpfm4 is needed on PowerPC, and requires thread support
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_powerpc
 	help
@@ -29,7 +29,8 @@ config BR2_PACKAGE_OPROFILE
 
 comment "oprofile needs a toolchain w/ C++, wchar"
 	depends on BR2_USE_MMU
-	depends on !BR2_nios2 && !BR2_xtensa && !BR2_microblaze
+	depends on !BR2_nios2 && !BR2_xtensa && !BR2_microblaze && \
+		!BR2_m68k
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
 
 comment "oprofile needs a toolchain w/ NPTL on PPC"
-- 
2.5.5

[Buildroot] [PATCH v2] package/oprofile: disable for m68k

[Thomas Petazzoni]

Hello,

On Thu,  4 Aug 2016 23:58:05 +0200, Romain Naour wrote:

>  	# no memory barrier functions
> -	depends on !BR2_xtensa && !BR2_microblaze
> +	depends on !BR2_xtensa && !BR2_microblaze && !BR2_m68k

I was also looking at this, and I think we need to invert the logic.
There's a file in oprofile sources that defines rmb() for a number of
architectures. We should have a BR2_PACKAGE_OPROFILE_ARCH_SUPPORTS that
is set to 'y' only for the architectures that are explicitly supported
by oprofile.

Could you look into this?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com