[Buildroot] [PATCH 1/2] ne10: bump to version 1.2.1. Remove obsolete patch file for modifying thumb code generation.

[Buildroot] [PATCH 1/2] ne10: bump to version 1.2.1. Remove obsolete patch file for modifying thumb code generation.

[J Evans]

Signed-off-by: J Evans <g4@novadsp.com>
---
 ...sts-don-t-hard-code-thumb-code-generation.patch | 29 ----------------------
 package/ne10/Config.in                             |  6 ++---
 package/ne10/ne10.hash                             |  4 +--
 package/ne10/ne10.mk                               |  2 +-
 4 files changed, 5 insertions(+), 36 deletions(-)
 delete mode 100644 package/ne10/0001-CMakeLists-don-t-hard-code-thumb-code-generation.patch
 mode change 100644 => 100755 package/ne10/Config.in
 mode change 100644 => 100755 package/ne10/ne10.hash
 mode change 100644 => 100755 package/ne10/ne10.mk

diff --git a/package/ne10/0001-CMakeLists-don-t-hard-code-thumb-code-generation.patch b/package/ne10/0001-CMakeLists-don-t-hard-code-thumb-code-generation.patch
deleted file mode 100644
index f140a60..0000000
--- a/package/ne10/0001-CMakeLists-don-t-hard-code-thumb-code-generation.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-From 9ff39800cec5f1dabba246b253794582d611bc6d Mon Sep 17 00:00:00 2001
-From: Baruch Siach <baruch@tkos.co.il>
-Date: Fri, 20 Feb 2015 10:44:15 -0600
-Subject: [PATCH] CMakeLists: don't hard code thumb code generation
-
-Migrating to version 1.2.0
-
-Signed-off-by: Baruch Siach <baruch@tkos.co.il>
-Signed-off-by: Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
----
- CMakeLists.txt | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index fdf01ec..34ae26e 100644
---- a/CMakeLists.txt
-+++ b/CMakeLists.txt
-@@ -84,7 +84,7 @@ if(ANDROID_PLATFORM)
-     ${ANDROID_TOOLCHAIN_PATH}/arm-linux-androideabi-ar
-     ${ANDROID_TOOLCHAIN_PATH}/arm-linux-androideabi-ranlib")
- elseif(GNULINUX_PLATFORM)
--    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mthumb-interwork -mthumb -march=armv7-a -mfpu=vfp3")
-+    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mthumb-interwork -march=armv7-a -mfpu=vfp3")
-     set(CMAKE_ASM_FLAGS "${CMAKE_C_FLAGS} -mthumb-interwork -mthumb -march=armv7-a -mfpu=neon")
- elseif(IOS_PLATFORM)
-     #set minimal target ios version.If not provided this option, Xcode
--- 
-1.9.1
-
diff --git a/package/ne10/Config.in b/package/ne10/Config.in
old mode 100644
new mode 100755
index 8d37579..ebd23a6
--- a/package/ne10/Config.in
+++ b/package/ne10/Config.in
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_NE10
 	bool "ne10"
-	depends on BR2_arm
-	depends on BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4
+	depends on BR2_aarch64 || (BR2_arm && (BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4))
 	help
 	  The Ne10 project has been set up to provide a set of common,
 	  useful functions which have been heavily optimized for the
@@ -13,5 +12,4 @@ config BR2_PACKAGE_NE10
 	  http://projectne10.github.io/Ne10/
 
 comment "ne10 needs a toolchain w/ neon"
-	depends on BR2_arm
-	depends on !(BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4)
+	depends on BR2_aarch64 || (BR2_arm && !(BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4))
diff --git a/package/ne10/ne10.hash b/package/ne10/ne10.hash
old mode 100644
new mode 100755
index db5b6f1..923e660
--- a/package/ne10/ne10.hash
+++ b/package/ne10/ne10.hash
@@ -1,2 +1,2 @@
-# Locally calculated
-sha256 450dac5bb3a2351019ae23792e97c3bf965d16a21c0598b73cea9fbc3b3a56af  ne10-v1.2.0.tar.gz
+# Locally calculated after checking pgp signature
+sha256	dd1a96610c0692cc80154ae123edd5d25e6e0a3f81d0c16a96425f3ef57b9929	ne10-v1.2.1.tar.gz
diff --git a/package/ne10/ne10.mk b/package/ne10/ne10.mk
old mode 100644
new mode 100755
index cb303bd..0da862c
--- a/package/ne10/ne10.mk
+++ b/package/ne10/ne10.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-NE10_VERSION = v1.2.0
+NE10_VERSION = v1.2.1
 NE10_SITE = $(call github,projectNe10,Ne10,$(NE10_VERSION))
 NE10_LICENSE = BSD-3-Clause or Apache-2.0
 NE10_LICENSE_FILES = doc/LICENSE
-- 
2.7.4

[Buildroot] [PATCH 2/2] ne10: Add aarch64 configuration option

[J Evans]

Signed-off-by: J Evans <g4@novadsp.com>
---
 package/ne10/ne10.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/ne10/ne10.mk b/package/ne10/ne10.mk
index 0da862c..b4611e8 100755
--- a/package/ne10/ne10.mk
+++ b/package/ne10/ne10.mk
@@ -17,6 +17,12 @@ NE10_CONF_OPTS += \
 	-DNE10_BUILD_SHARED=ON
 endif
 
+# 
+ifeq ($(BR2_aarch64),y)
+NE10_CONF_OPTS += \
+    -DNE10_LINUX_TARGET_ARCH=aarch64
+endif
+
 # The package does not have any install target, so have to provide
 # INSTALL_STAGING_CMDS and INSTALL_TARGET_CMDS.
 
-- 
2.7.4

[Buildroot] [PATCH 2/2] ne10: Add aarch64 configuration option

[g4 at novadsp.com]

> -----Original Message-----
> From: buildroot [mailto:buildroot-bounces at busybox.net] On Behalf Of J
> Evans
> Sent: 28 April 2017 23:28
> To: buildroot at buildroot.org
> Cc: Thomas Petazzoni; J Evans
> Subject: [Buildroot] [PATCH 2/2] ne10: Add aarch64 configuration option
> 
> Signed-off-by: J Evans <g4@novadsp.com>

Apologies. This patch appears to be incomplete, please ignore. Whilst it
works fine for ARM64 the latest does not want to configure correctly for a
PI3 for example.

BR,

Jerry.

[Buildroot] [PATCH 2/2] ne10: Add aarch64 configuration option

[Thomas Petazzoni]

Hello,

On Fri, 28 Apr 2017 23:28:06 +0100, J Evans wrote:

> +ifeq ($(BR2_aarch64),y)
> +NE10_CONF_OPTS += \
> +    -DNE10_LINUX_TARGET_ARCH=aarch64
> +endif

PATCH 1/2 is already enabling ne10 on AArch64, so there's something
wrong going on here. This change should go with the patch enabling ne10
on AArch64.

But I believe you should in fact rework your patches:

 - One patch that just bumps ne10, keeping only the ARM support

 - One patch that refactors the architecture dependency with a
   Config.in hidden boolean BR2_PACKAGE_NE10_ARCH_SUPPORTS

 - One patch that allows to use ne10 on AArch64

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] ne10: Add aarch64 configuration option

[jerry at chordia.co.uk]

Hello,

> 
> But I believe you should in fact rework your patches:
> 
>  - One patch that just bumps ne10, keeping only the ARM support
> 
>  - One patch that refactors the architecture dependency with a
>    Config.in hidden boolean BR2_PACKAGE_NE10_ARCH_SUPPORTS
> 
>  - One patch that allows to use ne10 on AArch64

OK, I will do that.

BR

Jerry

[Buildroot] [PATCH 1/2] ne10: bump to version 1.2.1. Remove obsolete patch file for modifying thumb code generation.

[Thomas Petazzoni]

Hello,

Since the change is not trivial, it requires a more verbose commit log.
You're doing much more than bumping.

Also, the commit title should be shorter, just "ne10: bump to version
1.2.1".

On Fri, 28 Apr 2017 23:28:05 +0100, J Evans wrote:

>  ...sts-don-t-hard-code-thumb-code-generation.patch | 29 ----------------------

What makes you think this patch is no longer needed? The CMakeLists.txt
is still hardcoding -mthumb:

    if("${NE10_TARGET_ARCH}" STREQUAL "armv7")
      set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mthumb-interwork -mthumb -march=armv7-a -mfpu=vfp3 -funsafe-math-optimizations")
      set(CMAKE_ASM_FLAGS "${CMAKE_C_FLAGS} -mthumb-interwork -mthumb -march=armv7-a -mfpu=neon")


> diff --git a/package/ne10/Config.in b/package/ne10/Config.in
> old mode 100644
> new mode 100755

Why are you making this file executable? Are you working on Windows?

> index 8d37579..ebd23a6
> --- a/package/ne10/Config.in
> +++ b/package/ne10/Config.in
> @@ -1,7 +1,6 @@
>  config BR2_PACKAGE_NE10
>  	bool "ne10"
> -	depends on BR2_arm
> -	depends on BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4
> +	depends on BR2_aarch64 || (BR2_arm && (BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4))

I think it would be nicer to introduce a blind option:

config BR2_PACKAGE_NE10_ARCH_SUPPORTS
	bool
	default y if BR2_aarch64
	default y if BR2_arm && (BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4)

and then use it in BR2_PACKAGE_NE10 and the Config.in comment.


> old mode 100644
> new mode 100755
> index db5b6f1..923e660
> --- a/package/ne10/ne10.hash
> +++ b/package/ne10/ne10.hash

Why are you making this file executable ?

> @@ -1,2 +1,2 @@
> -# Locally calculated
> -sha256 450dac5bb3a2351019ae23792e97c3bf965d16a21c0598b73cea9fbc3b3a56af  ne10-v1.2.0.tar.gz
> +# Locally calculated after checking pgp signature
> +sha256	dd1a96610c0692cc80154ae123edd5d25e6e0a3f81d0c16a96425f3ef57b9929	ne10-v1.2.1.tar.gz
> diff --git a/package/ne10/ne10.mk b/package/ne10/ne10.mk
> old mode 100644
> new mode 100755
> index cb303bd..0da862c
> --- a/package/ne10/ne10.mk
> +++ b/package/ne10/ne10.mk

Same question.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com