[Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv

[Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv

[Vadim Kochan]

From: Vadim Kochan <vadim4j@gmail.com>

target's libiconv is added into host dependency which makes cyclic
dependency, anyway this dependency is not needed because of assumption
that iconv should be provided by the host.

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
 package/gettext-tiny/gettext-tiny.mk | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/package/gettext-tiny/gettext-tiny.mk b/package/gettext-tiny/gettext-tiny.mk
index 4fa014e..87e90bc 100644
--- a/package/gettext-tiny/gettext-tiny.mk
+++ b/package/gettext-tiny/gettext-tiny.mk
@@ -49,10 +49,6 @@ define HOST_GETTEXT_TINY_COPY_EXTRA_FILES
 endef
 HOST_GETTEXT_TINY_POST_PATCH_HOOKS += HOST_GETTEXT_TINY_COPY_EXTRA_FILES
 
-ifeq ($(BR2_ENABLE_LOCALE),)
-HOST_GETTEXT_TINY_DEPENDENCIES = libiconv
-endif
-
 define HOST_GETTEXT_TINY_BUILD_CMDS
 	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) \
 		$(HOST_CONFIGURE_OPTS) \
-- 
2.7.4

[Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv

[Alexey Brodkin]

Hi Vadim,

> -----Original Message-----
> From: Vadim Kochan <vadim4j@gmail.com>
> Sent: Tuesday, April 9, 2019 4:55 PM
> To: buildroot at buildroot.org
> Cc: Vadim Kochan <vadim4j@gmail.com>; Alexey Brodkin <alexey.brodkin@synopsys.com>
> Subject: [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv
> 
> From: Vadim Kochan <vadim4j@gmail.com>
> 
> target's libiconv is added into host dependency which makes cyclic
> dependency, anyway this dependency is not needed because of assumption
> that iconv should be provided by the host.
> 
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---

Thanks for fixing this one!

Reviewed-by: Alexey Brodkin <abrokdin@synopsys.com>

[Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv

[Thomas Petazzoni]

On Tue,  9 Apr 2019 16:55:04 +0300
Vadim Kochan <vadim4j@gmail.com> wrote:

> From: Vadim Kochan <vadim4j@gmail.com>
> 
> target's libiconv is added into host dependency which makes cyclic
> dependency, anyway this dependency is not needed because of assumption
> that iconv should be provided by the host.
> 
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
>  package/gettext-tiny/gettext-tiny.mk | 4 ----
>  1 file changed, 4 deletions(-)

Applied to master after significantly reworking the commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com