* [Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv
@ 2019-04-09 13:55 Vadim Kochan
2019-04-09 19:40 ` Alexey Brodkin
2019-04-10 10:03 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Vadim Kochan @ 2019-04-09 13:55 UTC (permalink / raw)
To: buildroot
From: Vadim Kochan <vadim4j@gmail.com>
target's libiconv is added into host dependency which makes cyclic
dependency, anyway this dependency is not needed because of assumption
that iconv should be provided by the host.
Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
package/gettext-tiny/gettext-tiny.mk | 4 ----
1 file changed, 4 deletions(-)
diff --git a/package/gettext-tiny/gettext-tiny.mk b/package/gettext-tiny/gettext-tiny.mk
index 4fa014e..87e90bc 100644
--- a/package/gettext-tiny/gettext-tiny.mk
+++ b/package/gettext-tiny/gettext-tiny.mk
@@ -49,10 +49,6 @@ define HOST_GETTEXT_TINY_COPY_EXTRA_FILES
endef
HOST_GETTEXT_TINY_POST_PATCH_HOOKS += HOST_GETTEXT_TINY_COPY_EXTRA_FILES
-ifeq ($(BR2_ENABLE_LOCALE),)
-HOST_GETTEXT_TINY_DEPENDENCIES = libiconv
-endif
-
define HOST_GETTEXT_TINY_BUILD_CMDS
$(HOST_MAKE_ENV) $(MAKE) -C $(@D) \
$(HOST_CONFIGURE_OPTS) \
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv
2019-04-09 13:55 [Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv Vadim Kochan
@ 2019-04-09 19:40 ` Alexey Brodkin
2019-04-10 10:03 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Alexey Brodkin @ 2019-04-09 19:40 UTC (permalink / raw)
To: buildroot
Hi Vadim,
> -----Original Message-----
> From: Vadim Kochan <vadim4j@gmail.com>
> Sent: Tuesday, April 9, 2019 4:55 PM
> To: buildroot at buildroot.org
> Cc: Vadim Kochan <vadim4j@gmail.com>; Alexey Brodkin <alexey.brodkin@synopsys.com>
> Subject: [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv
>
> From: Vadim Kochan <vadim4j@gmail.com>
>
> target's libiconv is added into host dependency which makes cyclic
> dependency, anyway this dependency is not needed because of assumption
> that iconv should be provided by the host.
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
Thanks for fixing this one!
Reviewed-by: Alexey Brodkin <abrokdin@synopsys.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv
2019-04-09 13:55 [Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv Vadim Kochan
2019-04-09 19:40 ` Alexey Brodkin
@ 2019-04-10 10:03 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-04-10 10:03 UTC (permalink / raw)
To: buildroot
On Tue, 9 Apr 2019 16:55:04 +0300
Vadim Kochan <vadim4j@gmail.com> wrote:
> From: Vadim Kochan <vadim4j@gmail.com>
>
> target's libiconv is added into host dependency which makes cyclic
> dependency, anyway this dependency is not needed because of assumption
> that iconv should be provided by the host.
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
> package/gettext-tiny/gettext-tiny.mk | 4 ----
> 1 file changed, 4 deletions(-)
Applied to master after significantly reworking the commit log. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-10 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-09 13:55 [Buildroot] [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv Vadim Kochan
2019-04-09 19:40 ` Alexey Brodkin
2019-04-10 10:03 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox