Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] Update to mpg123
@ 2007-06-02 13:02 Rod Boyce
  2007-06-04  9:04 ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Rod Boyce @ 2007-06-02 13:02 UTC (permalink / raw)
  To: buildroot

All,

Attached is an update to mpg123 this brings the build-root package up to 
the latest version of mpg123 version 0.65 I have only tested this with 
my 386 target others will have to test as well.  I have also attach a 
patch that conditionally uses ALSA when it is added to build-root and a 
patch that does not use ALSA.

Regards,
Rod Boyce
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123-0.65_alsa.patch
Type: text/x-patch
Size: 2696 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070602/9ebae922/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123-0.65_noalsa.patch
Type: text/x-patch
Size: 2545 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070602/9ebae922/attachment-0001.bin 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] Update to mpg123
  2007-06-02 13:02 [Buildroot] Update to mpg123 Rod Boyce
@ 2007-06-04  9:04 ` Peter Korsgaard
  2007-06-04 20:34   ` Rod Boyce
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2007-06-04  9:04 UTC (permalink / raw)
  To: buildroot

>>>>> "RB" == Rod Boyce <buildroot@teamboyce.co.uk> writes:

RB> All,

RB> Attached is an update to mpg123 this brings the build-root package up
RB> to the latest version of mpg123 version 0.65 I have only tested this
RB> with my 386 target others will have to test as well.  I have also
RB> attach a patch that conditionally uses ALSA when it is added to
RB> build-root and a patch that does not use ALSA.

Thanks - A few commments:

RB> -MPG123_VERSION=0.59r
RB> +MPG123_VERSION := 0.65

In the mean time 0.66 got released.

RB> -MPG123_SOURCE=mpg123-$(MPG123_VERSION).tar.gz
RB> -MPG123_CAT:=$(ZCAT)
RB> -MPG123_SITE=http://www.mpg123.de/mpg123
RB> -MPG123_DIR=$(BUILD_DIR)/mpg123-$(MPG123_VERSION)
RB> +MPG123_SOURCE := mpg123-$(MPG123_VERSION).tar.bz2
RB> +MPG123_CAT := $(BZCAT)
RB> +MPG123_SITE := http://www.mpg123.de/download
RB> +MPG123_DIR := $(BUILD_DIR)/mpg123-$(MPG123_VERSION)

What's with all those white space changes? Could you please send an
updated patch without those and with the version bumped to 0.66?

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] Update to mpg123
  2007-06-04  9:04 ` Peter Korsgaard
@ 2007-06-04 20:34   ` Rod Boyce
  2007-06-04 21:04     ` Bernhard Fischer
  0 siblings, 1 reply; 4+ messages in thread
From: Rod Boyce @ 2007-06-04 20:34 UTC (permalink / raw)
  To: buildroot

Peter Korsgaard wrote:
> Thanks - A few commments:
>
> RB> -MPG123_VERSION=0.59r
> RB> +MPG123_VERSION := 0.65
>
> In the mean time 0.66 got released.
>
> RB> -MPG123_SOURCE=mpg123-$(MPG123_VERSION).tar.gz
> RB> -MPG123_CAT:=$(ZCAT)
> RB> -MPG123_SITE=http://www.mpg123.de/mpg123
> RB> -MPG123_DIR=$(BUILD_DIR)/mpg123-$(MPG123_VERSION)
> RB> +MPG123_SOURCE := mpg123-$(MPG123_VERSION).tar.bz2
> RB> +MPG123_CAT := $(BZCAT)
> RB> +MPG123_SITE := http://www.mpg123.de/download
> RB> +MPG123_DIR := $(BUILD_DIR)/mpg123-$(MPG123_VERSION)
>
> What's with all those white space changes? Could you please send an
> updated patch without those and with the version bumped to 0.66?
>   
Peter & All,

Attached is another mpg123 patch with the version number bumped to 
TODAY's new released version number.  I have made no other changes to 
this patch is considering the changes I had to make for the previous 
version so minor which space changes are more than allowable in my 
opinion.  You are welcome to submit your own change that makes the code 
harder to read, but I'll stay with a few more spaces and a slightly 
prettier looking makefile fragment.

Regards,
Rod Boyce

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123-0.66_alsa.patch
Type: text/x-patch
Size: 2696 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070604/90b29083/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123-0.66_noalsa.patch
Type: text/x-patch
Size: 2524 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070604/90b29083/attachment-0001.bin 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] Update to mpg123
  2007-06-04 20:34   ` Rod Boyce
@ 2007-06-04 21:04     ` Bernhard Fischer
  0 siblings, 0 replies; 4+ messages in thread
From: Bernhard Fischer @ 2007-06-04 21:04 UTC (permalink / raw)
  To: buildroot

On Mon, Jun 04, 2007 at 09:34:31PM +0100, Rod Boyce wrote:
>Peter Korsgaard wrote:
>>Thanks - A few commments:
>>
>>RB> -MPG123_VERSION=0.59r
>>RB> +MPG123_VERSION := 0.65
>>
>>In the mean time 0.66 got released.
>>
>>RB> -MPG123_SOURCE=mpg123-$(MPG123_VERSION).tar.gz
>>RB> -MPG123_CAT:=$(ZCAT)
>>RB> -MPG123_SITE=http://www.mpg123.de/mpg123
>>RB> -MPG123_DIR=$(BUILD_DIR)/mpg123-$(MPG123_VERSION)
>>RB> +MPG123_SOURCE := mpg123-$(MPG123_VERSION).tar.bz2
>>RB> +MPG123_CAT := $(BZCAT)
>>RB> +MPG123_SITE := http://www.mpg123.de/download
>>RB> +MPG123_DIR := $(BUILD_DIR)/mpg123-$(MPG123_VERSION)
>>
>>What's with all those white space changes? Could you please send an
>>updated patch without those and with the version bumped to 0.66?
>>  
>Peter & All,
>
>Attached is another mpg123 patch with the version number bumped to 
>TODAY's new released version number.  I have made no other changes to 
>this patch is considering the changes I had to make for the previous 
>version so minor which space changes are more than allowable in my 
>opinion.  You are welcome to submit your own change that makes the code 
>harder to read, but I'll stay with a few more spaces and a slightly 
>prettier looking makefile fragment.

We are asking you, politely, to adhere to the established style of
*not* using spaces there, once again.

There is no sensible argument for makeing the sources bigger and less
readable in my eyes.

>Regards,
>Rod Boyce

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-06-04 21:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-02 13:02 [Buildroot] Update to mpg123 Rod Boyce
2007-06-04  9:04 ` Peter Korsgaard
2007-06-04 20:34   ` Rod Boyce
2007-06-04 21:04     ` Bernhard Fischer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox