[Buildroot] "toolchain/patch-kernel.sh" => $(APPLY)

[Buildroot] "toolchain/patch-kernel.sh" => $(APPLY)

[Ulf Samuelsson]

Today most packages uses the patch-kernel.sh script in toolchain.
Should this really be hardwired.
Is it OK to create a symbolic variable.

APPLY:=toolchain/patch-kernel.sh

Also, I would like to see a "script" directory.
"patch-kernel.sh" is then moved here and 
"depmod.pl" maybe belongs as well in this instead of in
target/device/x86.



Best Regards
Ulf Samuelsson.

[Buildroot] "toolchain/patch-kernel.sh" => $(APPLY)

[Steven J. Hill]

> Today most packages uses the patch-kernel.sh script in toolchain.
> Should this really be hardwired.
> Is it OK to create a symbolic variable.
> 
> APPLY:=toolchain/patch-kernel.sh
> 
Why? Can you explain what is lacking with this script that you are
suggesting adding another variable to track through the build system?

> Also, I would like to see a "script" directory.
> "patch-kernel.sh" is then moved here and 
> "depmod.pl" maybe belongs as well in this instead of in
> target/device/x86.
> 
I suppose a 'toolchain/scripts' directory would be okay. I do
question the need for 'depmod.pl' at all. Doesn't the target
'cross-depmod26' create the depmod that does the same thing?

-Steve

[Buildroot] "toolchain/patch-kernel.sh" => $(APPLY)

[Ulf Samuelsson]

tor 2007-07-12 klockan 08:51 -0500 skrev Steven J. Hill:
> > Today most packages uses the patch-kernel.sh script in toolchain.
> > Should this really be hardwired.
> > Is it OK to create a symbolic variable.
> > 
> > APPLY:=toolchain/patch-kernel.sh
> > 
> Why? Can you explain what is lacking with this script that you are
> suggesting adding another variable to track through the build system?
> 

Mainly:It hardwires the file to be in the toolchain directory.

Also, I think it would be good to be able to select
how you want the stuff to be patched.

1) Using a "series" file defining patch order.
2) If the "series" file does not exist, generate a series file.

What would be the drawback of adding a new variable?


> > Also, I would like to see a "script" directory.
> > "patch-kernel.sh" is then moved here and 
> > "depmod.pl" maybe belongs as well in this instead of in
> > target/device/x86.
> > 
> I suppose a 'toolchain/scripts' directory would be okay. I do
> question the need for 'depmod.pl' at all. Doesn't the target
> 'cross-depmod26' create the depmod that does the same thing?
> 
Was actually thinking of "trunk/buildroot/scripts".
There are a few things in OpenWRT I like, and it is better
to have the same directory structure if I want to minimize
future work.


> -Steve