* [Buildroot] "toolchain/patch-kernel.sh" => $(APPLY)
@ 2007-07-12 11:57 Ulf Samuelsson
2007-07-12 13:51 ` Steven J. Hill
0 siblings, 1 reply; 3+ messages in thread
From: Ulf Samuelsson @ 2007-07-12 11:57 UTC (permalink / raw)
To: buildroot
Today most packages uses the patch-kernel.sh script in toolchain.
Should this really be hardwired.
Is it OK to create a symbolic variable.
APPLY:=toolchain/patch-kernel.sh
Also, I would like to see a "script" directory.
"patch-kernel.sh" is then moved here and
"depmod.pl" maybe belongs as well in this instead of in
target/device/x86.
Best Regards
Ulf Samuelsson.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] "toolchain/patch-kernel.sh" => $(APPLY)
2007-07-12 11:57 [Buildroot] "toolchain/patch-kernel.sh" => $(APPLY) Ulf Samuelsson
@ 2007-07-12 13:51 ` Steven J. Hill
2007-07-12 15:35 ` Ulf Samuelsson
0 siblings, 1 reply; 3+ messages in thread
From: Steven J. Hill @ 2007-07-12 13:51 UTC (permalink / raw)
To: buildroot
> Today most packages uses the patch-kernel.sh script in toolchain.
> Should this really be hardwired.
> Is it OK to create a symbolic variable.
>
> APPLY:=toolchain/patch-kernel.sh
>
Why? Can you explain what is lacking with this script that you are
suggesting adding another variable to track through the build system?
> Also, I would like to see a "script" directory.
> "patch-kernel.sh" is then moved here and
> "depmod.pl" maybe belongs as well in this instead of in
> target/device/x86.
>
I suppose a 'toolchain/scripts' directory would be okay. I do
question the need for 'depmod.pl' at all. Doesn't the target
'cross-depmod26' create the depmod that does the same thing?
-Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] "toolchain/patch-kernel.sh" => $(APPLY)
2007-07-12 13:51 ` Steven J. Hill
@ 2007-07-12 15:35 ` Ulf Samuelsson
0 siblings, 0 replies; 3+ messages in thread
From: Ulf Samuelsson @ 2007-07-12 15:35 UTC (permalink / raw)
To: buildroot
tor 2007-07-12 klockan 08:51 -0500 skrev Steven J. Hill:
> > Today most packages uses the patch-kernel.sh script in toolchain.
> > Should this really be hardwired.
> > Is it OK to create a symbolic variable.
> >
> > APPLY:=toolchain/patch-kernel.sh
> >
> Why? Can you explain what is lacking with this script that you are
> suggesting adding another variable to track through the build system?
>
Mainly:It hardwires the file to be in the toolchain directory.
Also, I think it would be good to be able to select
how you want the stuff to be patched.
1) Using a "series" file defining patch order.
2) If the "series" file does not exist, generate a series file.
What would be the drawback of adding a new variable?
> > Also, I would like to see a "script" directory.
> > "patch-kernel.sh" is then moved here and
> > "depmod.pl" maybe belongs as well in this instead of in
> > target/device/x86.
> >
> I suppose a 'toolchain/scripts' directory would be okay. I do
> question the need for 'depmod.pl' at all. Doesn't the target
> 'cross-depmod26' create the depmod that does the same thing?
>
Was actually thinking of "trunk/buildroot/scripts".
There are a few things in OpenWRT I like, and it is better
to have the same directory structure if I want to minimize
future work.
> -Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-12 15:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-12 11:57 [Buildroot] "toolchain/patch-kernel.sh" => $(APPLY) Ulf Samuelsson
2007-07-12 13:51 ` Steven J. Hill
2007-07-12 15:35 ` Ulf Samuelsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox