[Buildroot] [PATCH] package: don't default to y for categories

[Buildroot] [PATCH] package: don't default to y for categories

[Markus Heidelberg]

When doing 'make oldconfig' after a new category has been added, you
can't simply press <Enter> to go on without branching into that
category. Packages default to n and there is no reason to proceed with
the categories in a different manner.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 package/Config.in          |    8 --------
 package/audio/Config.in    |    1 -
 package/database/Config.in |    1 -
 package/editors/Config.in  |    1 -
 package/games/Config.in    |    1 -
 package/java/Config.in     |    1 -
 6 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/package/Config.in b/package/Config.in
index 84aaa3e..a159220 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -28,7 +28,6 @@ endif
 
 #menuconfig BR2_APPLICATION_SUPPORT
 #	bool "Common Applications"
-#	default y
 #	help
 #	  A set of applications, utilities and libraries for
 #	  text processing, toolchain generation and other things.
@@ -132,7 +131,6 @@ endif
 
 menuconfig BR2_NETWORK_SUPPORT
 	bool "Networking"
-	default y
 	help
 	  Support for communication, networking and related packages
 
@@ -233,7 +231,6 @@ endif
 
 menuconfig BR2_BLOCKDEV_SUPPORT
 	bool "Hardware handling / blockdevices and filesystem maintenance"
-	default y
 	help
 	  Support for hardware handling and maintenance, block devices,
 	  filesystem creation and maintenance.
@@ -294,7 +291,6 @@ source "package/audio/Config.in"
 
 menuconfig BR2_GRAPHIC_SUPPORT
 	bool "Graphic libraries and applications (graphic/text)"
-	default y
 	help
 	  Support for graphic libraries, X Window system and related
 	  packages, graphical toolkits, etc.
@@ -417,7 +413,6 @@ endif
 
 menuconfig BR2_COMPRESSOR_SUPPORT
 	bool "Compressors / decompressors"
-	default y
 	help
 	  Support for compressors and decompressors like lzo, lzma, bzip2
 
@@ -432,7 +427,6 @@ endif
 
 menuconfig BR2_PACKAGEMGRS_SUPPORT
 	bool "Package managers"
-	default y
 	help
 	  Support for package managers like rpm, portage, ipkg, ..
 
@@ -446,7 +440,6 @@ endif
 
 menuconfig BR2_SCRIPTING_SUPPORT
 	bool "Interpreter languages / Scripting"
-	default y
 	help
 	  Support for scripting languages, interpreter languages.
 
@@ -461,7 +454,6 @@ endif
 
 menuconfig BR2_XML_SUPPORT
 	bool "XML handling"
-	default y
 	help
 	  Support for XML handling
 
diff --git a/package/audio/Config.in b/package/audio/Config.in
index 370467a..c6d1d65 100644
--- a/package/audio/Config.in
+++ b/package/audio/Config.in
@@ -1,6 +1,5 @@
 menuconfig BR2_AUDIO_SUPPORT
 	bool "Audio libraries and applications"
-	default y
 	help
 	  Support for audio libraries and applications
 
diff --git a/package/database/Config.in b/package/database/Config.in
index 71593d7..de1f4c5 100644
--- a/package/database/Config.in
+++ b/package/database/Config.in
@@ -1,6 +1,5 @@
 menuconfig BR2_DATABASE_SUPPORT
 	bool "Database"
-	default y
 
 if BR2_DATABASE_SUPPORT
 source "package/database/mysql_client/Config.in"
diff --git a/package/editors/Config.in b/package/editors/Config.in
index b4e7e40..2d9747b 100644
--- a/package/editors/Config.in
+++ b/package/editors/Config.in
@@ -1,6 +1,5 @@
 menuconfig BR2_TEXTEDIT_SUPPORT
 	bool "Text editors"
-	default y
 	help
 	  Support for text editors
 
diff --git a/package/games/Config.in b/package/games/Config.in
index 4d73027..606ec4a 100644
--- a/package/games/Config.in
+++ b/package/games/Config.in
@@ -1,6 +1,5 @@
 menuconfig BR2_GAMES
 	bool "Games"
-	default y
 	help
 	  Support for games
 
diff --git a/package/java/Config.in b/package/java/Config.in
index 1ed0475..e814271 100644
--- a/package/java/Config.in
+++ b/package/java/Config.in
@@ -1,6 +1,5 @@
 menuconfig BR2_JAVA_SUPPORT
         bool "Java"
-        default y
         help
           Support java programs (classpath, vm, osgi)
 
-- 
1.6.0.4.620.g87fa

[Buildroot] [PATCH] package: don't default to y for categories

[Markus Heidelberg]

Arnar Mar Sig, 13.11.2008:
> How about creating new categories for the packages on the main  
> "package selection for target" page?
> 
> Personally I thing there are way to many package on the main page and  
> I'm board of always scolling thru it to.

That's what I think, too. Some more order would be nice. I also find the
scrolling quite annoying.

Markus

[Buildroot] [PATCH] package: don't default to y for categories

[Hans-Christian Egtvedt]

On Fri, 14 Nov 2008 09:57:05 +0100
Markus Heidelberg <markus.heidelberg@web.de> wrote:

> Arnar Mar Sig, 13.11.2008:
> > How about creating new categories for the packages on the main  
> > "package selection for target" page?
> > 
> > Personally I thing there are way to many package on the main page
> > and I'm board of always scolling thru it to.
> 
> That's what I think, too. Some more order would be nice. I also find
> the scrolling quite annoying.
> 

A bit OT; the sub package selection directory should be selected when
you have a package selected beneath. That way you can not disable
compression stuff, when you have ZLIB selected by other packages.

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] [PATCH] package: don't default to y for categories

[Markus Heidelberg]

Hans-Christian Egtvedt, 14.11.2008:
> On Fri, 14 Nov 2008 09:57:05 +0100
> Markus Heidelberg <markus.heidelberg@web.de> wrote:
> 
> > Arnar Mar Sig, 13.11.2008:
> > > How about creating new categories for the packages on the main  
> > > "package selection for target" page?
> > > 
> > > Personally I thing there are way to many package on the main page
> > > and I'm board of always scolling thru it to.
> > 
> > That's what I think, too. Some more order would be nice. I also find
> > the scrolling quite annoying.
> > 
> 
> A bit OT; the sub package selection directory should be selected when
> you have a package selected beneath. That way you can not disable
> compression stuff, when you have ZLIB selected by other packages.

Damn, I see. So please forget the patch for now.

Markus

[Buildroot] [PATCH] package: don't default to y for categories

[Hans-Christian Egtvedt]

On Fri, 14 Nov 2008 10:21:18 +0100
Markus Heidelberg <markus.heidelberg@web.de> wrote:

> Hans-Christian Egtvedt, 14.11.2008:
> > On Fri, 14 Nov 2008 09:57:05 +0100
> > Markus Heidelberg <markus.heidelberg@web.de> wrote:

<snipp>

> > A bit OT; the sub package selection directory should be selected
> > when you have a package selected beneath. That way you can not
> > disable compression stuff, when you have ZLIB selected by other
> > packages.
> 
> Damn, I see. So please forget the patch for now.
> 

It was more a remark about a general "bug" in the menu system generated
by kconfig now. Just look at the kernel, if you select a driver beneath
SPI, then you are not able to deselect the SPI category. I think we
should do the same with the kconfig in Buildroot.

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] [PATCH] package: don't default to y for categories

[Thomas Petazzoni]

Le Fri, 14 Nov 2008 10:52:26 +0100,
Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> a ?crit :

> It was more a remark about a general "bug" in the menu system
> generated by kconfig now. Just look at the kernel, if you select a
> driver beneath SPI, then you are not able to deselect the SPI
> category. I think we should do the same with the kconfig in Buildroot.

This is important when enabling a category enables the compilation of a
particular set of code, required for the items available under this
specific category.

In our case, the categories ? Graphical libraries ?, ? Audio stuff ?
and others do not lead to anything being compiled, except if I'm wrong.
So I would say that we shouldn't be able to select/unselect the
categories. They should just be submenus, to organize the options, not
more.

Look at the top of the kernel configuration system. Networking support
can be enabled/disabled as a whole, while Device Drivers is just a
submenu. Our categories should be like Device Drivers, IMO.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] package: don't default to y for categories

[Hans-Christian Egtvedt]

On Fri, 14 Nov 2008 11:15:45 +0100
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Le Fri, 14 Nov 2008 10:52:26 +0100,
> Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> a ?crit :
> 
> > It was more a remark about a general "bug" in the menu system
> > generated by kconfig now. Just look at the kernel, if you select a
> > driver beneath SPI, then you are not able to deselect the SPI
> > category. I think we should do the same with the kconfig in
> > Buildroot.
> 
> This is important when enabling a category enables the compilation of
> a particular set of code, required for the items available under this
> specific category.
> 
> In our case, the categories ? Graphical libraries ?, ? Audio stuff ?
> and others do not lead to anything being compiled, except if I'm
> wrong. So I would say that we shouldn't be able to select/unselect the
> categories. They should just be submenus, to organize the options, not
> more.
> 

Ah, even more sane. I think I for long time ago (probably fixed now)
that LZO was not compiled if the compression menu was not selected. LZO
was selected by some other packages in a different sub menu.

Anyways, it was the LZO package which should have been fixed, not the
menu system.

> Look at the top of the kernel configuration system. Networking support
> can be enabled/disabled as a whole, while Device Drivers is just a
> submenu. Our categories should be like Device Drivers, IMO.
> 

Yes, that is smoother IMHO.

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] [PATCH] package: don't default to y for categories

[Peter Korsgaard]

>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:

Hi,

 >> In our case, the categories ? Graphical libraries ?, ? Audio stuff ?
 >> and others do not lead to anything being compiled, except if I'm
 >> wrong. So I would say that we shouldn't be able to select/unselect the
 >> categories. They should just be submenus, to organize the options, not
 >> more.
 >> 

 Hans-Christian> Ah, even more sane. I think I for long time ago
 Hans-Christian> (probably fixed now) that LZO was not compiled if the
 Hans-Christian> compression menu was not selected. LZO was selected
 Hans-Christian> by some other packages in a different sub menu.

I actually think that's still the case as we don't source the
Config.in files of the stuff in the sub menus if the menu isn't
enabled.

 >> Look at the top of the kernel configuration system. Networking support
 >> can be enabled/disabled as a whole, while Device Drivers is just a
 >> submenu. Our categories should be like Device Drivers, IMO.
 >> 

 Hans-Christian> Yes, that is smoother IMHO.

I agree. I'll change the sub menus to use menu / endmenu instead of
menuconfig. This does mean that you no longer can deselect all
packages in a submenu simply by deselecting the menu, but as all
packages default to n that shouldn't be a big deal.

-- 
Bye, Peter Korsgaard