Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Heidelberg <markus.heidelberg@web.de>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good
Date: Thu, 22 Jan 2009 22:17:57 +0100	[thread overview]
Message-ID: <200901222217.57888.markus.heidelberg@web.de> (raw)
In-Reply-To: <20090122110159.E9877765E9@busybox.osuosl.org>

laird at uclibc.org, 22.01.2009:
> Author: laird
> Date: 2009-01-22 11:01:56 +0000 (Thu, 22 Jan 2009)
> New Revision: 24960
> 
> Log:
> package/multimedia/gst-plugins-good/Config.in
> package/multimedia/gst-plugins-good/gst-plugins-good.mk

It probably doesn't make sense to include the filenames in the commit
message, let alone full paths. The VCS knows them anyway.

> +ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PNG),y)
> +GST_PLUGINS_GOOD_CONF_OPT += --enable-png
> +GST_PLUGINS_GOOD_DEPENDENCIES += libpng
> +else
> +GST_PLUGINS_GOOD_CONF_OPT += --disable-png
> +endif

I just saw this in configure:
  --disable-libpng             disable Portable Network Graphics library: png

libpng instead of png


Also, please keep the order of the config options identically between
the files for Kconfig and Make.
In Config.in you have : jpeg, png, bz2, zlib
In gst-plugins-good.mk: bz2, zlib, jpeg, png

With this big amount of options, it could get distracting, when
extending the package or searching for bugs.

Markus

  reply	other threads:[~2009-01-22 21:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22 11:01 [Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good laird at uclibc.org
2009-01-22 21:17 ` Markus Heidelberg [this message]
2009-01-23  9:18   ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2009-02-26  8:05 jacmet at uclibc.org
2009-02-26  8:05 jacmet at uclibc.org
2009-02-25 19:51 jacmet at uclibc.org
2009-01-23 10:39 laird at uclibc.org
2009-01-22  8:09 laird at uclibc.org
2009-01-21 13:33 laird at uclibc.org
2009-01-21 13:40 ` Peter Korsgaard
2009-01-21 15:56   ` Daniel Laird
2009-01-22  9:16     ` Markus Heidelberg
2009-01-22  9:20       ` Daniel James Laird
2009-01-22  9:32         ` Markus Heidelberg
2009-01-22  9:44           ` Markus Heidelberg
2009-01-22  9:09 ` Markus Heidelberg
2009-01-22  9:13   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901222217.57888.markus.heidelberg@web.de \
    --to=markus.heidelberg@web.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox