From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good
Date: Fri, 23 Jan 2009 10:18:12 +0100 [thread overview]
Message-ID: <87fxjamld7.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <200901222217.57888.markus.heidelberg@web.de> (Markus Heidelberg's message of "Thu\, 22 Jan 2009 22\:17\:57 +0100")
>>>>> "Markus" == Markus Heidelberg <markus.heidelberg@web.de> writes:
>> Log:
>> package/multimedia/gst-plugins-good/Config.in
>> package/multimedia/gst-plugins-good/gst-plugins-good.mk
Markus> It probably doesn't make sense to include the filenames in the commit
Markus> message, let alone full paths. The VCS knows them anyway.
I agree - It's good to prefix the commit message with what's it about
(E.G. gst-plugins-good:) to make it easy to find back (E.G. in gitk),
but not the individual file names.
Markus> Also, please keep the order of the config options identically between
Markus> the files for Kconfig and Make.
Markus> In Config.in you have : jpeg, png, bz2, zlib
Markus> In gst-plugins-good.mk: bz2, zlib, jpeg, png
Markus> With this big amount of options, it could get distracting, when
Markus> extending the package or searching for bugs.
Agree.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-01-23 9:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 11:01 [Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good laird at uclibc.org
2009-01-22 21:17 ` Markus Heidelberg
2009-01-23 9:18 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-26 8:05 jacmet at uclibc.org
2009-02-26 8:05 jacmet at uclibc.org
2009-02-25 19:51 jacmet at uclibc.org
2009-01-23 10:39 laird at uclibc.org
2009-01-22 8:09 laird at uclibc.org
2009-01-21 13:33 laird at uclibc.org
2009-01-21 13:40 ` Peter Korsgaard
2009-01-21 15:56 ` Daniel Laird
2009-01-22 9:16 ` Markus Heidelberg
2009-01-22 9:20 ` Daniel James Laird
2009-01-22 9:32 ` Markus Heidelberg
2009-01-22 9:44 ` Markus Heidelberg
2009-01-22 9:09 ` Markus Heidelberg
2009-01-22 9:13 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxjamld7.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox