Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good
Date: Wed, 21 Jan 2009 14:40:18 +0100	[thread overview]
Message-ID: <87ocy0srp9.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090121133322.0FFA4770FC@busybox.osuosl.org> (laird@uclibc.org's message of "Wed\, 21 Jan 2009 13\:33\:21 +0000 \(UTC\)")

>>>>> "laird" == laird  <laird@uclibc.org> writes:

 laird> Author: laird
 laird> Date: 2009-01-21 13:33:21 +0000 (Wed, 21 Jan 2009)
 laird> New Revision: 24937

 laird> Log:
 laird> package/multimedia/gst-plugins-good/gst-plugins-good.mk
 laird> package/multimedia/gst-plugins-good/Config.in

 laird> gst-plugins-good does not build unless some package dependencies are forced.
 laird> This patch allows you to turn off some of the plugins with these dependencies and hides
 laird> others that require some packages (like PNG/JPEG)

 laird> Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>


 laird>  config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA
 laird>  	bool "matroska"
 laird> +	depends on BR2_PACKAGE_BZIP2 && BR2_PACKAGE_ZLIB

I prefer to use select for library dependencies. How is the user
supposed to know that bzip2 and zlib needs to be enabled to even see
the matroska option.

 laird>  config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MONOSCOPE
 laird>  	bool "monoscope"
 laird> @@ -119,4 +120,25 @@
 laird>  	bool "wavparse (*.wav audio)"
 laird>  	default y
 
 laird> +comment "plugins with external dependencies (more to come)"
 laird> +

What is this comment supposed to mean? That these things don't build
right now?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-01-21 13:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 13:33 [Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good laird at uclibc.org
2009-01-21 13:40 ` Peter Korsgaard [this message]
2009-01-21 15:56   ` Daniel Laird
2009-01-22  9:16     ` Markus Heidelberg
2009-01-22  9:20       ` Daniel James Laird
2009-01-22  9:32         ` Markus Heidelberg
2009-01-22  9:44           ` Markus Heidelberg
2009-01-22  9:09 ` Markus Heidelberg
2009-01-22  9:13   ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2009-01-22  8:09 laird at uclibc.org
2009-01-22 11:01 laird at uclibc.org
2009-01-22 21:17 ` Markus Heidelberg
2009-01-23  9:18   ` Peter Korsgaard
2009-01-23 10:39 laird at uclibc.org
2009-02-25 19:51 jacmet at uclibc.org
2009-02-26  8:05 jacmet at uclibc.org
2009-02-26  8:05 jacmet at uclibc.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocy0srp9.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox