[Buildroot] [pull-request] A few fixes on gstreamer

[Buildroot] [pull-request] A few fixes on gstreamer

[llandwerlin at gmail.com]

This branch brings a couple of fixes about gstreamer. I realized
recently that GstParse needed flex/bison tools. And yesterday someone
reported (on IRC...) a problem about the impossibility to construct a
very simple gst pipeline (gst-launch fakesrc ! fakesink).

available at:
           git://git.potipota.net/buildroot gstreamer-fixes

Regards,

--
Lionel Landwerlin

[Buildroot] [PATCH 1/4] bison: added host rules

[llandwerlin at gmail.com]

From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/bison/bison.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/bison/bison.mk b/package/bison/bison.mk
index 9e28e85..a411d10 100644
--- a/package/bison/bison.mk
+++ b/package/bison/bison.mk
@@ -14,3 +14,4 @@ endef
 BISON_POST_CONFIGURE_HOOKS += BISON_DISABLE_EXAMPLES
 
 $(eval $(call AUTOTARGETS,package,bison))
+$(eval $(call AUTOTARGETS,package,bison,host))
-- 
1.7.1

[Buildroot] [PATCH 2/4] gstreamer: Added host-flex and host-bison dependencies

[llandwerlin at gmail.com]

From: Lionel Landwerlin <llandwerlin@gmail.com>

As stated by config.log from gstreamer :

configure:17368: found /home/djdeath/src/buildroot/buildroot_rebase/canmore/host/usr/bin/bison
configure:17381: result: /home/djdeath/src/buildroot/buildroot_rebase/canmore/host/usr/bin/bison
configure:17397: checking bison version 2.3 >= 1.875
configure:17401: result: yes
configure:17412: checking for flex
configure:17430: found /home/djdeath/src/buildroot/buildroot_rebase/canmore/host/usr/bin/flex
configure:17443: result: /home/djdeath/src/buildroot/buildroot_rebase/canmore/host/usr/bin/flex
configure:17459: checking flex version 2.5.35 >= 2.5.31
configure:17473: result: yes

Flex and Bison are required to build GstParse (used to parse gst-launch command line arguments).

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/multimedia/gstreamer/gstreamer.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/multimedia/gstreamer/gstreamer.mk b/package/multimedia/gstreamer/gstreamer.mk
index 0391b14..226a4ef 100644
--- a/package/multimedia/gstreamer/gstreamer.mk
+++ b/package/multimedia/gstreamer/gstreamer.mk
@@ -21,7 +21,7 @@ GSTREAMER_CONF_OPT = \
 		--disable-tests \
 		--disable-failing-tests
 
-GSTREAMER_DEPENDENCIES = libglib2 host-pkg-config
+GSTREAMER_DEPENDENCIES = libglib2 host-pkg-config host-flex host-bison
 
 ifeq ($(BR2_PACKAGE_GSTREAMER_LIBXML2),y)
 GSTREAMER_DEPENDENCIES += libxml2
-- 
1.7.1

[Buildroot] [PATCH 3/4] gstreamer: drop BR2_USE_WCHAR dependency (already required by libglib2)

[llandwerlin at gmail.com]

From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/multimedia/gstreamer/Config.in |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/package/multimedia/gstreamer/Config.in b/package/multimedia/gstreamer/Config.in
index a3ce859..43c3d90 100644
--- a/package/multimedia/gstreamer/Config.in
+++ b/package/multimedia/gstreamer/Config.in
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_GSTREAMER
 	bool "gstreamer"
-	depends on BR2_USE_WCHAR # glib2
 	select BR2_PACKAGE_LIBGLIB2
 	help
 	  GStreamer is an open source multimedia framework.
-- 
1.7.1

[Buildroot] [PATCH 4/4] gstreamer: remove --disable-registry from configure options

[llandwerlin at gmail.com]

From: Lionel Landwerlin <llandwerlin@gmail.com>

--disable-registry has no dependency on libxml2 and should not be
linked to BR2_PACKAGE_GSTREAMER_LIBXML2. If we want to disable
registry then we should add another option.

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/multimedia/gstreamer/gstreamer.mk |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/package/multimedia/gstreamer/gstreamer.mk b/package/multimedia/gstreamer/gstreamer.mk
index 226a4ef..17c72fe 100644
--- a/package/multimedia/gstreamer/gstreamer.mk
+++ b/package/multimedia/gstreamer/gstreamer.mk
@@ -27,7 +27,6 @@ ifeq ($(BR2_PACKAGE_GSTREAMER_LIBXML2),y)
 GSTREAMER_DEPENDENCIES += libxml2
 else
 GSTREAMER_CONF_OPT += \
-	--disable-registry \
 	--disable-loadsave
 endif
 
-- 
1.7.1

[Buildroot] [PATCH 3/4] gstreamer: drop BR2_USE_WCHAR dependency (already required by libglib2)

[Thomas Petazzoni]

On Sat,  5 Jun 2010 20:03:49 +0200
llandwerlin at gmail.com wrote:

> -	depends on BR2_USE_WCHAR # glib2

Why ? All packages that depend on libglib2 and therefore on gettext
should depend on BR2_USE_WCHAR. See
b730010c90a127746bada3d537eb0e204cba5988.

Is this dependency causing any problems ?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/4] bison: added host rules

[Thomas Petazzoni]

On Sat,  5 Jun 2010 20:03:47 +0200
llandwerlin at gmail.com wrote:

> From: Lionel Landwerlin <llandwerlin@gmail.com>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2/4] gstreamer: Added host-flex and host-bison dependencies

[Thomas Petazzoni]

On Sat,  5 Jun 2010 20:03:48 +0200
llandwerlin at gmail.com wrote:

> +GSTREAMER_DEPENDENCIES = libglib2 host-pkg-config host-flex host-bison

This isn't necessary: toolchain/dependencies/dependencies.sh already
checks that the host has flex and bison installed.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/4] bison: added host rules

[Thomas Petazzoni]

On Sat, 5 Jun 2010 21:32:19 +0200
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Sorry, in fact, no. bison and flex are supposed to be installed on the
developer machine, as checked by toolchain/dependencies/dependencies.sh.

Therefore, for coherency, we should:

 * Remove the host-flex package;

 * Remove all the dependencies on host-flex (gob2, ipsec-tools, radvd,
   webkit)

Unless of course we decide not to have bison/flex as host requirements,
or if we need them for some reason (like building the package/config
lexer + parser), and still want to build our own versions for the
general case (so that we know which flex/bison versions are being used,
providing more guarantees over build success).

Whichever the decision is, it requires discussion.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 3/4] gstreamer: drop BR2_USE_WCHAR dependency (already required by libglib2)

[Lionel Landwerlin]

Le samedi 05 juin 2010 ? 21:31 +0200, Thomas Petazzoni a ?crit :
> On Sat,  5 Jun 2010 20:03:49 +0200
> llandwerlin at gmail.com wrote:
> 
> > -	depends on BR2_USE_WCHAR # glib2
> 
> Why ? All packages that depend on libglib2 and therefore on gettext
> should depend on BR2_USE_WCHAR. See
> b730010c90a127746bada3d537eb0e204cba5988.
> 
> Is this dependency causing any problems ?
> 
> Thomas

Hi Thomas,

I don't understand why gstreamer should depend on BR2_USE_WCHAR and
BR2_PACKAGE_LIBGLIB2 if libglib2 already depends on BR2_USE_WCHAR.
It sounds like a repetition to me, isn't it ?

Regards,

-- 
Lionel Landwerlin

[Buildroot] [PATCH 3/4] gstreamer: drop BR2_USE_WCHAR dependency (already required by libglib2)

[Peter Korsgaard]

>>>>> "Lionel" == Lionel Landwerlin <llandwerlin@gmail.com> writes:

Hi,

 >> > -	depends on BR2_USE_WCHAR # glib2
 >> 
 >> Why ? All packages that depend on libglib2 and therefore on gettext
 >> should depend on BR2_USE_WCHAR. See
 >> b730010c90a127746bada3d537eb0e204cba5988.
 >> 
 >> Is this dependency causing any problems ?
 >> 
 >> Thomas

 Lionel> Hi Thomas,

 Lionel> I don't understand why gstreamer should depend on BR2_USE_WCHAR and
 Lionel> BR2_PACKAGE_LIBGLIB2 if libglib2 already depends on BR2_USE_WCHAR.
 Lionel> It sounds like a repetition to me, isn't it ?

The problem is that gstreamer selects libglib2, it doesn't depend on it
- And select ignores dependencies (E.G. you can enable gstreamer in
menuconfig even if you haven't enabled wchar in the toolchain, because
kconfig doesn't check the dependencies of the things that gets
'select'-ed.

So nack.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 4/4] gstreamer: remove --disable-registry from configure options

[Peter Korsgaard]

>>>>> "llandwerlin" == llandwerlin  <llandwerlin@gmail.com> writes:

 llandwerlin> From: Lionel Landwerlin <llandwerlin@gmail.com>
 llandwerlin> --disable-registry has no dependency on libxml2 and should not be
 llandwerlin> linked to BR2_PACKAGE_GSTREAMER_LIBXML2. If we want to disable
 llandwerlin> registry then we should add another option.

Committed, thanks.

-- 
Bye, Peter Korsgaard