Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] RFC: package patching
Date: Tue, 15 Nov 2011 22:28:19 +0100	[thread overview]
Message-ID: <20111115222819.4dd46e3b@skate> (raw)
In-Reply-To: <201111151914.38517.arnout@mind.be>

Le Tue, 15 Nov 2011 19:14:38 +0000,
Arnout Vandecappelle <arnout@mind.be> a ?crit :

> > Yes, I know - We hit this with E.G. busybox in the past. I would go
> > for the versioned-patches-in-subdir, as we (luckily) only support
> > multiple versions for a limited number of packages.
> 
>  While we're at it, I would also make it policy to not include the
> version number in the patch, except for packages with multiple active
> versions.  Now, when you're upgrading a package, you also have to do
> a lot of renames of patches.

I agree with both Thomas and Arnout. Thomas is right on the fact that
we should clarify the patching logic in the package infrastructure, but
this clarification should also come together with a clarification of
the best practices for storing patches for packages.

As Arnout suggests, I think that most packages should just have patches
whose filename do not contain the version. Only packages that support
multiple versions would have subdirectories.

At the same time, we should also probably generalize the usage of patch
numbering, in order to have a clear order of the patches. I.e,
something such as:

	foobar-0001-something.patch
	foobar-0002-somethingelse.patch

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2011-11-15 21:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15  8:33 [Buildroot] RFC: package patching Thomas De Schampheleire
2011-11-15  8:45 ` Peter Korsgaard
2011-11-15 19:14   ` Arnout Vandecappelle
2011-11-15 21:28     ` Thomas Petazzoni [this message]
2011-11-16  6:18       ` Sergey Naumov
2011-11-16  6:50         ` Thomas De Schampheleire
2011-11-16  6:44       ` Thomas De Schampheleire
2011-11-16 18:03         ` Thomas Petazzoni
2011-11-17 13:05           ` Thomas De Schampheleire
2011-11-17 21:23             ` Arnout Vandecappelle
2011-11-17 21:42               ` Thomas Petazzoni
2011-11-18  6:53                 ` Thomas De Schampheleire
2011-11-18  7:05                   ` Thomas Petazzoni
2011-11-18  7:34                     ` Peter Korsgaard
2011-11-18  9:26                       ` Thomas De Schampheleire
2011-11-18 12:24                   ` Michael S. Zick
2011-11-18 19:44                   ` Arnout Vandecappelle
2011-11-18 19:27                 ` Arnout Vandecappelle
2011-11-19  9:26                   ` Bjørn Forsman
2011-11-19 12:13                     ` Arnout Vandecappelle
2011-11-18 16:41             ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111115222819.4dd46e3b@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox