From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] RFC: package patching
Date: Wed, 16 Nov 2011 19:03:06 +0100 [thread overview]
Message-ID: <20111116190306.6e9596a0@skate> (raw)
In-Reply-To: <CAAXf6LVgWfk4SeocyimX6qZXLjB5sBhj3i+igAOenBEF9v1t3Q@mail.gmail.com>
Le Wed, 16 Nov 2011 07:44:54 +0100,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :
> > As Arnout suggests, I think that most packages should just have
> > patches whose filename do not contain the version. Only packages
> > that support multiple versions would have subdirectories.
>
> I'm not sure if this is so black-and-white. If a patch backports a
> change from 1.2.3 to 1.2.2, then IMO the patch should really be named
> 1.2.2, even if only 1.2.2 is present in Buildroot. If it is named
> without version, then it will also be taken along when bumping the
> package (and possibly but not necessarily cause a patch conflict).
> Only in cases were the change made by the patch is generic and not
> intended for a specific version, should we remove the version from the
> patch name.
A generic patch doesn't exist, a patch is *always* for a specific
version of a source tree. The fact that it might apply on multiple
versions of a given package is just pure luck. Therefore, I don't see
where the distinction between "generic patch" and a "version-specific"
patch is.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-11-16 18:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 8:33 [Buildroot] RFC: package patching Thomas De Schampheleire
2011-11-15 8:45 ` Peter Korsgaard
2011-11-15 19:14 ` Arnout Vandecappelle
2011-11-15 21:28 ` Thomas Petazzoni
2011-11-16 6:18 ` Sergey Naumov
2011-11-16 6:50 ` Thomas De Schampheleire
2011-11-16 6:44 ` Thomas De Schampheleire
2011-11-16 18:03 ` Thomas Petazzoni [this message]
2011-11-17 13:05 ` Thomas De Schampheleire
2011-11-17 21:23 ` Arnout Vandecappelle
2011-11-17 21:42 ` Thomas Petazzoni
2011-11-18 6:53 ` Thomas De Schampheleire
2011-11-18 7:05 ` Thomas Petazzoni
2011-11-18 7:34 ` Peter Korsgaard
2011-11-18 9:26 ` Thomas De Schampheleire
2011-11-18 12:24 ` Michael S. Zick
2011-11-18 19:44 ` Arnout Vandecappelle
2011-11-18 19:27 ` Arnout Vandecappelle
2011-11-19 9:26 ` Bjørn Forsman
2011-11-19 12:13 ` Arnout Vandecappelle
2011-11-18 16:41 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116190306.6e9596a0@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox