[Buildroot] [PATCH 1/1] New Package libmbus library for communicating with M-bus devices.(rework)

[Buildroot] [PATCH 1/1] New Package libmbus library for communicating with M-bus devices.(rework)

[Sagaert Johan]

---
 package/Config.in          |    1 +
 package/libmbus/Config.in  |    8 ++++++++
 package/libmbus/libmbus.mk |   15 +++++++++++++++
 3 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 package/libmbus/Config.in
 create mode 100644 package/libmbus/libmbus.mk

diff --git a/package/Config.in b/package/Config.in
index e949649..8f0b5ba 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -330,6 +330,7 @@ source "package/libmicrohttpd/Config.in"
 source "package/neon/Config.in"
 source "package/libmnl/Config.in"
 source "package/libmodbus/Config.in"
+source "package/libmbus/Config.in"
 source "package/libnl/Config.in"
 source "package/libpcap/Config.in"
 source "package/libosip2/Config.in"
diff --git a/package/libmbus/Config.in b/package/libmbus/Config.in
new file mode 100644
index 0000000..0f71ec5
--- /dev/null
+++ b/package/libmbus/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBMBUS
+	bool "libmbus"
+	help
+	  libmbus is a library for communicating with energy metering devices.
+	  It supports TCP and RS232 M-bus gateways.
+	  ( M-bus standard : http://www.m-bus.com/ )
+	  
+	  http://www.freescada.com/libmbus
diff --git a/package/libmbus/libmbus.mk b/package/libmbus/libmbus.mk
new file mode 100644
index 0000000..d9915ea
--- /dev/null
+++ b/package/libmbus/libmbus.mk
@@ -0,0 +1,15 @@
+#############################################################
+#
+# libmbus
+#
+#############################################################
+LIBMBUS_VERSION:=0.6.1
+LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz
+LIBMBUS_SITE:=http://www.freescada.com/public-dist/
+LIBMBUS_INSTALL_STAGING=YES
+
+# Without this the build yields an error:
+#   cannot find input file: `test/Makefile.in'
+LIBMBUS_AUTORECONF=YES
+
+$(eval $(call AUTOTARGETS))
-- 
1.7.8

[Buildroot] [PATCH 1/1] New Package libmbus library for communicating with M-bus devices.(rework)

[Thomas Petazzoni]

Hello,

You forgot your Signed-off-by line, which is mandatory.

Le Sat, 10 Dec 2011 01:48:00 +0100,
Sagaert Johan <sagaert.johan@skynet.be> a ?crit :

> +++ b/package/libmbus/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_LIBMBUS
> +	bool "libmbus"
> +	help
> +	  libmbus is a library for communicating with energy metering devices.
> +	  It supports TCP and RS232 M-bus gateways.
> +	  ( M-bus standard : http://www.m-bus.com/ )

Remove space after ( and before ).

> +LIBMBUS_VERSION:=0.6.1

= instead of :=

> +LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz

Not needed, that's the default.

> +LIBMBUS_SITE:=http://www.freescada.com/public-dist/

= instead of :=

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/1] New Package libmbus library for communicating with M-bus devices.(rework)

[Thomas Petazzoni]

Hello Johan,

Please keep the Buildroot list Cc'ed.

Le Sat, 10 Dec 2011 18:26:31 +0100,
"Sagaert Johan" <sagaert.johan@skynet.be> a ?crit :

> Yes, i just saw it, I started using git only since last week, and I used
>  --signed-off instead of --signoff. Still need to learn a lot and do some
> tuning in the .gitconfig file. Will create some script so I don't forget any
> mandatory options.

No problem. Don't worry if everything is not perfect the first time:
that's why we have code review. Even experienced developers don't
always get everything right.

> One more question: is it OK to comment in the xxx.mk files ?
> (I have a libcgi patch and i included a comment line why I added the
> AUTORECONF option.) 

Yes, it is perfectly ok, and even better, in your case, I think it was
a very good idea. Having _AUTORECONF=YES is strange when no patch is
changing the configure.ac or Makefile.in files, so having a short
comment justifying the usage of _AUTORECONF=YES is welcome.

> I use qgit and smartgit gui-clients, do you suggest something better ?)

I do all my git stuff using the git command line utility, and I've
never tried any of the graphical stuff for git (except gitk for pure
visualization of git history).

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com