[Buildroot] [git commit] boot: only show vendor-specific bootloaders for applicable arm variant

[Buildroot] [git commit] boot: only show vendor-specific bootloaders for applicable arm variant

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=a18e5eb09b7817986a365ba701259454ac51a80a
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Atmel at91sam9 and NXP lpc32xx are both all arm926t, so only show
then if that arm variant is selected.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 boot/at91bootstrap/Config.in     |    2 +-
 boot/at91dataflashboot/Config.in |    2 +-
 boot/lpc32xxcdl/Config.in        |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/boot/at91bootstrap/Config.in b/boot/at91bootstrap/Config.in
index ff968cd..b232b3b 100644
--- a/boot/at91bootstrap/Config.in
+++ b/boot/at91bootstrap/Config.in
@@ -1,5 +1,5 @@
 config BR2_TARGET_AT91BOOTSTRAP
-	depends on BR2_arm
+	depends on BR2_arm926t
 	bool "AT91 Bootstrap"
 	help
 	  AT91Bootstrap is a first level bootloader for the Atmel AT91
diff --git a/boot/at91dataflashboot/Config.in b/boot/at91dataflashboot/Config.in
index a4efe11..7537548 100644
--- a/boot/at91dataflashboot/Config.in
+++ b/boot/at91dataflashboot/Config.in
@@ -1,3 +1,3 @@
 config BR2_TARGET_AT91DATAFLASHBOOT
-       depends on BR2_arm
+       depends on BR2_arm926t
        bool "AT91 DataFlashBoot"
diff --git a/boot/lpc32xxcdl/Config.in b/boot/lpc32xxcdl/Config.in
index b6cbcfd..ce7589c 100644
--- a/boot/lpc32xxcdl/Config.in
+++ b/boot/lpc32xxcdl/Config.in
@@ -1,5 +1,5 @@
 config BR2_TARGET_LPC32XXCDL
-	depends on BR2_arm
+	depends on BR2_arm926t
 	bool "LPC32XX CDL (kickstart and S1L)"
 
 if BR2_TARGET_LPC32XXCDL

[Buildroot] [git commit] boot: only show vendor-specific bootloaders for applicable arm variant

[Thomas Petazzoni]

Hello,

Le Wed, 1 Feb 2012 23:46:48 +0100,
Peter Korsgaard <jacmet@sunsite.dk> a ?crit :

> Atmel at91sam9 and NXP lpc32xx are both all arm926t, so only show
> then if that arm variant is selected.

Technically this is correct, but I am pretty sure a lot of people keep
the default "generic_arm" and therefore would not see the availability
of AT91Bootstrap or the LPC bootloaders.

For example, if you use a CodeSourcery external toolchain, there is
basically no difference between generic_arm and arm926t, because the
toolchain already defaults to armv5t.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] boot: only show vendor-specific bootloaders for applicable arm variant

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 >> Atmel at91sam9 and NXP lpc32xx are both all arm926t, so only show
 >> then if that arm variant is selected.

 Thomas> Technically this is correct, but I am pretty sure a lot of
 Thomas> people keep the default "generic_arm" and therefore would not
 Thomas> see the availability of AT91Bootstrap or the LPC bootloaders.

 Thomas> For example, if you use a CodeSourcery external toolchain,
 Thomas> there is basically no difference between generic_arm and
 Thomas> arm926t, because the toolchain already defaults to armv5t.

True. Is that a common use case? If so then I'll revert.

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] boot: only show vendor-specific bootloaders for applicable arm variant

[Thomas Petazzoni]

Le Thu, 02 Feb 2012 16:56:25 +0100,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :

> True. Is that a common use case? If so then I'll revert.

I don't know if it's a common use case. But I would suspect that many
newcomers do not necessarily select the right sub-architecture. But I
don't have a strong opinion with your regard to your patch. I just
think that people may not discover that those bootloaders are available
in Buildroot.

However, as discussed on IRC, we might see an increase of
platform-specific packages (3D drivers and libraries, codecs and DSP
stuff, etc.), so maybe we'll need some way of selecting the platform in
order to show only the relevant packages? Or maybe simply by organizing
the packages like:

 Platform specific packages ->
  Texas Instruments OMAP packages ->
  Freescale i.MX packages ->
  ...

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] boot: only show vendor-specific bootloaders for applicable arm variant

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Le Thu, 02 Feb 2012 16:56:25 +0100,
 Thomas> Peter Korsgaard <jacmet@uclibc.org> a ?crit :

 >> True. Is that a common use case? If so then I'll revert.

 Thomas> I don't know if it's a common use case. But I would suspect that many
 Thomas> newcomers do not necessarily select the right sub-architecture. But I
 Thomas> don't have a strong opinion with your regard to your patch. I just
 Thomas> think that people may not discover that those bootloaders are available
 Thomas> in Buildroot.

If that's the case, then we have the same problems with SoC specific
packages like gst-dsp or armv7 only things like valgrind.

 Thomas> However, as discussed on IRC, we might see an increase of
 Thomas> platform-specific packages (3D drivers and libraries, codecs
 Thomas> and DSP stuff, etc.), so maybe we'll need some way of selecting
 Thomas> the platform in order to show only the relevant packages? Or
 Thomas> maybe simply by organizing the packages like:

 Thomas>  Platform specific packages ->
 Thomas>   Texas Instruments OMAP packages ->
 Thomas>   Freescale i.MX packages ->
 Thomas>   ...

Yes, I guess something like that is needed. We should make sure we don't
make it too complicated though.

-- 
Bye, Peter Korsgaard