[Buildroot] [PATCH 0/3] Add CONF_ENABLE and CONF_PKG_ENABLE helper functions

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello Arnout,

Le Sat, 28 Apr 2012 23:16:18 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :

>  Many packages have the following type of construct:
> 
> ifeq ($(BR2_PACKAGE_ACL),y)
>        SYSTEMD_CONF_OPT += --enable-acl
>        SYSTEMD_DEPENDENCIES += acl
> else
>        SYSTEMD_CONF_OPT += --disable-acl
> endif
> 
>  The first patch in this series abbreviates that to
> 
> $(eval $(call CONF_PKG_ENABLE,SYSTEMD,acl))
> 
>  It makes it possible to abbreviate similar constructs as well.

Thanks for working on this and making a proposal.

However, on my side, I am not yet convinced that this is actually
making things better than what we have now. What we have now is quite
obvious for the first-time reader, which is very good. Those
CONF_PKG_ENABLE and CONF_ENABLE macros make things a bit too cryptic
from my point of view. This is not an absolutely strong opinion, but I
have the feeling this is on the "we want to make things smaller/shorter
and end up making things cryptic" side of the trade-off. Of course,
others have to comment to share their views on this.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com