Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/3] Add CONF_ENABLE and CONF_PKG_ENABLE helper functions
Date: Wed, 09 May 2012 11:35:08 +0200	[thread overview]
Message-ID: <87txzpwvcj.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <CAAXf6LVpk6NEbnC9pBono-H9wXj9OBdEhttD2N-s5mbPHJs_7A@mail.gmail.com> (Thomas De Schampheleire's message of "Wed, 9 May 2012 10:06:20 +0200")

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:

Hi,

 >> Thanks for working on this and making a proposal.
 >> 
 >> However, on my side, I am not yet convinced that this is actually
 >> making things better than what we have now. What we have now is quite
 >> obvious for the first-time reader, which is very good. Those
 >> CONF_PKG_ENABLE and CONF_ENABLE macros make things a bit too cryptic
 >> from my point of view. This is not an absolutely strong opinion, but I
 >> have the feeling this is on the "we want to make things smaller/shorter
 >> and end up making things cryptic" side of the trade-off. Of course,
 >> others have to comment to share their views on this.

 Thomas> I tend to agree with Thomas that it makes things less obvious
 Thomas> for regular users. The relation between such a CONF_PKG_ENABLE
 Thomas> statement and the corresponding options passed to the configure
 Thomas> script is not apparent, which confuses people.

I must say I agree.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-05-09  9:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-28 21:16 [Buildroot] [PATCH 0/3] Add CONF_ENABLE and CONF_PKG_ENABLE helper functions Arnout Vandecappelle
2012-04-28 21:16 ` [Buildroot] [PATCH 1/3] pkg-infra: add " Arnout Vandecappelle
2012-04-28 21:16 ` [Buildroot] [PATCH 2/3] avahi: use CONF_ENABLE and CONF_PKG_ENABLE Arnout Vandecappelle
2012-04-28 21:16 ` [Buildroot] [PATCH 3/3] cairo: " Arnout Vandecappelle
2012-05-07 14:21 ` [Buildroot] [PATCH 0/3] Add CONF_ENABLE and CONF_PKG_ENABLE helper functions Thomas Petazzoni
2012-05-09  8:06   ` Thomas De Schampheleire
2012-05-09  9:35     ` Peter Korsgaard [this message]
2012-05-11 22:29   ` Arnout Vandecappelle
2012-05-12  9:03     ` Samuel Martin
2012-05-12 11:42       ` Thomas Petazzoni
2012-05-12 11:05     ` Thomas Petazzoni
2012-05-12 14:47       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txzpwvcj.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox