[Buildroot] [PATCH] sysprof: New package.

[Buildroot] [PATCH] sysprof: New package.

[Will Newton]

Signed-off-by: Will Newton <will.newton@imgtec.com>
---
 package/Config.in          |    1 +
 package/sysprof/Config.in  |   21 +++++++++++++++++++++
 package/sysprof/sysprof.mk |   15 +++++++++++++++
 3 files changed, 37 insertions(+), 0 deletions(-)
 create mode 100644 package/sysprof/Config.in
 create mode 100644 package/sysprof/sysprof.mk

diff --git a/package/Config.in b/package/Config.in
index 4ac02c8..f97ca16 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -39,6 +39,7 @@ source "package/ramspeed/Config.in"
 source "package/rt-tests/Config.in"
 source "package/strace/Config.in"
 source "package/stress/Config.in"
+source "package/sysprof/Config.in"
 source "package/whetstone/Config.in"
 source "package/valgrind/Config.in"
 source "package/pv/Config.in"
diff --git a/package/sysprof/Config.in b/package/sysprof/Config.in
new file mode 100644
index 0000000..bd71728
--- /dev/null
+++ b/package/sysprof/Config.in
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_SYSPROF
+	bool "sysprof"
+	select BR2_PACKAGE_LIBGLIB2
+	depends on BR2_USE_WCHAR # glib2
+	help
+	  Sysprof is a statistical, system-wide profiler that can
+	  profile user and kernel code using the perf API.
+
+	  http://sysprof.com
+
+config BR2_PACKAGE_SYSPROF_GUI
+	bool "sysprof GUI"
+	depends on BR2_PACKAGE_SYSPROF
+	depends on BR2_PACKAGE_LIBGTK2
+	select BR2_PACKAGE_LIBGLADE
+	select BR2_PACKAGE_GDK_PIXBUF
+	help
+	  GUI for the sysprof system-wide statistical profiler.
+
+comment "sysprof requires a toolchain with WCHAR support"
+        depends on !BR2_USE_WCHAR
diff --git a/package/sysprof/sysprof.mk b/package/sysprof/sysprof.mk
new file mode 100644
index 0000000..c7dd8ca
--- /dev/null
+++ b/package/sysprof/sysprof.mk
@@ -0,0 +1,15 @@
+#############################################################
+#
+# sysprof
+#
+#############################################################
+
+SYSPROF_VERSION = 1.1.8
+SYSPROF_SITE = http://sysprof.com
+SYSPROF_DEPENDENCIES = libglib2
+
+ifeq ($(BR2_PACKAGE_SYSPROF_GUI),y)
+SYSPROF_DEPENDENCIES += libgtk2 libglade gdk-pixbuf
+endif
+
+$(eval $(call AUTOTARGETS))
-- 
1.7.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sysprof-New-package.patch
Type: application/octet-stream
Size: 2300 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120727/d2e568fa/attachment.obj>

[Buildroot] [PATCH] sysprof: New package.

[Thomas Petazzoni]

Le Fri, 27 Jul 2012 16:26:23 +0100,
Will Newton <will.newton@gmail.com> a ?crit :

> Signed-off-by: Will Newton <will.newton@imgtec.com>

Applied, thanks. I did some changes to the package, though:

     - add dependencies on the supported architectures to avoid build
       failures on ARM and other unsupported arches
     - add a patch that removes an useless warning about the kernel
       version. This patch is present upstream. However since it
       modifies configure.ac, we need to autoreconf the package.
     - change AUTOTARGETS to autotools-package

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] sysprof: New package.

[Thomas Petazzoni]

Hello Will,

Le Mon, 30 Jul 2012 23:58:30 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :

> Le Fri, 27 Jul 2012 16:26:23 +0100,
> Will Newton <will.newton@gmail.com> a ?crit :
> 
> > Signed-off-by: Will Newton <will.newton@imgtec.com>
> 
> Applied, thanks. I did some changes to the package, though:
> 
>      - add dependencies on the supported architectures to avoid build
>        failures on ARM and other unsupported arches
>      - add a patch that removes an useless warning about the kernel
>        version. This patch is present upstream. However since it
>        modifies configure.ac, we need to autoreconf the package.
>      - change AUTOTARGETS to autotools-package

Unfortunately, the sysprof package has a number of build problems on
x86 and ppc. See:

http://autobuild.buildroot.org/results/60728435af0221548c817cc8771674cc088e4d10/build-end.log
http://autobuild.buildroot.org/results/2d0ce96b30d32992d8f55f3a5974a81bbdb88915/build-end.log

It has been causing quite a few build failures since I merged the
package, so it would be good to fix those.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] sysprof: New package.

[Will Newton]

On Tue, Jul 31, 2012 at 10:04 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:

Hi Thomas,

> Hello Will,
>
> Le Mon, 30 Jul 2012 23:58:30 +0200,
> Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :
>
>> Le Fri, 27 Jul 2012 16:26:23 +0100,
>> Will Newton <will.newton@gmail.com> a ?crit :
>>
>> > Signed-off-by: Will Newton <will.newton@imgtec.com>
>>
>> Applied, thanks. I did some changes to the package, though:
>>
>>      - add dependencies on the supported architectures to avoid build
>>        failures on ARM and other unsupported arches
>>      - add a patch that removes an useless warning about the kernel
>>        version. This patch is present upstream. However since it
>>        modifies configure.ac, we need to autoreconf the package.
>>      - change AUTOTARGETS to autotools-package
>
> Unfortunately, the sysprof package has a number of build problems on
> x86 and ppc. See:
>
> http://autobuild.buildroot.org/results/60728435af0221548c817cc8771674cc088e4d10/build-end.log
> http://autobuild.buildroot.org/results/2d0ce96b30d32992d8f55f3a5974a81bbdb88915/build-end.log
>
> It has been causing quite a few build failures since I merged the
> package, so it would be good to fix those.

Would something like the below be acceptable? It's not very clean but
until uClibc supports this define I don't know if there is a better
alternative.


uClibc does not define NT_GNU_BUILD_ID like glibc, so add a
definition here until uClibc catches up.

Signed-off-by: Will Newton <will.newton@imgtec.com>
---
 package/sysprof/sysprof-02-uclibc-build-id.patch |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
 create mode 100644 package/sysprof/sysprof-02-uclibc-build-id.patch

diff --git a/package/sysprof/sysprof-02-uclibc-build-id.patch
b/package/sysprof/sysprof-02-uclibc-build-id.patch
new file mode 100644
index 0000000..932eba1
--- /dev/null
+++ b/package/sysprof/sysprof-02-uclibc-build-id.patch
@@ -0,0 +1,14 @@
+diff -u sysprof-1.1.8.old/elfparser.c sysprof-1.1.8/elfparser.c
+--- sysprof-1.1.8.old/elfparser.c	2012-07-23 15:32:14.076213706 +0100
++++ sysprof-1.1.8/elfparser.c	2012-07-23 15:33:49.092091443 +0100
+@@ -21,6 +21,10 @@
+ #include <sys/mman.h>
+ #include "elfparser.h"
+
++#ifndef NT_GNU_BUILD_ID
++#define NT_GNU_BUILD_ID 3
++#endif
++
+ typedef struct Section Section;
+
+ struct ElfSym
-- 
1.7.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sysprof-Add-patch-to-enable-building-with-uClibc.patch
Type: application/octet-stream
Size: 1220 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120731/91c5d1ef/attachment.obj>

[Buildroot] [PATCH] sysprof: New package.

[Thomas Petazzoni]

Le Tue, 31 Jul 2012 11:31:20 +0100,
Will Newton <will.newton@gmail.com> a ?crit :

> Would something like the below be acceptable? It's not very clean but
> until uClibc supports this define I don't know if there is a better
> alternative.

It's similar to
http://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-kernel/sysprof/files/define-NT_GNU_BUILD_ID.patch,
so I guess it's acceptable. The perf people are also doing the same
thing apparently.

Thanks, I will commit this!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] sysprof: New package.

[Thomas Petazzoni]

Le Tue, 31 Jul 2012 11:31:20 +0100,
Will Newton <will.newton@gmail.com> a ?crit :

> > It has been causing quite a few build failures since I merged the
> > package, so it would be good to fix those.
> 
> Would something like the below be acceptable? It's not very clean but
> until uClibc supports this define I don't know if there is a better
> alternative.

I've pushed your patch. It solves the build failure on x86, and removes
one error message from the PowerPC build, but the PowerPC build is still
failing:
http://autobuild.buildroot.org/results/a3ef351704317a9f3f3ab4ee3845bc1e61938c23/build-end.log.

It has caused ~5 build failures during the last night.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] sysprof: New package.

[Thomas Petazzoni]

Le Wed, 1 Aug 2012 10:03:05 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :

> I've pushed your patch. It solves the build failure on x86, and removes
> one error message from the PowerPC build, but the PowerPC build is still
> failing:
> http://autobuild.buildroot.org/results/a3ef351704317a9f3f3ab4ee3845bc1e61938c23/build-end.log.

I have pushed another patch (taken from upstream) that fixes this
problem, so no need to spend time on this one.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com