* [Buildroot] [git commit] qextserialport: don't require Qt GUI module
@ 2012-11-14 21:44 Peter Korsgaard
2012-11-15 23:54 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2012-11-14 21:44 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=bac970e99d751dd58561313a38311962ea0a79f1
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Fixes e.g.
http://autobuild.buildroot.net/results/e80ae76fa21f87bef10e08c7452b796dc0986ff2/
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
package/qextserialport/qextserialport-gui.patch | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/package/qextserialport/qextserialport-gui.patch b/package/qextserialport/qextserialport-gui.patch
new file mode 100644
index 0000000..d3dedae
--- /dev/null
+++ b/package/qextserialport/qextserialport-gui.patch
@@ -0,0 +1,16 @@
+Don't require Qt GUI module
+
+Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
+---
+diff -Nrup qextserialport-f83b4e7ca922e53.orig/qextserialport.pro qextserialport-f83b4e7ca922e53/qextserialport.pro
+--- qextserialport-f83b4e7ca922e53.orig/qextserialport.pro 2012-10-17 09:13:53.000000000 +0200
++++ qextserialport-f83b4e7ca922e53/qextserialport.pro 2012-11-13 22:48:29.249431510 +0100
+@@ -41,6 +41,8 @@ macx:qesp_mac_framework {
+
+ win32|mac:!wince*:!win32-msvc:!macx-xcode:CONFIG += debug_and_release build_all
+
++!win32*:!wince*:QT -= gui
++
+ #generate proper library name
+ greaterThan(QT_MAJOR_VERSION, 4) {
+ QESP_LIB_BASENAME = QtExtSerialPort
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [git commit] qextserialport: don't require Qt GUI module
2012-11-14 21:44 [Buildroot] [git commit] qextserialport: don't require Qt GUI module Peter Korsgaard
@ 2012-11-15 23:54 ` Arnout Vandecappelle
2012-11-16 6:26 ` Peter Korsgaard
2013-02-07 7:00 ` Arnout Vandecappelle
0 siblings, 2 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2012-11-15 23:54 UTC (permalink / raw)
To: buildroot
On 14/11/12 22:44, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=bac970e99d751dd58561313a38311962ea0a79f1
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Fixes e.g.
> http://autobuild.buildroot.net/results/e80ae76fa21f87bef10e08c7452b796dc0986ff2/
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
> Signed-off-by: Peter Korsgaard<jacmet@sunsite.dk>
> ---
> package/qextserialport/qextserialport-gui.patch | 16 ++++++++++++++++
> 1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/package/qextserialport/qextserialport-gui.patch b/package/qextserialport/qextserialport-gui.patch
> new file mode 100644
> index 0000000..d3dedae
> --- /dev/null
> +++ b/package/qextserialport/qextserialport-gui.patch
> @@ -0,0 +1,16 @@
> +Don't require Qt GUI module
> +
> +Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
> +---
> +diff -Nrup qextserialport-f83b4e7ca922e53.orig/qextserialport.pro qextserialport-f83b4e7ca922e53/qextserialport.pro
> +--- qextserialport-f83b4e7ca922e53.orig/qextserialport.pro 2012-10-17 09:13:53.000000000 +0200
> ++++ qextserialport-f83b4e7ca922e53/qextserialport.pro 2012-11-13 22:48:29.249431510 +0100
> +@@ -41,6 +41,8 @@ macx:qesp_mac_framework {
> +
> + win32|mac:!wince*:!win32-msvc:!macx-xcode:CONFIG += debug_and_release build_all
> +
> ++!win32*:!wince*:QT -= gui
> ++
> + #generate proper library name
> + greaterThan(QT_MAJOR_VERSION, 4) {
> + QESP_LIB_BASENAME = QtExtSerialPort
After submitting this patch upstream, the feedback I got is that it should
not be necessary to do this. Looking a bit deeper, it turns out they are
right, in a way. We use the qws mkspecs file, which includes
QT += core gui network
I.e., by default the gui will always be linked in, and -DQT_GUI_LIB will be added
to the compile flags. It seems logical that Qt would remove the ones that aren't
installed, but it doesn't. So we should do it ourselves.
While we're at it, we could also throw out our patching of the platform-specific
qws config file: we are anyway replacing all "interesting" variables with our own
values, so all useful content is thrown away. Instead, we could make our own spec
file that contains exactly what we need:
include(../../common/linux.conf)
include(../../common/gcc-base-unix.conf)
include(../../common/g++-unix.conf)
include(../../common/qws.conf)
<our stuff goes here>
load(qt_config)
What do you think?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [git commit] qextserialport: don't require Qt GUI module
2012-11-15 23:54 ` Arnout Vandecappelle
@ 2012-11-16 6:26 ` Peter Korsgaard
2012-11-16 7:44 ` Thomas Petazzoni
2013-02-07 7:00 ` Arnout Vandecappelle
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2012-11-16 6:26 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Arnout> While we're at it, we could also throw out our patching of the
Arnout> platform-specific qws config file: we are anyway replacing all
Arnout> "interesting" variables with our own values, so all useful
Arnout> content is thrown away. Instead, we could make our own spec
Arnout> file that contains exactly what we need:
Arnout> include(../../common/linux.conf)
Arnout> include(../../common/gcc-base-unix.conf)
Arnout> include(../../common/g++-unix.conf)
Arnout> include(../../common/qws.conf)
Arnout> <our stuff goes here>
Arnout> load(qt_config)
Arnout> What do you think?
I'm no Qt expert, but it sounds sensible - Thomas?
Presumably this is all post-2012.11 stuff?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [git commit] qextserialport: don't require Qt GUI module
2012-11-16 6:26 ` Peter Korsgaard
@ 2012-11-16 7:44 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2012-11-16 7:44 UTC (permalink / raw)
To: buildroot
On Fri, 16 Nov 2012 07:26:44 +0100, Peter Korsgaard wrote:
> >>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
>
> Arnout> While we're at it, we could also throw out our patching of the
> Arnout> platform-specific qws config file: we are anyway replacing all
> Arnout> "interesting" variables with our own values, so all useful
> Arnout> content is thrown away. Instead, we could make our own spec
> Arnout> file that contains exactly what we need:
>
> Arnout> include(../../common/linux.conf)
> Arnout> include(../../common/gcc-base-unix.conf)
> Arnout> include(../../common/g++-unix.conf)
> Arnout> include(../../common/qws.conf)
> Arnout> <our stuff goes here>
> Arnout> load(qt_config)
>
> Arnout> What do you think?
>
> I'm no Qt expert, but it sounds sensible - Thomas?
I don't remember all the details of those spec files, but yes, it
sounds good.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [git commit] qextserialport: don't require Qt GUI module
2012-11-15 23:54 ` Arnout Vandecappelle
2012-11-16 6:26 ` Peter Korsgaard
@ 2013-02-07 7:00 ` Arnout Vandecappelle
2013-02-07 8:24 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-02-07 7:00 UTC (permalink / raw)
To: buildroot
On 16/11/12 00:54, Arnout Vandecappelle wrote:
[snip]
>> +diff -Nrup qextserialport-f83b4e7ca922e53.orig/qextserialport.pro
>> qextserialport-f83b4e7ca922e53/qextserialport.pro
>> +--- qextserialport-f83b4e7ca922e53.orig/qextserialport.pro 2012-10-17 09:13:53.000000000 +0200
>> ++++ qextserialport-f83b4e7ca922e53/qextserialport.pro 2012-11-13 22:48:29.249431510 +0100
>> +@@ -41,6 +41,8 @@ macx:qesp_mac_framework {
>> +
>> + win32|mac:!wince*:!win32-msvc:!macx-xcode:CONFIG += debug_and_release
>> build_all
>> +
>> ++!win32*:!wince*:QT -= gui
>> ++
>> + #generate proper library name
>> + greaterThan(QT_MAJOR_VERSION, 4) {
>> + QESP_LIB_BASENAME = QtExtSerialPort
>
> After submitting this patch upstream, the feedback I got is that it should
> not be necessary to do this. Looking a bit deeper, it turns out they are
> right, in a way. We use the qws mkspecs file, which includes
> QT += core gui network
>
> I.e., by default the gui will always be linked in, and -DQT_GUI_LIB will be added
> to the compile flags. It seems logical that Qt would remove the ones that aren't
> installed, but it doesn't. So we should do it ourselves.
>
> While we're at it, we could also throw out our patching of the platform-specific
> qws config file: we are anyway replacing all "interesting" variables with our own
> values, so all useful content is thrown away. Instead, we could make our own spec
> file that contains exactly what we need:
>
> include(../../common/linux.conf)
> include(../../common/gcc-base-unix.conf)
> include(../../common/g++-unix.conf)
> include(../../common/qws.conf)
> <our stuff goes here>
> load(qt_config)
>
>
> What do you think?
Thomas,
Now that you're working on Qt5, maybe you can check with qt-project if
this is indeed the way to go?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [git commit] qextserialport: don't require Qt GUI module
2013-02-07 7:00 ` Arnout Vandecappelle
@ 2013-02-07 8:24 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2013-02-07 8:24 UTC (permalink / raw)
To: buildroot
Dear Arnout Vandecappelle,
On Thu, 07 Feb 2013 08:00:07 +0100, Arnout Vandecappelle wrote:
> > While we're at it, we could also throw out our patching of the
> > platform-specific qws config file: we are anyway replacing all
> > "interesting" variables with our own values, so all useful content
> > is thrown away. Instead, we could make our own spec file that
> > contains exactly what we need:
> >
> > include(../../common/linux.conf)
> > include(../../common/gcc-base-unix.conf)
> > include(../../common/g++-unix.conf)
> > include(../../common/qws.conf)
> > <our stuff goes here>
> > load(qt_config)
> >
> >
> > What do you think?
>
>
> Thomas,
>
> Now that you're working on Qt5, maybe you can check with qt-project
> if this is indeed the way to go?
I am not sure why you mean by "this", but in the Qt5 packaging, I do
add our own linux-buildroot-g++ configuration. See
http://git.free-electrons.com/users/thomas-petazzoni/buildroot/diff/package/qt5/qt5base/qt5base-mkspecs-files.patch?h=qt5&id=7c1f7b9967d814e3f5c838e7090ac04b9d06af51.
Is that what you meant?
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-07 8:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-14 21:44 [Buildroot] [git commit] qextserialport: don't require Qt GUI module Peter Korsgaard
2012-11-15 23:54 ` Arnout Vandecappelle
2012-11-16 6:26 ` Peter Korsgaard
2012-11-16 7:44 ` Thomas Petazzoni
2013-02-07 7:00 ` Arnout Vandecappelle
2013-02-07 8:24 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox