Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] directfb: expanding the help strings
Date: Sun, 10 Mar 2013 11:27:01 +0100	[thread overview]
Message-ID: <20130310112701.5ac2f9bc@skate> (raw)
In-Reply-To: <1362908858-6340-4-git-send-email-c.schoenert@gmail.com>

Dear Carsten Schoenert,

On Sun, 10 Mar 2013 10:47:37 +0100, Carsten Schoenert wrote:
> From: Carsten Schoenert <c.schoenert@gmail.com>
> 
> Adding a helper string for the PXA3xx and graphics driver from Marvell
> and the EP9x graphics driver from Cirrus Logic.
> 
> Signed-off-by: Carsten Schoenert <c.schoenert@gmail.com>
> ---
>  package/directfb/Config.in |   17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index a184568..3d22e15 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -49,10 +49,27 @@ config BR2_PACKAGE_DIRECTFB_MATROX
>  config BR2_PACKAGE_DIRECTFB_PXA3XX
>  	bool "compile pxa3xx graphics driver"
>  	depends on BR2_arm
> +    help
> +      The Marvell PXA3xx Processor Family is a system-on-chip based
> +      on XScale? microarchitecture. The PXA3xx processor provide
> +      high-performance multimedia, low-power capabilities, and rich
> +      peripheral integration. The PXA3xx Processor Family provide
> +      enhanced features compared to the PXA27x Processor Family, and
> +      are the first Marvell applications processors to integrate a
> +      hardware video accelerator unit.
> +
> +      http://www.marvell.com/application-processors/pxa-family/

Indentation is wrong. It should be one tab for "help" and one tab + two
spaces for the help text.

In addition to that, I'm not sure the wording of the help text is so
useful. Something like "This option enables a graphics driver specific
to the graphics hardware of the Marvell PXA3xx processor family", would
be a bit more useful.

>  config BR2_PACKAGE_DIRECTFB_EP9X
>  	bool "compile ep9x graphics driver"
>  	depends on BR2_arm
> +    help
> +      The EP93xx ARMv9 based processors from Cirrus Logic are highly
> +      integrated systems-on-a-chip that pave the way for a multitude
> +      of next-generation consumer and industrial electronic products.
> +
> +      http://cirrus.com/en/products/arm9.html

Same comments.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-03-10 10:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  9:47 [Buildroot] [PATCH 0/0] Updating directfb and divine Carsten Schoenert
2013-03-10  9:47 ` [Buildroot] [PATCH 1/4] directfb: bumping version to 1.6.3 Carsten Schoenert
2013-03-10 10:32   ` Thomas Petazzoni
2013-03-10 12:34     ` Carsten Schoenert
2013-03-17 13:59       ` Carsten Schoenert
2013-03-21  6:56         ` Arnout Vandecappelle
2013-03-21 18:06           ` Carsten Schoenert
2013-03-21 19:13             ` Thomas Petazzoni
2013-04-02 21:56               ` Carsten Schoenert
2013-03-10 16:50     ` Carsten Schoenert
2013-03-10 17:25       ` Thomas Petazzoni
2013-03-10  9:47 ` [Buildroot] [PATCH 2/4] divine: " Carsten Schoenert
2013-03-10  9:47 ` [Buildroot] [PATCH 3/4] directfb: expanding the help strings Carsten Schoenert
2013-03-10 10:27   ` Thomas Petazzoni [this message]
2013-03-10 12:21     ` Carsten Schoenert
2013-03-10 13:13       ` Thomas Petazzoni
2013-03-10  9:47 ` [Buildroot] [PATCH 4/4] directfb: fixing typo in variables Carsten Schoenert
2013-03-10 10:25   ` Thomas Petazzoni
2013-03-10 12:23     ` Carsten Schoenert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130310112701.5ac2f9bc@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox