Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Carsten Schoenert <c.schoenert@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] directfb: expanding the help strings
Date: Sun, 10 Mar 2013 13:21:06 +0100	[thread overview]
Message-ID: <513C7AB2.3080000@googlemail.com> (raw)
In-Reply-To: <20130310112701.5ac2f9bc@skate>

Hello Thomas,

Am 10.03.2013 11:27, schrieb Thomas Petazzoni:
>> +    help
>> +      The Marvell PXA3xx Processor Family is a system-on-chip based
>> +      on XScale? microarchitecture. The PXA3xx processor provide
>> +      high-performance multimedia, low-power capabilities, and rich
>> +      peripheral integration. The PXA3xx Processor Family provide
>> +      enhanced features compared to the PXA27x Processor Family, and
>> +      are the first Marvell applications processors to integrate a
>> +      hardware video accelerator unit.
>> +
>> +      http://www.marvell.com/application-processors/pxa-family/
> 
> Indentation is wrong. It should be one tab for "help" and one tab + two
> spaces for the help text.

Hmm, I have to check my vim settings, sorry.
What about modlines in thees files? This would be helpful and it's just
a one-liner on top of this files.

> In addition to that, I'm not sure the wording of the help text is so
> useful. Something like "This option enables a graphics driver specific
> to the graphics hardware of the Marvell PXA3xx processor family", would
> be a bit more useful.

It have take some times for me to find out what this option is for and
what kind of devices are supported by this option, so at least directfb
is something for the frame buffer the most people know the options are
of course depending on this frame buffer and graphic output related things.
So I think it's worth to explain a little bit more than just 'it's for
the Marvel PXA family foo ...'. But yes, we can discuss about the word
and formulation. ;)
I will rethink about that.

Regards
Carsten

  reply	other threads:[~2013-03-10 12:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  9:47 [Buildroot] [PATCH 0/0] Updating directfb and divine Carsten Schoenert
2013-03-10  9:47 ` [Buildroot] [PATCH 1/4] directfb: bumping version to 1.6.3 Carsten Schoenert
2013-03-10 10:32   ` Thomas Petazzoni
2013-03-10 12:34     ` Carsten Schoenert
2013-03-17 13:59       ` Carsten Schoenert
2013-03-21  6:56         ` Arnout Vandecappelle
2013-03-21 18:06           ` Carsten Schoenert
2013-03-21 19:13             ` Thomas Petazzoni
2013-04-02 21:56               ` Carsten Schoenert
2013-03-10 16:50     ` Carsten Schoenert
2013-03-10 17:25       ` Thomas Petazzoni
2013-03-10  9:47 ` [Buildroot] [PATCH 2/4] divine: " Carsten Schoenert
2013-03-10  9:47 ` [Buildroot] [PATCH 3/4] directfb: expanding the help strings Carsten Schoenert
2013-03-10 10:27   ` Thomas Petazzoni
2013-03-10 12:21     ` Carsten Schoenert [this message]
2013-03-10 13:13       ` Thomas Petazzoni
2013-03-10  9:47 ` [Buildroot] [PATCH 4/4] directfb: fixing typo in variables Carsten Schoenert
2013-03-10 10:25   ` Thomas Petazzoni
2013-03-10 12:23     ` Carsten Schoenert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513C7AB2.3080000@googlemail.com \
    --to=c.schoenert@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox