From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] directfb: bumping version to 1.6.3
Date: Thu, 21 Mar 2013 20:13:52 +0100 [thread overview]
Message-ID: <20130321201352.6b9455c2@skate> (raw)
In-Reply-To: <514B4C15.7080702@googlemail.com>
Dear Carsten Schoenert,
On Thu, 21 Mar 2013 19:06:13 +0100, Carsten Schoenert wrote:
> > How it _should_ be is that as many configure options as possible are
> > specified explicitly in the .mk file. In particular, any configure option
> > that is set to the non-default value in the .mk file, should also be set
> > explicitly to the default value.
>
> You mean for example
> --enable-svg build SVG image provider [default=yes]
> should be set by default to 'yes' and so on for the other 'default=yes'
> options?
> The options with default=auto should will be automaticly detected by
> configure and mostly it isn't useful to explicitly deactivating them
> because that breaks the binarys so leaving them.
No, I think Arnout means that we should leave as few options
"automatically" detected as possible.
For example, we really like to have:
ifeq ($(BR2_PACKAGE_FOO_FEATURE_BAR),y)
FOO_CONF_OPT += --enable-bar
else
FOO_CONF_OPT += --disable-bar
endif
and for all options that are not explicitly --enable-<bleh> somewhere,
have a global:
FOO_CONF_OPT += \
--disable-<bleh> \
--disable-<blah>
this avoids the configure script from automatically detecting things on
the host machine that we don't want it to detect.
> > But of course, a lot of that is not the case now, because the rule is
> > not strictly enforced. Anything you fix during the version bump is nice
> > to have, but you're not obliged to fix it if you don't know how to (and
> > we expect you to have tested the change, so that means trying out a
> > number of different configurations...).
>
> Yes I can't test all variations so thats why I ask here how to do it
> best. I'm working with a toolchain for a ARMv6 platform on a settopbox
> there we need directfb so I test mostly of my work on this settopbox.
We have autobuilders that test a big number of random configurations,
so you definitely don't have to test all combinations.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-03-21 19:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 9:47 [Buildroot] [PATCH 0/0] Updating directfb and divine Carsten Schoenert
2013-03-10 9:47 ` [Buildroot] [PATCH 1/4] directfb: bumping version to 1.6.3 Carsten Schoenert
2013-03-10 10:32 ` Thomas Petazzoni
2013-03-10 12:34 ` Carsten Schoenert
2013-03-17 13:59 ` Carsten Schoenert
2013-03-21 6:56 ` Arnout Vandecappelle
2013-03-21 18:06 ` Carsten Schoenert
2013-03-21 19:13 ` Thomas Petazzoni [this message]
2013-04-02 21:56 ` Carsten Schoenert
2013-03-10 16:50 ` Carsten Schoenert
2013-03-10 17:25 ` Thomas Petazzoni
2013-03-10 9:47 ` [Buildroot] [PATCH 2/4] divine: " Carsten Schoenert
2013-03-10 9:47 ` [Buildroot] [PATCH 3/4] directfb: expanding the help strings Carsten Schoenert
2013-03-10 10:27 ` Thomas Petazzoni
2013-03-10 12:21 ` Carsten Schoenert
2013-03-10 13:13 ` Thomas Petazzoni
2013-03-10 9:47 ` [Buildroot] [PATCH 4/4] directfb: fixing typo in variables Carsten Schoenert
2013-03-10 10:25 ` Thomas Petazzoni
2013-03-10 12:23 ` Carsten Schoenert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321201352.6b9455c2@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox