From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint
Date: Sat, 11 May 2013 12:10:53 +0200 [thread overview]
Message-ID: <20130511121053.53f32058@skate> (raw)
In-Reply-To: <1368265366-24526-1-git-send-email-olivier.schonken@gmail.com>
Dear Olivier Schonken,
On Sat, 11 May 2013 11:42:46 +0200, Olivier Schonken wrote:
> This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
> Because there is no host-cups package, host-gutenprint cant build the
> host-cups drivers - missing includes and libs. Host gutenprint only
> built to get the xml. Thus not a loss.
>
> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
>
> Corrected absent minded mistake. Thanks Thomas
> ---
> package/gutenprint/gutenprint.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, but the "Corrected absent minded mistake..." sentence should be
below the "---" sign, otherwise, it will remain part of the commit
history forever.
Also, when you send a new version of a patch, please make sure to
change the title from PATCH 1/1 to PATCH v2 1/1. This can be achieved
by doing git format-patch --subject-prefix="PATCH v2". --subject-prefix
also works directly with git send-email.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-05-11 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 7:57 [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint Olivier Schonken
2013-05-11 9:07 ` Thomas Petazzoni
2013-05-11 9:42 ` Olivier Schonken
2013-05-11 10:10 ` Thomas Petazzoni [this message]
2013-05-11 10:21 ` [Buildroot] [PATCH v2 " Olivier Schonken
2013-05-11 19:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130511121053.53f32058@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox