Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint
Date: Sat, 11 May 2013 11:07:35 +0200	[thread overview]
Message-ID: <20130511110735.36112d4f@skate> (raw)
In-Reply-To: <1368259049-27252-1-git-send-email-olivier.schonken@gmail.com>

Dear Olivier Schonken,

On Sat, 11 May 2013 09:57:29 +0200, Olivier Schonken wrote:
> This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
> Because there is no host-cups package, host-gutenprint cant build the
> host-cups drivers - missing includes and libs.  Host gutenprint only
> built to get the xml. Thus not a loss.
> 
> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
> ---
>  package/gutenprint/gutenprint.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk
> index 0463771..49816f6 100644
> --- a/package/gutenprint/gutenprint.mk
> +++ b/package/gutenprint/gutenprint.mk
> @@ -29,7 +29,7 @@ GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \
>                        --disable-escputil \
>                        --disable-test \
>                        --disable-testpattern \
> -                      --with-cups="/usr" \
> +                      --without-cups \
>                        --with-sysroot="$(STAGING_DIR)" \
>                        --disable-cups-ppds
>  

Hum, in your commit description, you're mentionning "host-cups" does
not exist, so host-gutenprint shouldn't try to build with CUPS support.
But in your patch, you're changing GUTENPRINT_CONF_OPT, i.e the
configuration option of gutenprint for the target.

Could you explain in a few more details the relation between your
commit log and the patch itself?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-05-11  9:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11  7:57 [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint Olivier Schonken
2013-05-11  9:07 ` Thomas Petazzoni [this message]
2013-05-11  9:42 ` Olivier Schonken
2013-05-11 10:10   ` Thomas Petazzoni
2013-05-11 10:21   ` [Buildroot] [PATCH v2 " Olivier Schonken
2013-05-11 19:22     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130511110735.36112d4f@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox