* [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint
@ 2013-05-11 7:57 Olivier Schonken
2013-05-11 9:07 ` Thomas Petazzoni
2013-05-11 9:42 ` Olivier Schonken
0 siblings, 2 replies; 6+ messages in thread
From: Olivier Schonken @ 2013-05-11 7:57 UTC (permalink / raw)
To: buildroot
This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Because there is no host-cups package, host-gutenprint cant build the
host-cups drivers - missing includes and libs. Host gutenprint only
built to get the xml. Thus not a loss.
Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
---
package/gutenprint/gutenprint.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk
index 0463771..49816f6 100644
--- a/package/gutenprint/gutenprint.mk
+++ b/package/gutenprint/gutenprint.mk
@@ -29,7 +29,7 @@ GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \
--disable-escputil \
--disable-test \
--disable-testpattern \
- --with-cups="/usr" \
+ --without-cups \
--with-sysroot="$(STAGING_DIR)" \
--disable-cups-ppds
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint
2013-05-11 7:57 [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint Olivier Schonken
@ 2013-05-11 9:07 ` Thomas Petazzoni
2013-05-11 9:42 ` Olivier Schonken
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2013-05-11 9:07 UTC (permalink / raw)
To: buildroot
Dear Olivier Schonken,
On Sat, 11 May 2013 09:57:29 +0200, Olivier Schonken wrote:
> This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
> Because there is no host-cups package, host-gutenprint cant build the
> host-cups drivers - missing includes and libs. Host gutenprint only
> built to get the xml. Thus not a loss.
>
> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
> ---
> package/gutenprint/gutenprint.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk
> index 0463771..49816f6 100644
> --- a/package/gutenprint/gutenprint.mk
> +++ b/package/gutenprint/gutenprint.mk
> @@ -29,7 +29,7 @@ GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \
> --disable-escputil \
> --disable-test \
> --disable-testpattern \
> - --with-cups="/usr" \
> + --without-cups \
> --with-sysroot="$(STAGING_DIR)" \
> --disable-cups-ppds
>
Hum, in your commit description, you're mentionning "host-cups" does
not exist, so host-gutenprint shouldn't try to build with CUPS support.
But in your patch, you're changing GUTENPRINT_CONF_OPT, i.e the
configuration option of gutenprint for the target.
Could you explain in a few more details the relation between your
commit log and the patch itself?
Thanks a lot!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint
2013-05-11 7:57 [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint Olivier Schonken
2013-05-11 9:07 ` Thomas Petazzoni
@ 2013-05-11 9:42 ` Olivier Schonken
2013-05-11 10:10 ` Thomas Petazzoni
2013-05-11 10:21 ` [Buildroot] [PATCH v2 " Olivier Schonken
1 sibling, 2 replies; 6+ messages in thread
From: Olivier Schonken @ 2013-05-11 9:42 UTC (permalink / raw)
To: buildroot
This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Because there is no host-cups package, host-gutenprint cant build the
host-cups drivers - missing includes and libs. Host gutenprint only
built to get the xml. Thus not a loss.
Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
Corrected absent minded mistake. Thanks Thomas
---
package/gutenprint/gutenprint.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk
index 0463771..072fada 100644
--- a/package/gutenprint/gutenprint.mk
+++ b/package/gutenprint/gutenprint.mk
@@ -51,7 +51,8 @@ HOST_GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \
--without-foomatic3 \
--disable-escputil \
--disable-test \
- --disable-testpattern
+ --disable-testpattern \
+ --without-cups
# Needed by autoreconf
define GUTENPRINT_CREATE_M4_DIR
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint
2013-05-11 9:42 ` Olivier Schonken
@ 2013-05-11 10:10 ` Thomas Petazzoni
2013-05-11 10:21 ` [Buildroot] [PATCH v2 " Olivier Schonken
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2013-05-11 10:10 UTC (permalink / raw)
To: buildroot
Dear Olivier Schonken,
On Sat, 11 May 2013 11:42:46 +0200, Olivier Schonken wrote:
> This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
> Because there is no host-cups package, host-gutenprint cant build the
> host-cups drivers - missing includes and libs. Host gutenprint only
> built to get the xml. Thus not a loss.
>
> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
>
> Corrected absent minded mistake. Thanks Thomas
> ---
> package/gutenprint/gutenprint.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, but the "Corrected absent minded mistake..." sentence should be
below the "---" sign, otherwise, it will remain part of the commit
history forever.
Also, when you send a new version of a patch, please make sure to
change the title from PATCH 1/1 to PATCH v2 1/1. This can be achieved
by doing git format-patch --subject-prefix="PATCH v2". --subject-prefix
also works directly with git send-email.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/1] Disable building of cups driver in host-gutenprint
2013-05-11 9:42 ` Olivier Schonken
2013-05-11 10:10 ` Thomas Petazzoni
@ 2013-05-11 10:21 ` Olivier Schonken
2013-05-11 19:22 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Olivier Schonken @ 2013-05-11 10:21 UTC (permalink / raw)
To: buildroot
This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Because there is no host-cups package, host-gutenprint cant build the
host-cups drivers - missing includes and libs. Host gutenprint only
built to get the xml. Thus not a loss.
Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
---
Corrected absent minded mistake. Thanks Thomas
package/gutenprint/gutenprint.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk
index 0463771..072fada 100644
--- a/package/gutenprint/gutenprint.mk
+++ b/package/gutenprint/gutenprint.mk
@@ -51,7 +51,8 @@ HOST_GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \
--without-foomatic3 \
--disable-escputil \
--disable-test \
- --disable-testpattern
+ --disable-testpattern \
+ --without-cups
# Needed by autoreconf
define GUTENPRINT_CREATE_M4_DIR
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH v2 1/1] Disable building of cups driver in host-gutenprint
2013-05-11 10:21 ` [Buildroot] [PATCH v2 " Olivier Schonken
@ 2013-05-11 19:22 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-05-11 19:22 UTC (permalink / raw)
To: buildroot
>>>>> "Olivier" == Olivier Schonken <olivier.schonken@gmail.com> writes:
Olivier> This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Olivier> Because there is no host-cups package, host-gutenprint cant build the
Olivier> host-cups drivers - missing includes and libs. Host gutenprint only
Olivier> built to get the xml. Thus not a loss.
Olivier> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
Olivier> ---
Olivier> Corrected absent minded mistake. Thanks Thomas
Olivier> package/gutenprint/gutenprint.mk | 3 ++-
Olivier> 1 file changed, 2 insertions(+), 1 deletion(-)
Olivier> diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk
Olivier> index 0463771..072fada 100644
Olivier> --- a/package/gutenprint/gutenprint.mk
Olivier> +++ b/package/gutenprint/gutenprint.mk
Olivier> @@ -51,7 +51,8 @@ HOST_GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \
Olivier> --without-foomatic3 \
Olivier> --disable-escputil \
Olivier> --disable-test \
Olivier> - --disable-testpattern
Olivier> + --disable-testpattern \
Olivier> + --without-cups
Indentation is off compared to the other lines, but I've fixed that.
After some more testing I've found out that I also have to set an
explicit ac_cv_path_CUPS_CONFIG, otherwise the output of the (host)
cups-config is still added to CFLAGS/LDFLAGS.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-11 19:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-11 7:57 [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint Olivier Schonken
2013-05-11 9:07 ` Thomas Petazzoni
2013-05-11 9:42 ` Olivier Schonken
2013-05-11 10:10 ` Thomas Petazzoni
2013-05-11 10:21 ` [Buildroot] [PATCH v2 " Olivier Schonken
2013-05-11 19:22 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox