Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] Disable building of cups driver in host-gutenprint
Date: Sat, 11 May 2013 21:22:14 +0200	[thread overview]
Message-ID: <87y5bl1fvd.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1368267696-5839-1-git-send-email-olivier.schonken@gmail.com> (Olivier Schonken's message of "Sat, 11 May 2013 12:21:35 +0200")

>>>>> "Olivier" == Olivier Schonken <olivier.schonken@gmail.com> writes:

 Olivier> This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
 Olivier> Because there is no host-cups package, host-gutenprint cant build the
 Olivier> host-cups drivers - missing includes and libs.  Host gutenprint only
 Olivier> built to get the xml. Thus not a loss.

 Olivier> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>

 Olivier> ---

 Olivier> Corrected absent minded mistake. Thanks Thomas

 Olivier>  package/gutenprint/gutenprint.mk |    3 ++-
 Olivier>  1 file changed, 2 insertions(+), 1 deletion(-)

 Olivier> diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk
 Olivier> index 0463771..072fada 100644
 Olivier> --- a/package/gutenprint/gutenprint.mk
 Olivier> +++ b/package/gutenprint/gutenprint.mk
 Olivier> @@ -51,7 +51,8 @@ HOST_GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \
 Olivier>                             --without-foomatic3 \
 Olivier>                             --disable-escputil \
 Olivier>                             --disable-test \
 Olivier> -                           --disable-testpattern
 Olivier> +                           --disable-testpattern \
 Olivier> +			   --without-cups

Indentation is off compared to the other lines, but I've fixed that.

After some more testing I've found out that I also have to set an
explicit ac_cv_path_CUPS_CONFIG, otherwise the output of the (host)
cups-config is still added to CFLAGS/LDFLAGS.

Committed, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2013-05-11 19:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11  7:57 [Buildroot] [PATCH 1/1] Disable building of cups driver in host-gutenprint Olivier Schonken
2013-05-11  9:07 ` Thomas Petazzoni
2013-05-11  9:42 ` Olivier Schonken
2013-05-11 10:10   ` Thomas Petazzoni
2013-05-11 10:21   ` [Buildroot] [PATCH v2 " Olivier Schonken
2013-05-11 19:22     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5bl1fvd.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox