From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/6] package infra: remove CPPFLAGS from CFLAGS
Date: Mon, 13 May 2013 19:10:16 +0200 [thread overview]
Message-ID: <20130513191016.15f0a3f4@skate> (raw)
In-Reply-To: <1368463259-18958-1-git-send-email-gustavo@zacarias.com.ar>
Dear Gustavo Zacarias,
On Mon, 13 May 2013 13:40:54 -0300, Gustavo Zacarias wrote:
> -TARGET_CFLAGS = $(TARGET_CPPFLAGS) $(TARGET_ABI) $(TARGET_OPTIMIZATION) $(TARGET_DEBUGGING)
> +TARGET_CFLAGS = $(TARGET_ABI) $(TARGET_OPTIMIZATION) $(TARGET_DEBUGGING)
> TARGET_CXXFLAGS = $(TARGET_CFLAGS)
> TARGET_LDFLAGS = $(call qstrip,$(BR2_TARGET_LDFLAGS))
>
> @@ -179,7 +179,6 @@ SED:=$(shell which sed || type -p sed) -i -e
>
> HOST_CPPFLAGS = -I$(HOST_DIR)/usr/include
> HOST_CFLAGS ?= -O2
> -HOST_CFLAGS += $(HOST_CPPFLAGS)
> HOST_CXXFLAGS += $(HOST_CFLAGS)
> HOST_LDFLAGS += -L$(HOST_DIR)/lib -L$(HOST_DIR)/usr/lib -Wl,-rpath,$(HOST_DIR)/usr/lib
> HOST_PATH=$(HOST_DIR)/bin:$(HOST_DIR)/usr/bin:$(PATH)
Do we have packages that pass TARGET_CFLAGS and/or HOST_CFLAGS, and are
not passing TARGET_CPPFLAGS / HOST_CPPFLAGS ?
One example: the bsdiff package:
define BSDIFF_BUILD_CMDS
$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) \
$(@D)/bsdiff.c -lbz2 -o $(@D)/bsdiff
$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) \
$(@D)/bspatch.c -lbz2 -o $(@D)/bspatch
endef
After your patch, the -D_LARGEFILE_BLABLA stuff is no longer passed
when building this package.
Another example, the feh package. Another one, input-tools. And I'm
sure there are more.
So, I agree with the change, but I think it needs a much thorough
investigation of which packages are using $(TARGET_CFLAGS) without
passing $(TARGET_CPPFLAGS).
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-05-13 17:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 16:40 [Buildroot] [PATCH 1/6] package infra: remove CPPFLAGS from CFLAGS Gustavo Zacarias
2013-05-13 16:40 ` [Buildroot] [PATCH 2/6] libnspr: bump to version 4.9.6 Gustavo Zacarias
2013-05-13 16:40 ` [Buildroot] [PATCH 3/6] libnss: bump to version 3.14.3 Gustavo Zacarias
2013-05-26 20:14 ` Peter Korsgaard
2013-05-13 16:40 ` [Buildroot] [PATCH 4/6] libcurl: bump to version 7.30.0 Gustavo Zacarias
2013-05-14 22:32 ` Arnout Vandecappelle
2013-05-14 22:47 ` Gustavo Zacarias
2013-05-13 16:40 ` [Buildroot] [PATCH 5/6] p11-kit: new package Gustavo Zacarias
2013-05-13 16:40 ` [Buildroot] [PATCH 6/6] gnutls: bump to version 3.2.0 Gustavo Zacarias
2013-05-14 22:36 ` Arnout Vandecappelle
2013-05-14 22:49 ` Gustavo Zacarias
2013-05-16 6:17 ` [Buildroot] Config options for optional dependencies [was: [PATCH 6/6] gnutls: bump to version 3.2.0] Arnout Vandecappelle
2013-05-16 8:50 ` Thomas Petazzoni
2013-05-13 17:10 ` Thomas Petazzoni [this message]
2013-05-13 17:22 ` [Buildroot] [PATCH 1/6] package infra: remove CPPFLAGS from CFLAGS Gustavo Zacarias
2013-05-13 18:20 ` Thomas Petazzoni
2013-05-13 22:09 ` Gustavo Zacarias
2013-05-13 23:02 ` Arnout Vandecappelle
2013-05-14 7:17 ` Thomas Petazzoni
2013-05-14 8:54 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513191016.15f0a3f4@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox