[Buildroot] [PATCH 1/2] linux: qstrip the custom DTS path

[Buildroot] [PATCH 1/2] linux: qstrip the custom DTS path

[Thomas Petazzoni]

This fixes a problem reported by wacha at mit.bme.hu, see
http://lists.busybox.net/pipermail/buildroot/2013-June/073312.html.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 linux/linux.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux/linux.mk b/linux/linux.mk
index 11b32c3..177446d 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -55,7 +55,7 @@ LINUX_VERSION_PROBED = $(shell $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) --no-
 ifeq ($(BR2_LINUX_KERNEL_USE_INTREE_DTS),y)
 KERNEL_DTS_NAME = $(call qstrip,$(BR2_LINUX_KERNEL_INTREE_DTS_NAME))
 else ifeq ($(BR2_LINUX_KERNEL_USE_CUSTOM_DTS),y)
-KERNEL_DTS_NAME = $(basename $(notdir $(BR2_LINUX_KERNEL_CUSTOM_DTS_PATH)))
+KERNEL_DTS_NAME = $(basename $(notdir $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_DTS_PATH))))
 endif
 
 ifeq ($(BR2_LINUX_KERNEL_DTS_SUPPORT)$(KERNEL_DTS_NAME),y)
-- 
1.8.1.2

[Buildroot] [PATCH 2/2] sunxi-boards: set a default board

[Thomas Petazzoni]

The default configuration doesn't set any board, but the
sunxi-boards.mk file errors out if no board is defined. This causes a
large number of build failures in the autobuilders, such as
http://autobuild.buildroot.org/results/b92/b928edc07f0939531d76833a17c851889ae06677/build-end.log.

The proposed approach to solve this is to set a default board. An
alternative approach would have been to remove the check that ensures
that a board has been set, but I believe it's less obvious for the
user.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/sunxi-boards/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/sunxi-boards/Config.in b/package/sunxi-boards/Config.in
index d9fd852..d8c82e0 100644
--- a/package/sunxi-boards/Config.in
+++ b/package/sunxi-boards/Config.in
@@ -13,6 +13,7 @@ config BR2_PACKAGE_SUNXI_BOARDS
 if BR2_PACKAGE_SUNXI_BOARDS
 config BR2_PACKAGE_SUNXI_BOARDS_FEX_FILE
 	string ".fex file to compile"
+	default "a10/hackberry.fex"
 	help
 	  This field defines the name of the .fex file for which the
 	  .bin file should be generated.
-- 
1.8.1.2

[Buildroot] [PATCH 2/2] sunxi-boards: set a default board

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> The default configuration doesn't set any board, but the
 Thomas> sunxi-boards.mk file errors out if no board is defined. This causes a
 Thomas> large number of build failures in the autobuilders, such as
 Thomas> http://autobuild.buildroot.org/results/b92/b928edc07f0939531d76833a17c851889ae06677/build-end.log.

 Thomas> The proposed approach to solve this is to set a default board. An
 Thomas> alternative approach would have been to remove the check that ensures
 Thomas> that a board has been set, but I believe it's less obvious for the
 Thomas> user.

That won't help as it then just fails when it tries to build/install.


 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 Thomas> ---
 Thomas>  package/sunxi-boards/Config.in | 1 +
 Thomas>  1 file changed, 1 insertion(+)

 Thomas> diff --git a/package/sunxi-boards/Config.in b/package/sunxi-boards/Config.in
 Thomas> index d9fd852..d8c82e0 100644
 Thomas> --- a/package/sunxi-boards/Config.in
 Thomas> +++ b/package/sunxi-boards/Config.in
 Thomas> @@ -13,6 +13,7 @@ config BR2_PACKAGE_SUNXI_BOARDS
 Thomas>  if BR2_PACKAGE_SUNXI_BOARDS
 Thomas>  config BR2_PACKAGE_SUNXI_BOARDS_FEX_FILE
 Thomas>  	string ".fex file to compile"
 Thomas> +	default "a10/hackberry.fex"

Hmm, how is this different that what we do for the barebox/u-boot/linux
configurations?

If people forget to set a sensible _FEX_FILE they now silently get the
wrong stuff (if they don't build for hackberry) instead of a clear error
message.

Wouldn't it make more sense to blacklist the package or preseed
BR2_PACKAGE_SUNXI_BOARDS_FEX_FILE to a sensible value in the autobuilder
scripts?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 2/2] sunxi-boards: set a default board

[Thomas Petazzoni]

Dear Peter Korsgaard,

On Wed, 05 Jun 2013 21:14:51 +0200, Peter Korsgaard wrote:

>  Thomas> The default configuration doesn't set any board, but the
>  Thomas> sunxi-boards.mk file errors out if no board is defined. This causes a
>  Thomas> large number of build failures in the autobuilders, such as
>  Thomas> http://autobuild.buildroot.org/results/b92/b928edc07f0939531d76833a17c851889ae06677/build-end.log.
> 
>  Thomas> The proposed approach to solve this is to set a default board. An
>  Thomas> alternative approach would have been to remove the check that ensures
>  Thomas> that a board has been set, but I believe it's less obvious for the
>  Thomas> user.
> 
> That won't help as it then just fails when it tries to build/install.

Well, we could tune the build/install step to not fail if
BR2_PACKAGE_SUNXI_BOARDS_FEX_FILE is empty, but I don't think we want
to do that.

> Hmm, how is this different that what we do for the barebox/u-boot/linux
> configurations?

It is different in that this package starts with BR2_PACKAGE, so it can
get selected by the randpackageconfig logic, while barebox/u-boot/linux
Kconfig options don't start by BR2_PACKAGE, so they don't get selected
by randpackageconfig :)

> If people forget to set a sensible _FEX_FILE they now silently get the
> wrong stuff (if they don't build for hackberry) instead of a clear error
> message.

Right.

> Wouldn't it make more sense to blacklist the package or preseed
> BR2_PACKAGE_SUNXI_BOARDS_FEX_FILE to a sensible value in the autobuilder
> scripts?

Ok, will do that. Will you also do the same on your autobuilders? I
really should clean up my script, and share it so that we can try to
run the same logic.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2/2] sunxi-boards: set a default board

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 >> Hmm, how is this different that what we do for the barebox/u-boot/linux
 >> configurations?

 Thomas> It is different in that this package starts with BR2_PACKAGE,
 Thomas> so it can get selected by the randpackageconfig logic, while
 Thomas> barebox/u-boot/linux Kconfig options don't start by
 Thomas> BR2_PACKAGE, so they don't get selected by randpackageconfig :)

True, but we have the same problem with E.G. BR2_PACKAG
E_QT_LICENSE_APPROVED / BR2_PACKAGE_QT5BASE_LICENSE_APPROVED. If these
are not set the build will also get stuck, so we preseed them in the
autobuilders (I do atleast).

 >> Wouldn't it make more sense to blacklist the package or preseed
 >> BR2_PACKAGE_SUNXI_BOARDS_FEX_FILE to a sensible value in the autobuilder
 >> scripts?

 Thomas> Ok, will do that. Will you also do the same on your
 Thomas> autobuilders? I really should clean up my script, and share it
 Thomas> so that we can try to run the same logic.

Yes, I'll fixup "mine" as well.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 2/2] sunxi-boards: set a default board

[Thomas Petazzoni]

Dear Peter Korsgaard,

On Wed, 05 Jun 2013 21:45:25 +0200, Peter Korsgaard wrote:

>  Thomas> It is different in that this package starts with BR2_PACKAGE,
>  Thomas> so it can get selected by the randpackageconfig logic, while
>  Thomas> barebox/u-boot/linux Kconfig options don't start by
>  Thomas> BR2_PACKAGE, so they don't get selected by randpackageconfig :)
> 
> True, but we have the same problem with E.G. BR2_PACKAG
> E_QT_LICENSE_APPROVED / BR2_PACKAGE_QT5BASE_LICENSE_APPROVED. If these
> are not set the build will also get stuck, so we preseed them in the
> autobuilders (I do atleast).

I do this as well (well, as you've noted from the build results, at
some point I wasn't doing it for Qt5 which was causing some timeouts),
but generally, that's what I do.

>  >> Wouldn't it make more sense to blacklist the package or preseed
>  >> BR2_PACKAGE_SUNXI_BOARDS_FEX_FILE to a sensible value in the autobuilder
>  >> scripts?
> 
>  Thomas> Ok, will do that. Will you also do the same on your
>  Thomas> autobuilders? I really should clean up my script, and share it
>  Thomas> so that we can try to run the same logic.
> 
> Yes, I'll fixup "mine" as well.

While you're at it, can you change your build result submit script to
no longer include the full build log (it gets deleted anyway once it
arrives on the server, they consume too much disk space), and increase
the length of the "build end log" to 500 lines instead of 100 lines?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2/2] sunxi-boards: set a default board

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 Thomas> While you're at it, can you change your build result submit
 Thomas> script to no longer include the full build log (it gets deleted
 Thomas> anyway once it arrives on the server, they consume too much
 Thomas> disk space), and increase the length of the "build end log" to
 Thomas> 500 lines instead of 100 lines?

Sure, done!

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] linux: qstrip the custom DTS path

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> This fixes a problem reported by wacha at mit.bme.hu, see
 Thomas> http://lists.busybox.net/pipermail/buildroot/2013-June/073312.html.

Committed, thanks.

-- 
Bye, Peter Korsgaard