Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] New package: libqrencode
Date: Fri, 14 Jun 2013 11:24:37 +0300	[thread overview]
Message-ID: <20130614082437.GB4312@tarshish> (raw)
In-Reply-To: <1371197197-16323-1-git-send-email-phil@zankapfel.net>

Hi Phil,

Thanks for contributing. A couple of comments below.

On Fri, Jun 14, 2013 at 10:06:37AM +0200, Phil Eichinger wrote:
> 
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> ---

[...]

> diff --git a/package/libqrencode/libqrencode.mk 
> b/package/libqrencode/libqrencode.mk
> new file mode 100644
> index 0000000..121fd86
> --- /dev/null
> +++ b/package/libqrencode/libqrencode.mk
> @@ -0,0 +1,20 @@
> +#############################################################
> +#
> +# libqrencode
> +#
> +#############################################################
> +
> +LIBQRENCODE_VERSION = 3.4.2
> +LIBQRENCODE_SOURCE = qrencode-$(LIBQRENCODE_VERSION).tar.gz

This the default, you can remove this line.

> +LIBQRENCODE_SITE = http://fukuchi.org/works/qrencode
> +LIBQRENCODE_DEPENDENCIES = libpng
> +LIBQRENCODE_LICENSE = GPLv2+

The web page and README/COPYING file say the license is LGPLv2.1+. 

> +LIBQRENCODE_LICENSE_FILES = COPYING
> +
> +ifeq ($(BR2_PACKAGE_LIBQRENCODE_TOOLS),y)
> +        LIBQRENCODE_CONF_OPT += --with-tools=yes
> +else
> +        LIBQRENCODE_CONF_OPT += --with-tools=no
> +endif
> +
> +$(eval $(autotools-package))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2013-06-14  8:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  8:06 [Buildroot] [PATCH 1/1] New package: libqrencode Phil Eichinger
2013-06-14  8:24 ` Baruch Siach [this message]
2013-06-14  8:46   ` Phil Eichinger
  -- strict thread matches above, loose matches on Subject: below --
2013-06-14  8:47 Phil Eichinger
2013-06-15 20:10 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130614082437.GB4312@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox