* [Buildroot] [PATCH 1/1] New package: libqrencode
@ 2013-06-14 8:06 Phil Eichinger
2013-06-14 8:24 ` Baruch Siach
0 siblings, 1 reply; 5+ messages in thread
From: Phil Eichinger @ 2013-06-14 8:06 UTC (permalink / raw)
To: buildroot
Signed-off-by: Phil Eichinger <phil@zankapfel.net>
---
package/Config.in | 1 +
package/libqrencode/Config.in | 20 ++++++++++++++++++++
package/libqrencode/libqrencode.mk | 20 ++++++++++++++++++++
3 files changed, 41 insertions(+)
create mode 100644 package/libqrencode/Config.in
create mode 100644 package/libqrencode/libqrencode.mk
diff --git a/package/Config.in b/package/Config.in
index ce82e99..3f4cbca 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -138,6 +138,7 @@ source "package/sdl_sound/Config.in"
source "package/sdl_net/Config.in"
source "package/sdl_ttf/Config.in"
source "package/sdl_gfx/Config.in"
+source "package/libqrencode/Config.in"
comment "other GUIs"
source "package/efl/Config.in"
diff --git a/package/libqrencode/Config.in b/package/libqrencode/Config.in
new file mode 100644
index 0000000..285dba0
--- /dev/null
+++ b/package/libqrencode/Config.in
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_LIBQRENCODE
+ bool "libqrencode"
+ select BR2_PACKAGE_LIBPNG
+ help
+ libqrencode is a C library for encoding data in a QR Code
+ symbol, a kind of 2D symbology that can be scanned by handy
+ terminals such as a mobile phone with CCD. The capacity of
+ QR Code is up to 7000 digits or 4000 characters, and is
+ highly robust.
+
+ http://fukuchi.org/works/qrencode/index.html
+
+if BR2_PACKAGE_LIBQRENCODE
+
+config BR2_PACKAGE_LIBQRENCODE_TOOLS
+ bool "Command-line tools"
+ help
+ Build command-line tools
+
+endif #BR2_PACKAGE_LIBQRENCODE
diff --git a/package/libqrencode/libqrencode.mk b/package/libqrencode/libqrencode.mk
new file mode 100644
index 0000000..121fd86
--- /dev/null
+++ b/package/libqrencode/libqrencode.mk
@@ -0,0 +1,20 @@
+#############################################################
+#
+# libqrencode
+#
+#############################################################
+
+LIBQRENCODE_VERSION = 3.4.2
+LIBQRENCODE_SOURCE = qrencode-$(LIBQRENCODE_VERSION).tar.gz
+LIBQRENCODE_SITE = http://fukuchi.org/works/qrencode
+LIBQRENCODE_DEPENDENCIES = libpng
+LIBQRENCODE_LICENSE = GPLv2+
+LIBQRENCODE_LICENSE_FILES = COPYING
+
+ifeq ($(BR2_PACKAGE_LIBQRENCODE_TOOLS),y)
+ LIBQRENCODE_CONF_OPT += --with-tools=yes
+else
+ LIBQRENCODE_CONF_OPT += --with-tools=no
+endif
+
+$(eval $(autotools-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] New package: libqrencode
2013-06-14 8:06 [Buildroot] [PATCH 1/1] New package: libqrencode Phil Eichinger
@ 2013-06-14 8:24 ` Baruch Siach
2013-06-14 8:46 ` Phil Eichinger
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2013-06-14 8:24 UTC (permalink / raw)
To: buildroot
Hi Phil,
Thanks for contributing. A couple of comments below.
On Fri, Jun 14, 2013 at 10:06:37AM +0200, Phil Eichinger wrote:
>
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> ---
[...]
> diff --git a/package/libqrencode/libqrencode.mk
> b/package/libqrencode/libqrencode.mk
> new file mode 100644
> index 0000000..121fd86
> --- /dev/null
> +++ b/package/libqrencode/libqrencode.mk
> @@ -0,0 +1,20 @@
> +#############################################################
> +#
> +# libqrencode
> +#
> +#############################################################
> +
> +LIBQRENCODE_VERSION = 3.4.2
> +LIBQRENCODE_SOURCE = qrencode-$(LIBQRENCODE_VERSION).tar.gz
This the default, you can remove this line.
> +LIBQRENCODE_SITE = http://fukuchi.org/works/qrencode
> +LIBQRENCODE_DEPENDENCIES = libpng
> +LIBQRENCODE_LICENSE = GPLv2+
The web page and README/COPYING file say the license is LGPLv2.1+.
> +LIBQRENCODE_LICENSE_FILES = COPYING
> +
> +ifeq ($(BR2_PACKAGE_LIBQRENCODE_TOOLS),y)
> + LIBQRENCODE_CONF_OPT += --with-tools=yes
> +else
> + LIBQRENCODE_CONF_OPT += --with-tools=no
> +endif
> +
> +$(eval $(autotools-package))
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] New package: libqrencode
2013-06-14 8:24 ` Baruch Siach
@ 2013-06-14 8:46 ` Phil Eichinger
0 siblings, 0 replies; 5+ messages in thread
From: Phil Eichinger @ 2013-06-14 8:46 UTC (permalink / raw)
To: buildroot
On 14 June 2013 10:24, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Phil,
>
> Thanks for contributing. A couple of comments below.
>
> On Fri, Jun 14, 2013 at 10:06:37AM +0200, Phil Eichinger wrote:
> >
> > Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> > ---
>
> [...]
>
> > diff --git a/package/libqrencode/libqrencode.mk
> > b/package/libqrencode/libqrencode.mk
> > new file mode 100644
> > index 0000000..121fd86
> > --- /dev/null
> > +++ b/package/libqrencode/libqrencode.mk
> > @@ -0,0 +1,20 @@
> > +#############################################################
> > +#
> > +# libqrencode
> > +#
> > +#############################################################
> > +
> > +LIBQRENCODE_VERSION = 3.4.2
> > +LIBQRENCODE_SOURCE = qrencode-$(LIBQRENCODE_VERSION).tar.gz
>
> This the default, you can remove this line.
>
If i remove this line it defaults to libqrencode-3.4.2.tar.gz, but the
actual filename is qrencode-3.4.2.tar.gz
>
> > +LIBQRENCODE_SITE = http://fukuchi.org/works/qrencode
> > +LIBQRENCODE_DEPENDENCIES = libpng
> > +LIBQRENCODE_LICENSE = GPLv2+
>
> The web page and README/COPYING file say the license is LGPLv2.1+.
>
You are absolutely correct, sorry about that, I'll post an updated patch.
cheers, Phil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130614/bf5bc602/attachment.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] New package: libqrencode
@ 2013-06-14 8:47 Phil Eichinger
2013-06-15 20:10 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Phil Eichinger @ 2013-06-14 8:47 UTC (permalink / raw)
To: buildroot
Signed-off-by: Phil Eichinger <phil@zankapfel.net>
---
package/Config.in | 1 +
package/libqrencode/Config.in | 20 ++++++++++++++++++++
package/libqrencode/libqrencode.mk | 20 ++++++++++++++++++++
3 files changed, 41 insertions(+)
create mode 100644 package/libqrencode/Config.in
create mode 100644 package/libqrencode/libqrencode.mk
diff --git a/package/Config.in b/package/Config.in
index ce82e99..3f4cbca 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -138,6 +138,7 @@ source "package/sdl_sound/Config.in"
source "package/sdl_net/Config.in"
source "package/sdl_ttf/Config.in"
source "package/sdl_gfx/Config.in"
+source "package/libqrencode/Config.in"
comment "other GUIs"
source "package/efl/Config.in"
diff --git a/package/libqrencode/Config.in b/package/libqrencode/Config.in
new file mode 100644
index 0000000..285dba0
--- /dev/null
+++ b/package/libqrencode/Config.in
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_LIBQRENCODE
+ bool "libqrencode"
+ select BR2_PACKAGE_LIBPNG
+ help
+ libqrencode is a C library for encoding data in a QR Code
+ symbol, a kind of 2D symbology that can be scanned by handy
+ terminals such as a mobile phone with CCD. The capacity of
+ QR Code is up to 7000 digits or 4000 characters, and is
+ highly robust.
+
+ http://fukuchi.org/works/qrencode/index.html
+
+if BR2_PACKAGE_LIBQRENCODE
+
+config BR2_PACKAGE_LIBQRENCODE_TOOLS
+ bool "Command-line tools"
+ help
+ Build command-line tools
+
+endif #BR2_PACKAGE_LIBQRENCODE
diff --git a/package/libqrencode/libqrencode.mk b/package/libqrencode/libqrencode.mk
new file mode 100644
index 0000000..d47f866
--- /dev/null
+++ b/package/libqrencode/libqrencode.mk
@@ -0,0 +1,20 @@
+#############################################################
+#
+# libqrencode
+#
+#############################################################
+
+LIBQRENCODE_VERSION = 3.4.2
+LIBQRENCODE_SOURCE = qrencode-$(LIBQRENCODE_VERSION).tar.gz
+LIBQRENCODE_SITE = http://fukuchi.org/works/qrencode
+LIBQRENCODE_DEPENDENCIES = libpng
+LIBQRENCODE_LICENSE = LGPLv2.1+
+LIBQRENCODE_LICENSE_FILES = COPYING
+
+ifeq ($(BR2_PACKAGE_LIBQRENCODE_TOOLS),y)
+ LIBQRENCODE_CONF_OPT += --with-tools=yes
+else
+ LIBQRENCODE_CONF_OPT += --with-tools=no
+endif
+
+$(eval $(autotools-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] New package: libqrencode
2013-06-14 8:47 Phil Eichinger
@ 2013-06-15 20:10 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2013-06-15 20:10 UTC (permalink / raw)
To: buildroot
>>>>> "Phil" == Phil Eichinger <phil@zankapfel.net> writes:
Phil> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
Phil> ---
Phil> package/Config.in | 1 +
Phil> package/libqrencode/Config.in | 20 ++++++++++++++++++++
Phil> package/libqrencode/libqrencode.mk | 20 ++++++++++++++++++++
Phil> 3 files changed, 41 insertions(+)
Phil> create mode 100644 package/libqrencode/Config.in
Phil> create mode 100644 package/libqrencode/libqrencode.mk
Phil> diff --git a/package/Config.in b/package/Config.in
Phil> index ce82e99..3f4cbca 100644
Phil> --- a/package/Config.in
Phil> +++ b/package/Config.in
Phil> @@ -138,6 +138,7 @@ source "package/sdl_sound/Config.in"
Phil> source "package/sdl_net/Config.in"
Phil> source "package/sdl_ttf/Config.in"
Phil> source "package/sdl_gfx/Config.in"
Phil> +source "package/libqrencode/Config.in"
This is a library, so it belongs in libraries->graphics, just under
libpng.
Phil> comment "other GUIs"
Phil> source "package/efl/Config.in"
Phil> diff --git a/package/libqrencode/Config.in b/package/libqrencode/Config.in
Phil> new file mode 100644
Phil> index 0000000..285dba0
Phil> --- /dev/null
Phil> +++ b/package/libqrencode/Config.in
Phil> @@ -0,0 +1,20 @@
Phil> +config BR2_PACKAGE_LIBQRENCODE
Phil> + bool "libqrencode"
Phil> + select BR2_PACKAGE_LIBPNG
Phil> + help
Config.in files should be indented with <tab> and not spaces.
Phil> + libqrencode is a C library for encoding data in a QR Code
Phil> + symbol, a kind of 2D symbology that can be scanned by handy
Phil> + terminals such as a mobile phone with CCD. The capacity of
Phil> + QR Code is up to 7000 digits or 4000 characters, and is
Phil> + highly robust.
Your help text as a trailing space on each line.
Phil> +
Phil> + http://fukuchi.org/works/qrencode/index.html
Phil> +
Phil> +if BR2_PACKAGE_LIBQRENCODE
Phil> +
Phil> +config BR2_PACKAGE_LIBQRENCODE_TOOLS
Phil> + bool "Command-line tools"
Phil> + help
Phil> + Build command-line tools
Phil> +
Phil> +endif #BR2_PACKAGE_LIBQRENCODE
Phil> diff --git a/package/libqrencode/libqrencode.mk b/package/libqrencode/libqrencode.mk
Phil> new file mode 100644
Phil> index 0000000..d47f866
Phil> --- /dev/null
Phil> +++ b/package/libqrencode/libqrencode.mk
Phil> @@ -0,0 +1,20 @@
Phil> +#############################################################
Phil> +#
Phil> +# libqrencode
Phil> +#
Phil> +#############################################################
Phil> +
Phil> +LIBQRENCODE_VERSION = 3.4.2
Phil> +LIBQRENCODE_SOURCE = qrencode-$(LIBQRENCODE_VERSION).tar.gz
Phil> +LIBQRENCODE_SITE = http://fukuchi.org/works/qrencode
Phil> +LIBQRENCODE_DEPENDENCIES = libpng
Phil> +LIBQRENCODE_LICENSE = LGPLv2.1+
Phil> +LIBQRENCODE_LICENSE_FILES = COPYING
Libraries should be installed into $(STAGING_DIR) as well, so other
packages can find them, so there should be a
LIBQRENCODE_INSTALL_STAGING = YES
Committed with these things fixed up, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-15 20:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-14 8:06 [Buildroot] [PATCH 1/1] New package: libqrencode Phil Eichinger
2013-06-14 8:24 ` Baruch Siach
2013-06-14 8:46 ` Phil Eichinger
-- strict thread matches above, loose matches on Subject: below --
2013-06-14 8:47 Phil Eichinger
2013-06-15 20:10 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox